C#•3y ago

✅ JsonConvert.DeserializeObject return contains all null elements

Using

Newtonsoft.Json

Newtonsoft.Json

Newtonsoft.Json

Newtonsoft.Json, I have the following JSON (attached) with the following deserializer code:

    public class ObjectDB
    {
        public struct DBFile
        {
            long Timestamp;
            List<Class> Classes;
            List<Object> Objects;
            List<Category> Categories;
        }
        struct Class
        {
            string InternalName;
            string Name;
            string Notes;
            int Games;
            int Progress;
            Dictionary<string, Parameter> Parameters;
        }

        struct ArgValue
        {
            string Value;
            string Notes;
        }

        struct Object
        {
            string InternalName;
            string ClassNameSMG1;
            string ClassNameSMG2;
            string Name;
            string Notes;
            string Category;
            string AreaShape;
            string ListSMG1;
            string ListSMG2;
            string File;
            int Games;
            int Progress;
            bool IsUnused;
            bool IsLeftover;
        }

        struct Category
        {
            string Key;
            string Description;
        }

        struct Parameter
        {
            string Name;
            string Type;
            int Games;
            bool Needed;
            string Description;
            List<ArgValue> Values;
            List<string> Exclusives;
        }

        public static void LoadDB()
        {
            JsonSerializerSettings settings = new();
            sDatabase = JsonConvert.DeserializeObject<DBFile>(File.ReadAllText("res/objectdb.json"), settings);
        }

        static DBFile sDatabase;
    }

    public class ObjectDB
    {
        public struct DBFile
        {
            long Timestamp;
            List<Class> Classes;
            List<Object> Objects;
            List<Category> Categories;
        }
        struct Class
        {
            string InternalName;
            string Name;
            string Notes;
            int Games;
            int Progress;
            Dictionary<string, Parameter> Parameters;
        }

        struct ArgValue
        {
            string Value;
            string Notes;
        }

        struct Object
        {
            string InternalName;
            string ClassNameSMG1;
            string ClassNameSMG2;
            string Name;
            string Notes;
            string Category;
            string AreaShape;
            string ListSMG1;
            string ListSMG2;
            string File;
            int Games;
            int Progress;
            bool IsUnused;
            bool IsLeftover;
        }

        struct Category
        {
            string Key;
            string Description;
        }

        struct Parameter
        {
            string Name;
            string Type;
            int Games;
            bool Needed;
            string Description;
            List<ArgValue> Values;
            List<string> Exclusives;
        }

        public static void LoadDB()
        {
            JsonSerializerSettings settings = new();
            sDatabase = JsonConvert.DeserializeObject<DBFile>(File.ReadAllText("res/objectdb.json"), settings);
        }

        static DBFile sDatabase;
    }

    public class ObjectDB
    {
        public struct DBFile
        {
            long Timestamp;
            List<Class> Classes;
            List<Object> Objects;
            List<Category> Categories;
        }
        struct Class
        {
            string InternalName;
            string Name;
            string Notes;
            int Games;
            int Progress;
            Dictionary<string, Parameter> Parameters;
        }

        struct ArgValue
        {
            string Value;
            string Notes;
        }

        struct Object
        {
            string InternalName;
            string ClassNameSMG1;
            string ClassNameSMG2;
            string Name;
            string Notes;
            string Category;
            string AreaShape;
            string ListSMG1;
            string ListSMG2;
            string File;
            int Games;
            int Progress;
            bool IsUnused;
            bool IsLeftover;
        }

        struct Category
        {
            string Key;
            string Description;
        }

        struct Parameter
        {
            string Name;
            string Type;
            int Games;
            bool Needed;
            string Description;
            List<ArgValue> Values;
            List<string> Exclusives;
        }

        public static void LoadDB()
        {
            JsonSerializerSettings settings = new();
            sDatabase = JsonConvert.DeserializeObject<DBFile>(File.ReadAllText("res/objectdb.json"), settings);
        }

        static DBFile sDatabase;
    }

    public class ObjectDB
    {
        public struct DBFile
        {
            long Timestamp;
            List<Class> Classes;
            List<Object> Objects;
            List<Category> Categories;
        }
        struct Class
        {
            string InternalName;
            string Name;
            string Notes;
            int Games;
            int Progress;
            Dictionary<string, Parameter> Parameters;
        }

        struct ArgValue
        {
            string Value;
            string Notes;
        }

        struct Object
        {
            string InternalName;
            string ClassNameSMG1;
            string ClassNameSMG2;
            string Name;
            string Notes;
            string Category;
            string AreaShape;
            string ListSMG1;
            string ListSMG2;
            string File;
            int Games;
            int Progress;
            bool IsUnused;
            bool IsLeftover;
        }

        struct Category
        {
            string Key;
            string Description;
        }

        struct Parameter
        {
            string Name;
            string Type;
            int Games;
            bool Needed;
            string Description;
            List<ArgValue> Values;
            List<string> Exclusives;
        }

        public static void LoadDB()
        {
            JsonSerializerSettings settings = new();
            sDatabase = JsonConvert.DeserializeObject<DBFile>(File.ReadAllText("res/objectdb.json"), settings);
        }

        static DBFile sDatabase;
    }

However, the deserializer is not throwing an error but every element of

DBFile

DBFile

DBFile

DBFile is null.

https://cdn.discordapp.com/attachments/1177777512525340752/1179410186717364324/image.png?ex=6579ae54&is=65673954&hm=c0ab82bfb39fd7785f407e64f07aaba100ba3cad3f1326bf4a59fb3b4a3935f4&

objectdb.json2.82MB

cap5lut•11/29/23, 1:41 PM

that is the default behaviour, if u want to change that u will have to pass some settings:
https://www.newtonsoft.com/json/help/html/DeserializeMissingMemberHandling.htm

shibboleetOP•11/29/23, 1:43 PM

interesting

shibboleetOP•11/29/23, 1:44 PM

ah, I think I see what happens

shibboleetOP•11/29/23, 1:45 PM

good 'ol formatting and string escapes

shibboleetOP•11/29/23, 1:48 PM

not exactly sure how to approach that

Ccap5lut that is the default behaviour, if u want to change that u will have to pass some...

cap5lut•11/29/23, 1:52 PM

thats actually the wrong thingy.
this configures what happens if the JSON has some property that is not mapped to the POCO

to set if it throws or sets to

null

null

, it seems u need a custom ContractResolverContractResolver:
https://stackoverflow.com/questions/57673787/how-to-throw-a-jsonserializationexception-when-a-property-is-missing-in-the-json#answer-57680436

shibboleetOP•11/29/23, 1:53 PM

the issue moreso lies in the inability of it to properly parse the JSON due to string formatting

Sshibboleet Click to see attachment

cap5lut•11/29/23, 1:54 PM

do u mean because the \r\n\r\ns in there?

shibboleetOP•11/29/23, 1:54 PM

¯\_(ツ)_/¯

shibboleetOP•11/29/23, 1:54 PM

it can't find an obvious key that is clearly there, so something is blocking it from doing so

cap5lut•11/29/23, 1:54 PM

because they dont cause an issue, these are whitespaces (a windows line break to be exactly)

shibboleetOP•11/29/23, 1:54 PM

removed the \r\n formatting strings but it still fails

shibboleetOP•11/29/23, 1:55 PM

perhaps it's the \"Timestamp\"\"Timestamp\"

cap5lut•11/29/23, 1:55 PM

nope, thats just how visual studio displays the string

shibboleetOP•11/29/23, 1:55 PM

then I can't tell you what the issue is here

shibboleetOP•11/29/23, 1:56 PM

it can't find the key "Timestamp" even though it's there

cap5lut•11/29/23, 1:56 PM

aaah, i think i see the issue

cap5lut•11/29/23, 1:56 PM

its the typical property vs field thingy i guess

shibboleetOP•11/29/23, 1:56 PM

hm?

cap5lut•11/29/23, 1:57 PM

well, basically u have a bunch of private fields like DBFile.TimestampDBFile.Timestamp, by default these are ignored

cap5lut•11/29/23, 1:58 PM

By default a type's properties are serialized in opt-out mode. What that means is that all public fields and properties with getters are automatically serialized to JSON, and fields and properties that shouldn't be serialized are opted-out by placing JsonIgnoreAttribute on them. To serialize private members, the JsonPropertyAttribute can be placed on private fields and properties.

shibboleetOP•11/29/23, 1:59 PM

The More You Know

shibboleetOP•11/29/23, 1:59 PM

that would indeed do it

cap5lut•11/29/23, 2:00 PM

btw is there a specific reason u r newtonsoft.json over System.Text.JsonSystem.Text.Json?
since .net 7 the latter is the preferred library for this

shibboleetOP•11/29/23, 2:00 PM

hard to teach an old dog new tricks I guess haha

cap5lut•11/29/23, 2:03 PM

well, u wouldve run into the same issue anyway xD
but if u do not have to deal with somewhat broken JSON or some other niche use case thats a deviation from the standard, STJ is the better option.
its part of the BCL, its more performant and supports source generated (de-)serialization

shibboleetOP•11/29/23, 2:03 PM

alrighty, thanks! appreciate the help

cap5lut•11/29/23, 2:04 PM

glad i could help o7
if the problem is now solved, please dont forget to $close the thread

Ccap5lut glad i could help o7 if the problem is now solved, please dont forget to $close ...

MODiX•11/29/23, 2:04 PM

Use the </close:1007753098107813888> command to mark a forum thread as answered

✅ JsonConvert.DeserializeObject return contains all null elements

Similar Threads

Similar Threads

Similar Threads