Novu•2y ago

Better proxy support

Hi, I'm using on premise Novu on our cloud infrastructure. I had some issues with proxies over https leading to 502 error when using axios. It's a known issue with Axios.
I made a PR for fixing in send in blue to use cross fetch and proxy agent. It will work without proxy and also with standard proxy configuration like variable environment
https://github.com/novuhq/novu/pull/5065

GitHub

fix(provider): add better proxy support for brevo mail provider by ...

What change does this PR introduce?
Add better proxy for brevo mail provider as axios may leads to 502 error when having proxy over HTTPS
Why was this change needed?
Using actual provider leads to ...

Zac Clifton•1/31/24, 12:23 PM

@Richard Fontein @Paweł T. This request would fall under enterprise readiness as it is something most enterprises would request but at the system level and not just each provider.
Where do you think we can put this request?

@Pawan Jain Is there a way we can add this to our roadmap so users can upvote this?

Pawan Jain•1/31/24, 12:26 PM

Yeah sure, I am adding this in our roadmap

ZZac Clifton @Richard Fontein @Paweł T. This request would fall under enterprise readiness a...

Paweł T.•2/1/24, 11:30 AM

If we can answer whether this will be part of the enterprise plan, then we will know where we can put this request. cc @Dima Grossman

Nao OhiraOP•2/7/24, 7:53 AM

Hi. I just saw that 0.23 tag has been created. As we cannot use it without better proxy support (not working at all because of 502 error), we will try to deploy from source with our modifications as we cannot wait until next tag.

Nao OhiraOP•2/7/24, 7:57 AM

I wanted to know what would be the best solution for having something stable enough for using in production? Having merging my modification to main instead of next?

Novu_Bot•2/7/24, 7:57 AM

@Nao Ohira, you just advanced to level 3!