Hello everyone,

Themba · 2024-02-23T17:00:00.170Z

I'm working on a Windows Forms application and I'm having trouble with my CheckBox controls. I have three GroupBoxes, and I want the CheckBoxes inside the third GroupBox to display a MessageBox when clicked. However, the MessageBox only appears after I click the RadioButtons in the other two GroupBoxes first. I've attached my code to a text file for reference. Could someone help me figure out how to make the MessageBox appear immediately when I click the CheckBoxes inside the third GroupBox? Thank you!

P

Pobiega•2/23/24, 5:03 PM

Please share your code at $paste so we can actually see all of it

PPobiega Please share your code at $paste so we can actually see all of it

M

MODiX•2/23/24, 5:03 PM

If your code is too long, you can post to https://paste.mod.gg/ and copy the link into chat for others to see your shared code!

T

ThembaOP•2/23/24, 5:14 PM

https://paste.mod.gg/msxdoavemmky/0

BlazeBin - msxdoavemmky

A tool for sharing your source code with the world!

P

Pobiega•2/23/24, 5:15 PM

and the problem is that currently your messagebox does not show when you check a checkbox in the third group?

T

ThembaOP•2/23/24, 5:15 PM

yes

P

Pobiega•2/23/24, 5:15 PM

ok so lets look at your code

P

Pobiega•2/23/24, 5:15 PM

// Buttons in third group
private void groupBox_CheckBoxes_CheckedChanged(object sender, EventArgs e)
{
    // Loop through GroupBoxes in groupBox
    // CheckBox c in groupBox_CheckBoxes.Controls.OfType<CheckBox>()

    // Access checkBox Controls in groupBox
    foreach (CheckBox cb in groupBox_CheckBoxes.Controls)
    {
        // Check and see if cb is a CheckBox
        if (cb is CheckBox checkBox)
        {
            // Check if box is clicked
            if (checkBox.Checked) 
            {
                MessageBox.Show("Hello World");
            }
        }
    }
    Update_Total_Amount_Due();
}

// Buttons in third group
private void groupBox_CheckBoxes_CheckedChanged(object sender, EventArgs e)
{
    // Loop through GroupBoxes in groupBox
    // CheckBox c in groupBox_CheckBoxes.Controls.OfType<CheckBox>()

    // Access checkBox Controls in groupBox
    foreach (CheckBox cb in groupBox_CheckBoxes.Controls)
    {
        // Check and see if cb is a CheckBox
        if (cb is CheckBox checkBox)
        {
            // Check if box is clicked
            if (checkBox.Checked) 
            {
                MessageBox.Show("Hello World");
            }
        }
    }
    Update_Total_Amount_Due();
}

// Buttons in third group
private void groupBox_CheckBoxes_CheckedChanged(object sender, EventArgs e)
{
    // Loop through GroupBoxes in groupBox
    // CheckBox c in groupBox_CheckBoxes.Controls.OfType<CheckBox>()

    // Access checkBox Controls in groupBox
    foreach (CheckBox cb in groupBox_CheckBoxes.Controls)
    {
        // Check and see if cb is a CheckBox
        if (cb is CheckBox checkBox)
        {
            // Check if box is clicked
            if (checkBox.Checked) 
            {
                MessageBox.Show("Hello World");
            }
        }
    }
    Update_Total_Amount_Due();
}

// Buttons in third group
private void groupBox_CheckBoxes_CheckedChanged(object sender, EventArgs e)
{
    // Loop through GroupBoxes in groupBox
    // CheckBox c in groupBox_CheckBoxes.Controls.OfType<CheckBox>()

    // Access checkBox Controls in groupBox
    foreach (CheckBox cb in groupBox_CheckBoxes.Controls)
    {
        // Check and see if cb is a CheckBox
        if (cb is CheckBox checkBox)
        {
            // Check if box is clicked
            if (checkBox.Checked) 
            {
                MessageBox.Show("Hello World");
            }
        }
    }
    Update_Total_Amount_Due();
}

P

Pobiega•2/23/24, 5:15 PM

immediately I see a big red flag

P

Pobiega•2/23/24, 5:16 PM

foreach (CheckBox cb in groupBox_CheckBoxes.Controls)

foreach (CheckBox cb in groupBox_CheckBoxes.Controls)

foreach (CheckBox cb in groupBox_CheckBoxes.Controls)

foreach (CheckBox cb in groupBox_CheckBoxes.Controls) might seem like a good thing, but its not

P

Pobiega•2/23/24, 5:16 PM

Controls

Controls

Controls

Controls is not a list of checkboxes, its a list of controls

T

ThembaOP•2/23/24, 5:18 PM

I think I understand so what should I use to gain access to my checkBoxes?

P

Pobiega•2/23/24, 5:19 PM

foreach (var item in groupBox1.Controls)

foreach (var item in groupBox1.Controls)

foreach (var item in groupBox1.Controls)

foreach (var item in groupBox1.Controls)

P

Pobiega•2/23/24, 5:19 PM

then you can check the types

P

Pobiega•2/23/24, 5:21 PM

some sample code:

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls)
{
    if(item is not CheckBox cb)
    {
        continue;
    }

    if (cb.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls)
{
    if(item is not CheckBox cb)
    {
        continue;
    }

    if (cb.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls)
{
    if(item is not CheckBox cb)
    {
        continue;
    }

    if (cb.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls)
{
    if(item is not CheckBox cb)
    {
        continue;
    }

    if (cb.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

P

Pobiega•2/23/24, 5:22 PM

alternatively you can use

OfType

OfType

OfType

OfType as such

P

Pobiega•2/23/24, 5:22 PM

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls.OfType<CheckBox>())
{
    if (item.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls.OfType<CheckBox>())
{
    if (item.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls.OfType<CheckBox>())
{
    if (item.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

var checkedBoxes = 0;
foreach (var item in groupBox1.Controls.OfType<CheckBox>())
{
    if (item.Checked)
    {
        checkedBoxes++;
    }
}

MessageBox.Show($"{checkedBoxes} boxes are checked.");

P

Pobiega•2/23/24, 5:22 PM

item

item

here is then guaranteed to be a CheckBox

T

ThembaOP•2/23/24, 5:39 PM

Issue: It works for the first time but not after. After the first MessageBox, when I click on my other checkBoxes, the MessageBox will not show until I click on the radioButtons in my other groupBoxes. Once I've clicked on the other radio buttons, when I go back to click on my checkboxes, only then will the new MessageBox work or render on the screen.

Updated code: https://paste.mod.gg/ujazbufowwyc/0

BlazeBin - ujazbufowwyc

A tool for sharing your source code with the world!

P

Pobiega•2/23/24, 5:58 PM

hm

P

Pobiega•2/23/24, 5:59 PM

there is a second file of code called

Form1.Designer.cs

Form1.Designer.cs

Form1.Designer.cs

Form1.Designer.cs

P

Pobiega•2/23/24, 5:59 PM

can you paste the code for that one too?

P

Pobiega•2/23/24, 5:59 PM

it sounds like some of your controls dont have their events wired up correctly

T

ThembaOP•2/23/24, 7:53 PM

https://paste.mod.gg/dwmuwhmlfivk/0

BlazeBin - dwmuwhmlfivk

A tool for sharing your source code with the world!

P

Pobiega•2/23/24, 8:00 PM

only

checkBox1

checkBox1

checkBox1

checkBox1 has the event handler registered

P

Pobiega•2/23/24, 8:00 PM

            // 
            // checkBox2
            // 
            this.checkBox2.AutoSize = true;
            this.checkBox2.Location = new System.Drawing.Point(23, 117);
            this.checkBox2.Name = "checkBox2";
            this.checkBox2.Size = new System.Drawing.Size(170, 30);
            this.checkBox2.TabIndex = 1;
            this.checkBox2.Text = "Extra Cheese";
            this.checkBox2.UseVisualStyleBackColor = true;
            // 
            // checkBox1
            // 
            this.checkBox1.AutoSize = true;
            this.checkBox1.Location = new System.Drawing.Point(23, 56);
            this.checkBox1.Name = "checkBox1";
            this.checkBox1.Size = new System.Drawing.Size(137, 30);
            this.checkBox1.TabIndex = 0;
            this.checkBox1.Text = "Pepperoni";
            this.checkBox1.UseVisualStyleBackColor = true;
            this.checkBox1.CheckedChanged += new System.EventHandler(this.checkBox1_CheckedChanged);

            // 
            // checkBox2
            // 
            this.checkBox2.AutoSize = true;
            this.checkBox2.Location = new System.Drawing.Point(23, 117);
            this.checkBox2.Name = "checkBox2";
            this.checkBox2.Size = new System.Drawing.Size(170, 30);
            this.checkBox2.TabIndex = 1;
            this.checkBox2.Text = "Extra Cheese";
            this.checkBox2.UseVisualStyleBackColor = true;
            // 
            // checkBox1
            // 
            this.checkBox1.AutoSize = true;
            this.checkBox1.Location = new System.Drawing.Point(23, 56);
            this.checkBox1.Name = "checkBox1";
            this.checkBox1.Size = new System.Drawing.Size(137, 30);
            this.checkBox1.TabIndex = 0;
            this.checkBox1.Text = "Pepperoni";
            this.checkBox1.UseVisualStyleBackColor = true;
            this.checkBox1.CheckedChanged += new System.EventHandler(this.checkBox1_CheckedChanged);

            // 
            // checkBox2
            // 
            this.checkBox2.AutoSize = true;
            this.checkBox2.Location = new System.Drawing.Point(23, 117);
            this.checkBox2.Name = "checkBox2";
            this.checkBox2.Size = new System.Drawing.Size(170, 30);
            this.checkBox2.TabIndex = 1;
            this.checkBox2.Text = "Extra Cheese";
            this.checkBox2.UseVisualStyleBackColor = true;
            // 
            // checkBox1
            // 
            this.checkBox1.AutoSize = true;
            this.checkBox1.Location = new System.Drawing.Point(23, 56);
            this.checkBox1.Name = "checkBox1";
            this.checkBox1.Size = new System.Drawing.Size(137, 30);
            this.checkBox1.TabIndex = 0;
            this.checkBox1.Text = "Pepperoni";
            this.checkBox1.UseVisualStyleBackColor = true;
            this.checkBox1.CheckedChanged += new System.EventHandler(this.checkBox1_CheckedChanged);

            // 
            // checkBox2
            // 
            this.checkBox2.AutoSize = true;
            this.checkBox2.Location = new System.Drawing.Point(23, 117);
            this.checkBox2.Name = "checkBox2";
            this.checkBox2.Size = new System.Drawing.Size(170, 30);
            this.checkBox2.TabIndex = 1;
            this.checkBox2.Text = "Extra Cheese";
            this.checkBox2.UseVisualStyleBackColor = true;
            // 
            // checkBox1
            // 
            this.checkBox1.AutoSize = true;
            this.checkBox1.Location = new System.Drawing.Point(23, 56);
            this.checkBox1.Name = "checkBox1";
            this.checkBox1.Size = new System.Drawing.Size(137, 30);
            this.checkBox1.TabIndex = 0;
            this.checkBox1.Text = "Pepperoni";
            this.checkBox1.UseVisualStyleBackColor = true;
            this.checkBox1.CheckedChanged += new System.EventHandler(this.checkBox1_CheckedChanged);

P

Pobiega•2/23/24, 8:00 PM

2 to 9 do not

P

Pobiega•2/23/24, 8:00 PM

so only the first checkbox actually runs any code

P

Pobiega•2/23/24, 8:01 PM

this one is also highly unexpected:

this.groupBox_CheckBoxes.Enter += new System.EventHandler(this.groupBox_CheckBoxes_CheckedChanged);

this.groupBox_CheckBoxes.Enter += new System.EventHandler(this.groupBox_CheckBoxes_CheckedChanged);

this.groupBox_CheckBoxes.Enter += new System.EventHandler(this.groupBox_CheckBoxes_CheckedChanged);

this.groupBox_CheckBoxes.Enter += new System.EventHandler(this.groupBox_CheckBoxes_CheckedChanged);

T

ThembaOP•2/24/24, 8:29 AM

I'm new to WPF I don't understand why it would be unusual.

P

Pobiega•2/24/24, 11:02 AM

This is winforms, not WPF

T

ThembaOP•2/24/24, 12:04 PM

sorry you are correct either wya im lost and don't know how to proceed to get my code to work

P

Pobiega•2/24/24, 12:43 PM

well, did you connect all the checkboxes to the correct event?

P

Pobiega•2/24/24, 12:43 PM

as said, only 1 of the 9 checkboxes were previously connected

T

ThembaOP•2/24/24, 1:51 PM

yes https://paste.mod.gg/nrrvnweiwjcn/0

BlazeBin - nrrvnweiwjcn

A tool for sharing your source code with the world!

P

Pobiega•2/24/24, 1:51 PM

okay

P

Pobiega•2/24/24, 1:52 PM

and this didnt solve your problems?

T

ThembaOP•2/24/24, 1:52 PM

Nope same issue

P

Pobiega•2/24/24, 1:54 PM

gotta admit I don't fully understand what you are having problems with

P

Pobiega•2/24/24, 1:56 PM

can you upload your entire project somewhere like github?

T

ThembaOP•2/24/24, 1:58 PM

Alright it'll just take me a couple of Mins

T

ThembaOP•2/24/24, 2:08 PM

https://github.com/Themba619/Question1

GitHub

GitHub - Themba619/Question1

Contribute to Themba619/Question1 development by creating an account on GitHub.

P

Pobiega•2/24/24, 2:08 PM

P

Pobiega•2/24/24, 2:10 PM

oh, its .NET Framework O_o

P

Pobiega•2/24/24, 2:11 PM

Thats not a huge problem, but you should be aware that its an 8+ year old version that will no longer be updated and no new development should use without extremely good reasons

P

Pobiega•2/24/24, 2:12 PM

ok, gotta ask, are you trolling?

P

Pobiega•2/24/24, 2:12 PM

T

ThembaOP•2/24/24, 2:12 PM

No just new to all this

P

Pobiega•2/24/24, 2:13 PM

those are all empty

P

Pobiega•2/24/24, 2:13 PM

you've wired your checkboxes up to empty handler methods that contain no code

P

Pobiega•2/24/24, 2:13 PM

and the actual code that you want to run when a checkbox is checked is written in the wrong handler

Hello everyone,

Similar Threads

Similar Threads

Similar Threads