Powershell command no longer working after update

Hey! Is there any way for me to log commands?

I have a custom powershell command that's just blank so I can run anything I need via home assistant through it, and I have in my path a script called "bt.ps1"

Before updating & migrating from the old version, this worked perfectly fine as such:

service: mqtt.publish
data:
  topic: homeassistant/button/MainPC/PowershellCustom/action
  payload: bt.ps1 -BluetoothStatus {{ btstatus }}

service: mqtt.publish
data:
  topic: homeassistant/button/MainPC/PowershellCustom/action
  payload: bt.ps1 -BluetoothStatus {{ btstatus }}

service: mqtt.publish
data:
  topic: homeassistant/button/MainPC/PowershellCustom/action
  payload: bt.ps1 -BluetoothStatus {{ btstatus }}

service: mqtt.publish
data:
  topic: homeassistant/button/MainPC/PowershellCustom/action
  payload: bt.ps1 -BluetoothStatus {{ btstatus }}

But now it doesn't work. Running the powershell command manually works just fine

Solution

yeah i found out, because the apps have the exact same name and I started them from windows I kept starting different ones each time

The windows bar has a nifty feature when you have 2 programs with the same program name whenever you type it in the search bar it ALTERNATES between the two

So that messed up the config somehow, looks like on the new version the mqtt topic changed

Jump to solution

HASS.Agent Helper•2/28/24, 10:42 AM

Help us Help Others!

To help others find answers, you can mark your question as solved via

Right click solution message -> Apps -> ✅ Mark Solution

Right click solution message -> Apps -> ✅ Mark Solution

HASS.Agent Helper•2/28/24, 10:42 AM

Help us Help You!

Please don't delete messages or posts because it makes it impossible to understand what happened. If you don't want your messages to be seen then don't post here.

Please provide us with the version number of your client.

You can find it in the HA device info page after 'Firmware'.

Make sure to provide detailed reports of bugs.

Please include error log uploads and info about the bug.

HASS.Agent Helper•2/28/24, 10:42 AM

@Amadeo

barrelltitorOP•2/28/24, 11:03 AM

https://github.com/hass-agent/HASS.Agent/pull/47 using the script from here to test won't even show up anything

GitHub

Fix: Powershell command argument binding by amadeo-alex · Pull Requ...

This PR fixes how action arguments are passed on to the PowershellCommand.
Previously whole action string was passed as a one argument, this prevented parameter binding - after the changes the acti...

derailius•2/28/24, 11:15 AM

I'm just a newb, but I'm pretty sure you need the full path to bt.ps1 in your payload?

derailius•2/28/24, 11:15 AM

at least, that's how mine are configured

barrelltitorOP•2/28/24, 11:32 AM

I have it in a folder that's declared in my environment so anything I put in there can be used as a "command", e.g if I put the test.ps1 in that folder I can just run "test.ps1" from any powershell window

barrelltitorOP•2/28/24, 11:33 AM

Even running it with the full path won't work

barrelltitorOP•2/28/24, 11:33 AM

The key point here is that the only difference between when it worked before 1 hour ago and when it stopped working is me updating to the new client, so there must be something going on there

derailius•2/28/24, 11:33 AM

see? this is why i prefaced my comment! lol

barrelltitorOP•2/28/24, 11:34 AM

Yeah all good, you learn something new every day, I'm a powershell noob too

derailius•2/28/24, 11:35 AM

that is clever though, and you've just made me change my entire setup, declaring once, is sooo much cleaner than having to do it for every script. thanks! ok, enough derailing

Bbarrelltitor https://github.com/hass-agent/HASS.Agent/pull/47 using the script from here to t...

Amadeo•2/28/24, 2:16 PM

FYI that PR has been merged into a development branch of 2.1.0 release (that's not released yet :D)

barrelltitorOP•2/28/24, 2:30 PM

Yeah I'm just saying it doesn't pop up anything at all, no arguments or anything

barrelltitorOP•2/28/24, 2:30 PM

Nothing runs

barrelltitorOP•2/28/24, 5:18 PM

Just running a custom command not a powershell one works fine, I just add powershell to my command in HA and im all good

DrR0x•2/28/24, 8:23 PM

Well I guess that works but this seems really weird

DrR0x•2/28/24, 8:24 PM

@Amadeo doesn't the extended logs report when commands are run and info about them or is that something you enable in visual studio?

barrelltitorOP•2/28/24, 8:30 PM

Should I make a PR for a feature request to be added in? I'd say that fits into extended logs and is quite useful, e.g

Command X ran with arguments <here>

DrR0x•2/28/24, 8:31 PM

You definitely could but I think we might have this so let's check with Amadeo first.

Would fit best as an extra toggle or even file but this will work. We can add stuff like this for v3

Amadeo•2/28/24, 8:34 PM

I think I missed smth, example from the PR mentioned below will not work with current version, are we talking right now about adding extended logging "always" ("always" because there will be "[POWERSHELL] [{name}] Launching PS {descriptor} with action '{action}' failed" logged when execution fails)

Amadeo•2/28/24, 8:34 PM

or about some bug

Amadeo•2/28/24, 8:35 PM

there were additional changes before this PR that could of broken compatibility with the original one

DrR0x•2/28/24, 8:35 PM

Adding it always. Hence the reason I reckon an extra toggle but that's more complex. (And requires another 5 minute walk)

Amadeo•2/28/24, 8:36 PM

@barrelltitor can I please have the ps script? I'll test it on the PR branch to see it it'll start working again

Amadeo•2/28/24, 8:36 PM

oh wait

Amadeo•2/28/24, 8:37 PM

you've been providing command and the parameters as one payload

payload: bt.ps1 -BluetoothStatus {{ btstatus }}

payload: bt.ps1 -BluetoothStatus {{ btstatus }}

Amadeo•2/28/24, 8:38 PM

I'm not quite certain that it was ever supported, hmm
if the "action" doesn't end with ".ps1" it will be treated as a command and not script, this really worked before?

Amadeo•2/28/24, 8:38 PM

how is the command configured within HASS.Agent?

barrelltitorOP•2/28/24, 9:02 PM

It worked before i updated

barrelltitorOP•2/28/24, 9:03 PM

Changed nothing before or after updating, the only change was that it stopped working

I did get it working like this using just "Custom" instead of custom powershell, so that works for me

barrelltitorOP•2/28/24, 9:04 PM

I can revert back to hass agent and take a video of it working if it helps in any way, but I've had it working like this forever

I didn'[t even know I had to provide an "action" lol

barrelltitorOP•2/28/24, 9:04 PM

It always worked just with "payload" set to the entire command

Bbarrelltitor I can revert back to hass agent and take a video of it working if it helps in an...

Amadeo•2/28/24, 9:05 PM

na, not worth it

barrelltitorOP•2/28/24, 9:05 PM

I'd give logs but the logs don't record commands

barrelltitorOP•2/28/24, 9:06 PM

For me personally it's kinda fixed as I can use custom

barrelltitorOP•2/28/24, 9:06 PM

Oh @Amadeo I actually got it from the docs

barrelltitorOP•2/28/24, 9:07 PM

Docs example:

  action:
    - service: mqtt.publish
      data:
        topic: "homeassistant/switch/test-vm/test-vm_custom/action"
        payload: "\"C:\\Program Files\\BowPad\\BowPad.exe\""

  action:
    - service: mqtt.publish
      data:
        topic: "homeassistant/switch/test-vm/test-vm_custom/action"
        payload: "\"C:\\Program Files\\BowPad\\BowPad.exe\""

Amadeo•2/28/24, 9:07 PM

when you configure a powershell command it'll be executed differently base of if it's "script" (ending with .ps1) or "command" (anything else) - in the "Command or Script" text box - if you then use payload it'll be added as a parameter to the "script" one

Bbarrelltitor Docs example: ``` action: - service: mqtt.publish data: top...

Amadeo•2/28/24, 9:07 PM

oh yeah, with "Custom" it should work as expected

barrelltitorOP•2/28/24, 9:08 PM

How would it execute differently though? If the script is available in the path it's just a command

barrelltitorOP•2/28/24, 9:08 PM

I can run it anywhere in my system by just doing "bt.ps1" as it's in my path

Amadeo•2/28/24, 9:09 PM

with "Custom" HASS.Agent says to system basicall "yo, here you have X, execute it", with powershell one it's appropriately passed on to powershell.exe either as a command or script

Bbarrelltitor I can run it anywhere in my system by just doing "bt.ps1" as it's in my path

Amadeo•2/28/24, 9:09 PM

hm, that would partially explain why it worked before

barrelltitorOP•2/28/24, 9:10 PM

(has no output, but it succeeded)

barrelltitorOP•2/28/24, 9:10 PM

barrelltitorOP•2/28/24, 9:18 PM

Could it have been something from a failed migration? I edited the action a few times, and now all of a sudden it works lol

barrelltitorOP•2/28/24, 9:19 PM

was actually recording to show you at the time, the video shows it not working then working again after removing "test.ps1" from the field and confirming again

To clarify: I did have it empty before, I set it to test.ps1 a few minutes ago testing it

Amadeo•2/28/24, 9:32 PM

Mind you

Amadeo•2/28/24, 9:32 PM

Bt control is integrated in HASS.Agent itself

Powershell command no longer working after update

Similar Threads

Similar Threads

Similar Threads