By manual build, do you mean using the normal unity build menu or the open-bush specific build scrip

M

mikesky•2/29/24, 9:50 PM

normal unity build window yeah

M

mikesky•2/29/24, 9:50 PM

the open brush build menu will auto configure the right plugins, you just need to select android and openxr

M

mikesky•2/29/24, 9:51 PM

but i think you need to make an android keystore for that one to work properly

J

JezzaOP•2/29/24, 9:52 PM

cool, will give that a try. no success yet with the github runners (still working though an expired payment issue)

A

AncientWorlds•2/29/24, 10:12 PM

I added a model and changed the container folder name, in an attempt to organize the order they'd show up in the library in, without realizing that the sketch would also lose my model path
Where can I add a debug statement to tell me the path the sketch is looking for the model at?

JJezza Do I need to manually add my own runners? https://github.com/jeremyselan/open-br...

M

mikeage•3/1/24, 12:22 AM

you shouldn't; we just use the default github provided runners.

One thing you will want to do is make sure you have a build run on the

main

main

branch first; because of the sizes of some of the caches (we cache the

Library/

Library/

Library/

Library/ directory, which cuts build times from between 50 minutes - 4 hours, depending on the platform, down to 6 - 25 minutes), we only save them when building from

main

main

, but we use them on any and all feature branches.

Now for the followup question... I'm not sure what the best way to do that is :-). Normally it should build with every push to master, but on the initial fork, it doesn't. Maybe do something simple like revert the last commit, push that, and then rebase to remove the revert and force push? It is, your fork, after all!

Once the initial process has been done, the CI should work rather nicely. I'm pretty proud that most people don't bother setting up local environments for all of the different platforms!

Any questions about the magic (or confusion) that is build.yml, feel free to ask. I'm in GMT+2 (so I shouldn't be online now, but such is life with an upset stomach...)

AAncientWorlds I added a model and changed the container folder name, in an attempt to organize...

A

AncientWorlds•3/1/24, 2:04 AM

Update: Got it resolved. Was a bit trickier than I expected.
Required changes to
ModelCatalog.cs
ReferencePanelModelTab.cs

A

andybak•3/1/24, 4:52 PM

Oh gosh. Just noticed you can download build artifacts before others have finished - and even if some fail. That's a big quality of life improvement. Nice one @mikeage

Aandybak Oh gosh. Just noticed you can download build artifacts before others have finish...

M

mikeage•3/2/24, 4:50 PM

You're welcome, but I didnt do anything

maybe a github change?

A

AncientWorlds•3/3/24, 12:32 PM

Is the maximum speed related to the ability to process frames, or is it just an arbitrary setting?
My current project recorded 36 minutes of footage, and moves rather slowly, even at 100 speed all the way through

M

mikeage•3/4/24, 1:07 PM

I merged a PR that renames a few secrets and moves a few others to variables. Please make sure you're in sync with the tip of

main

main

prior to attempting a CI build

M

mikesky•3/4/24, 5:06 PM

https://docs.unity3d.com/Packages/com.unity.xr.compositionlayers@0.5/manual/index.html compositor layers in OpenXR, finally

M

mikesky•3/4/24, 5:06 PM

we can get a non-stuttery load screen again!

A

AncientWorlds•3/4/24, 8:34 PM

Wouldn't be related to this by any chance would it?
I'm having trouble using command line rendering for 4k

User-visible error: Warning reading Open Brush.cfg
Detail: Could not find member 'ExportStrokeMetadata' on object of type 'ExportConfig'. Path 'Export.ExportStrokeMetadata', line 31, position 27.
UnityEngine.Debug:LogErrorFormat (string,object[])
TiltBrush.OutputWindowScript:Error (TiltBrush.InputManager/ControllerName,string,object) (at Assets/Scripts/OutputWindowScript.cs:126)
TiltBrush.OutputWindowScript:Start () (at Assets/Scripts/OutputWindowScript.cs:246)

        /// Display an error message to the user, related to an action taken
        /// by the specified controller.
        public static void Error(InputManager.ControllerName controller,
                                 string msg,
                                 System.Object detail = null)
        {
            // If our singleton instances haven't been assigned, defer the error.
            if (m_Instance == null || ControllerConsoleScript.m_Instance == null)
            {
                DeferError(controller, msg, detail);
            }
            else
            {
                Debug.LogErrorFormat("User-visible error: {0}\nDetail: {1}", msg, detail);

                // In the future, maybe use color or something instead of prepending ERROR
                string card = string.Format("ERROR: {0}", msg);
                float cardPop = 1.0f + InfoCardAnimation.s_NumCards * 0.2f;
                m_Instance.CreateInfoCardAtController(controller, card, cardPop, false);

                ControllerConsoleScript.m_Instance.AddNewLine(msg, true);
                if (detail != null)
                {
                    string detailStr = detail.ToString();
                    if (detailStr.Length > CONTROLLER_DETAIL_MAX_LENGTH)
                    {
                        detailStr = detailStr.Substring(0, CONTROLLER_DETAIL_MAX_LENGTH - 3) + " ...";
                    }
                    ControllerConsoleScript.m_Instance.AddNewLine(detailStr, false);
                }
            }
        }

        /// Display an error message to the user, related to an action taken
        /// by the specified controller.
        public static void Error(InputManager.ControllerName controller,
                                 string msg,
                                 System.Object detail = null)
        {
            // If our singleton instances haven't been assigned, defer the error.
            if (m_Instance == null || ControllerConsoleScript.m_Instance == null)
            {
                DeferError(controller, msg, detail);
            }
            else
            {
                Debug.LogErrorFormat("User-visible error: {0}\nDetail: {1}", msg, detail);

                // In the future, maybe use color or something instead of prepending ERROR
                string card = string.Format("ERROR: {0}", msg);
                float cardPop = 1.0f + InfoCardAnimation.s_NumCards * 0.2f;
                m_Instance.CreateInfoCardAtController(controller, card, cardPop, false);

                ControllerConsoleScript.m_Instance.AddNewLine(msg, true);
                if (detail != null)
                {
                    string detailStr = detail.ToString();
                    if (detailStr.Length > CONTROLLER_DETAIL_MAX_LENGTH)
                    {
                        detailStr = detailStr.Substring(0, CONTROLLER_DETAIL_MAX_LENGTH - 3) + " ...";
                    }
                    ControllerConsoleScript.m_Instance.AddNewLine(detailStr, false);
                }
            }
        }

        /// Display an error message to the user, related to an action taken
        /// by the specified controller.
        public static void Error(InputManager.ControllerName controller,
                                 string msg,
                                 System.Object detail = null)
        {
            // If our singleton instances haven't been assigned, defer the error.
            if (m_Instance == null || ControllerConsoleScript.m_Instance == null)
            {
                DeferError(controller, msg, detail);
            }
            else
            {
                Debug.LogErrorFormat("User-visible error: {0}\nDetail: {1}", msg, detail);

                // In the future, maybe use color or something instead of prepending ERROR
                string card = string.Format("ERROR: {0}", msg);
                float cardPop = 1.0f + InfoCardAnimation.s_NumCards * 0.2f;
                m_Instance.CreateInfoCardAtController(controller, card, cardPop, false);

                ControllerConsoleScript.m_Instance.AddNewLine(msg, true);
                if (detail != null)
                {
                    string detailStr = detail.ToString();
                    if (detailStr.Length > CONTROLLER_DETAIL_MAX_LENGTH)
                    {
                        detailStr = detailStr.Substring(0, CONTROLLER_DETAIL_MAX_LENGTH - 3) + " ...";
                    }
                    ControllerConsoleScript.m_Instance.AddNewLine(detailStr, false);
                }
            }
        }

        /// Display an error message to the user, related to an action taken
        /// by the specified controller.
        public static void Error(InputManager.ControllerName controller,
                                 string msg,
                                 System.Object detail = null)
        {
            // If our singleton instances haven't been assigned, defer the error.
            if (m_Instance == null || ControllerConsoleScript.m_Instance == null)
            {
                DeferError(controller, msg, detail);
            }
            else
            {
                Debug.LogErrorFormat("User-visible error: {0}\nDetail: {1}", msg, detail);

                // In the future, maybe use color or something instead of prepending ERROR
                string card = string.Format("ERROR: {0}", msg);
                float cardPop = 1.0f + InfoCardAnimation.s_NumCards * 0.2f;
                m_Instance.CreateInfoCardAtController(controller, card, cardPop, false);

                ControllerConsoleScript.m_Instance.AddNewLine(msg, true);
                if (detail != null)
                {
                    string detailStr = detail.ToString();
                    if (detailStr.Length > CONTROLLER_DETAIL_MAX_LENGTH)
                    {
                        detailStr = detailStr.Substring(0, CONTROLLER_DETAIL_MAX_LENGTH - 3) + " ...";
                    }
                    ControllerConsoleScript.m_Instance.AddNewLine(detailStr, false);
                }
            }
        }

T

the_metaverse_venus_pro•3/5/24, 3:41 PM

I just downloaded the zipped folder from here: https://github.com/icosa-foundation/open-brush Then I unzipped the project and dragged the unzipped folder into Unity and now I am getting many errors

GitHub

GitHub - icosa-foundation/open-brush: Open Brush is the open source...

Open Brush is the open source, community led evolution of Tilt Brush! Forked from https://github.com/googlevr/tilt-brush - icosa-foundation/open-brush

Tthe_metaverse_venus_pro I just downloaded the zipped folder from here: https://github.com/icosa-foundati...

A

andybak•3/5/24, 3:42 PM

You downloaded a full Unity project. You don't drag it into Unity - you open it with Unity

A

andybak•3/5/24, 3:43 PM

Add it to Unity Hub and open it from that.

Aandybak You downloaded a full Unity project. You don't drag it into Unity - you open it ...

T

the_metaverse_venus_pro•3/5/24, 3:47 PM

I understand! Thank you. I was trying to combine it with another Unity project. I guess I will open the Open Brush project in Unity first and then try and add on the other unity project. I am essentially trying to get Open Brush to work with a custom built VR controller

T

the_metaverse_venus_pro•3/5/24, 3:59 PM

I got this error

T

the_metaverse_venus_pro•3/5/24, 3:59 PM