SMM
Software Mansion / Membraneyujonglee
MP3 output is audible, but test not pass
Hi everyone. I made small changes in
membrane_mp3_lame_plugin to support other input config (the original repo only support 44100/32/1).
(patch branch: https://github.com/yujonglee/membrane_mp3_lame_plugin/commits/patch/)
After the change, I run the test, but test does not pass.
But when I play the generated output file, it is audible and feels same as ref.mp3.
(To get generated audio, I commented out https://github.com/yujonglee/membrane_mp3_lame_plugin/blob/patch/test/integration/integration_test.exs#L27 and run test)
I wrote a README on how I create new test audio file:
https://github.com/yujonglee/membrane_mp3_lame_plugin/blob/patch/README.md
Can anyone share some insight on this?M
mat_hek•72d ago
👋 that’s because this plugin uses snapshot testing. We check if the mp3 is exactly the same as the fixture that we confirmed to be audible and playable by popular players. That prevents introducing unintentional changes to the output mp3. However, if you change the encoder parameters, it’s necessary to manually verify that the output is correct and update the fixture 😉
Y
yujonglee•71d ago
@mat_hek Thank you!
Actually, I regenerated the fixture with
ffmpeg command, and ran the tests.
https://github.com/yujonglee/membrane_mp3_lame_plugin/blob/patch/README.md#test-file-generation
So output of my ffmpeg command is now new ref.mp3 . Both <generated_from_pipeline>.mp3 and ref.mp3 is audible, but they don't match.GitHub
membrane_mp3_lame_plugin/README.md at patch · yujonglee/membrane_mp...
Membrane MP3 encoder based on Lame. Contribute to yujonglee/membrane_mp3_lame_plugin development by creating an account on GitHub.
M
mat_hek•71d ago
It's unlikely that the mp3 generated with FFmpeg will be exactly the same as generated by Membrane. You should generate the output with Membrane, check if it's correct and then use it as the reference 😉
Y
yujonglee•70d ago
Didn't know that they are not same 🙂 Thank you
Want results from more Discord servers?
More PostsGrab keyframe image data from h264 stream?We are looking at some h264 coming from an RTSP stream. Membrane is doing a fine job with the HLS deUnity client?Thanks a lot to the Membrane team. The number of examples and availability of code has been incredibWebRTC stream not workingI've hit an issue trying to get an MPEGTS stream displaying in the browser via WebRTC.
All seems toError when compiling free4chatThis is probably pretty basic but I'm at square one. I get an error when I'm compiling free4chat, a Screen ShareIs there any reason why jellyfish_videoroom when is running localy share screen is not working ?
I sTesting Membrane ElementI'm trying to setup a simple test of a membrane element, but I'm stumped a bit on how to assert thatClustering and scale out behaviourContext: I've a membrane application running in an elixir cluster of 1. It receives a RTSP stream (URTSP authentication problem?Hi,
I am playing with an RTSP camera (**Tapo C210**) that is on the local network.
The path to the sExtending the jellyfish video room demo with a queueHey I am curious what a scalable way would be to add a queue in front of jellyfish rooms. I have a sDebugging bundlex/unifex errorsHello, I've been tinkering with membrane cross-compiled to Nerves (rpi4).
I've had features (e.g. m