Using collector.on('end') to edit reply? - discord.js

Penitent · 2024-03-27T20:21:01.308Z

I'm trying to create a polling bot that edits their reply once the poll has concluded, but i can't figure out how to do that, and was wondering if anyone had any advice? I'm not sure if I should figure out a way to do it through collector.on('collect') or if there is a way to do it with collector.on('end'). If the right way to do it is through collector.on('collect'), i'm not sure if i can combine a switch statement with an await 60 _ 000 to update the message when the timer has ticked down

D

d.js toolkit•3/27/24, 8:21 PM

What's your exact discord.js

npm list discord.js

npm list discord.js

and node

node -v

node -v

version?

Not a discord.js issue? Check out #other-js-ts.
Consider reading #how-to-get-help to improve your question!
Explain what exactly your issue is.
Post the full error stack trace, not just the top part!
Show your code!
Issue solved? Press the button!
```
✅
```
```
✅
```
Marked as resolved by OP

P

PenitentOP•3/27/24, 8:21 PM

collector.on('collect', i => {
            console.log('Hello from the collector');
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }
        });
        collector.on('end', i => {
            console.log(`${i} has ended`)
        })

collector.on('collect', i => {
            console.log('Hello from the collector');
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }
        });
        collector.on('end', i => {
            console.log(`${i} has ended`)
        })

collector.on('collect', i => {
            console.log('Hello from the collector');
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }
        });
        collector.on('end', i => {
            console.log(`${i} has ended`)
        })

collector.on('collect', i => {
            console.log('Hello from the collector');
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }
        });
        collector.on('end', i => {
            console.log(`${i} has ended`)
        })

P

PenitentOP•3/27/24, 8:21 PM

for reference this is my code

S

Spaxter•3/27/24, 8:24 PM

You can just set the timeout to

60000

60000 and use

collector.on('end', (i, reason) => {
    if (reason === 'time') {
        // Edit your reply here
    }
});

collector.on('end', (i, reason) => {
    if (reason === 'time') {
        // Edit your reply here
    }
});

collector.on('end', (i, reason) => {
    if (reason === 'time') {
        // Edit your reply here
    }
});

collector.on('end', (i, reason) => {
    if (reason === 'time') {
        // Edit your reply here
    }
});

P

PenitentOP•3/27/24, 8:25 PM

yuh but i tried doing i.update(0) and i.editReply() but both give me an error

P

PenitentOP•3/27/24, 8:25 PM

i shouldve mentioned that

P

PenitentOP•3/27/24, 8:25 PM

my bad

S

Spaxter•3/27/24, 8:25 PM

"an error" is pretty vague. What error did you get?

P

PenitentOP•3/27/24, 8:27 PM

neither i.update() nor i.editReply() are actual functions, and im pretty sure its cause i is an object map

S

Spaxter•3/27/24, 8:28 PM

You should edit the original interaction of the command instead, I don't believe the 'end' event callback has an interaction since the collector has ended

P

PenitentOP•3/27/24, 8:29 PM

fair point, i have this line which sends the original embed:
const response = await modalSubmission.reply({ embeds: [createPollEmbed(votes)], components: [row], fetchReply: true });
and i tried updating it with response.editReply, but that is also apparently not a valid function (i got editReply from this: https://discordjs.guide/slash-commands/response-methods.html#ephemeral-responses)

discord.js Guide

Imagine a guide... that explores the many possibilities for your discord.js bot.

P

PenitentOP•3/27/24, 8:30 PM

also if i try interaction.editreply

P

PenitentOP•3/27/24, 8:30 PM

" throw new DiscordAPIError(data, "code" in data ? data.code : data.error, status, method, url, requestData);
^

DiscordAPIError[10008]: Unknown Message"

D

duck•3/27/24, 8:30 PM

just making sure you're aware that the native polls beta launched last week https://discord.com/channels/222078108977594368/992166350640386090/1220461677364117626
the
```
end
```
end
```
end
```
end
event does emit with a
```
Collection
```
Collection
```
Collection
```
Collection
of the collected items, so it does contain the previous interactions
you'd need to pick one (
```
<Collection>.first()
```
<Collection>.first()
```
<Collection>.first()
```
<Collection>.first()
just being the first one if it doesn't matter)

P

PenitentOP•3/27/24, 8:31 PM

i did not know about native polls

i'll def take a look

P

PenitentOP•3/27/24, 8:31 PM

the collected items are interactions to buttons

P

PenitentOP•3/27/24, 8:31 PM

i really only wanna edit the message itself

P

PenitentOP•3/27/24, 8:31 PM

P

PenitentOP•3/27/24, 8:31 PM

I wanna take this message and update it with saying "the poll has ended, B has the most votes with 100% of the votes"

P

PenitentOP•3/27/24, 8:31 PM

or something like that

D

duck•3/27/24, 8:32 PM

yes, but while

i.editReply()

i.editReply()

i.editReply()

i.editReply() doesn't exist because

i

i is a

Collection

Collection

Collection

Collection,

<ButtonInteraction>.editReply()

<ButtonInteraction>.editReply()

<ButtonInteraction>.editReply()

<ButtonInteraction>.editReply() does exist

P

PenitentOP•3/27/24, 8:32 PM

ahhh okay, that makes sense, so then it would be i.first().editReply()?

D

duck•3/27/24, 8:32 PM

assuming it does collect an interaction, yes

P

PenitentOP•3/27/24, 8:33 PM

ahhh it works! however it doesnt remove the embed

P

PenitentOP•3/27/24, 8:35 PM

just leaves me like this for some reason:

D

duck•3/27/24, 8:38 PM

are you passing an empty array for

embeds

embeds

embeds

embeds?
care to share your updated code?

P

PenitentOP•3/27/24, 8:39 PM

const response = await modalSubmission.reply({ embeds: [createPollEmbed(votes)], components: [row], fetchReply: true });

        const collector = response.createMessageComponentCollector({ componentType: ComponentType.Button, time: 5_000 });

        collector.on('collect', i => {
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }

        });
        collector.on('end', i => {
            i.first().editReply({content: 'hello'})
        })

const response = await modalSubmission.reply({ embeds: [createPollEmbed(votes)], components: [row], fetchReply: true });

        const collector = response.createMessageComponentCollector({ componentType: ComponentType.Button, time: 5_000 });

        collector.on('collect', i => {
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }

        });
        collector.on('end', i => {
            i.first().editReply({content: 'hello'})
        })

const response = await modalSubmission.reply({ embeds: [createPollEmbed(votes)], components: [row], fetchReply: true });

        const collector = response.createMessageComponentCollector({ componentType: ComponentType.Button, time: 5_000 });

        collector.on('collect', i => {
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }

        });
        collector.on('end', i => {
            i.first().editReply({content: 'hello'})
        })

const response = await modalSubmission.reply({ embeds: [createPollEmbed(votes)], components: [row], fetchReply: true });

        const collector = response.createMessageComponentCollector({ componentType: ComponentType.Button, time: 5_000 });

        collector.on('collect', i => {
            if (voters.has(i.user.id)) {
                i.reply({content: `You've already voted on this poll!`, ephemeral: true});
            }
            else {
                voters.add(i.user.id);
                switch(i.customId){
                    case 'firstChoiceButton':
                        votes.firstChoice = votes.firstChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'secondChoiceButton':
                        votes.secondChoice = votes.secondChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                        break;
                    case 'thirdChoiceButton':
                        votes.thirdChoice = votes.thirdChoice += 1;
                        votes.total = votes.total += 1;
                        console.log(votes);
                        i.update({embeds: [createPollEmbed(votes)], components: [row], fetchReply: true})
                }
            }

        });
        collector.on('end', i => {
            i.first().editReply({content: 'hello'})
        })

P

PenitentOP•3/27/24, 8:39 PM

function createPollEmbed(){
            console.log(votes)
        
            const pollEmbed = new EmbedBuilder()
                .setColor(0x0099FF)
                .setTitle(pollTitle)
                .setDescription('Choose one of the following options')
                .addFields(
                    { name: '\u200B', value: `${firstChoice} - ${calculatePercentage(votes.firstChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.firstChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.firstChoice, votes.total)))}
                    ${secondChoice} - ${calculatePercentage(votes.secondChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.secondChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.secondChoice, votes.total)))}
                    ${thirdChoice} - ${calculatePercentage(votes.thirdChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.thirdChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.thirdChoice, votes.total)))}` },
                );
            return pollEmbed;
        }

function createPollEmbed(){
            console.log(votes)
        
            const pollEmbed = new EmbedBuilder()
                .setColor(0x0099FF)
                .setTitle(pollTitle)
                .setDescription('Choose one of the following options')
                .addFields(
                    { name: '\u200B', value: `${firstChoice} - ${calculatePercentage(votes.firstChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.firstChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.firstChoice, votes.total)))}
                    ${secondChoice} - ${calculatePercentage(votes.secondChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.secondChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.secondChoice, votes.total)))}
                    ${thirdChoice} - ${calculatePercentage(votes.thirdChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.thirdChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.thirdChoice, votes.total)))}` },
                );
            return pollEmbed;
        }

function createPollEmbed(){
            console.log(votes)
        
            const pollEmbed = new EmbedBuilder()
                .setColor(0x0099FF)
                .setTitle(pollTitle)
                .setDescription('Choose one of the following options')
                .addFields(
                    { name: '\u200B', value: `${firstChoice} - ${calculatePercentage(votes.firstChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.firstChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.firstChoice, votes.total)))}
                    ${secondChoice} - ${calculatePercentage(votes.secondChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.secondChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.secondChoice, votes.total)))}
                    ${thirdChoice} - ${calculatePercentage(votes.thirdChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.thirdChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.thirdChoice, votes.total)))}` },
                );
            return pollEmbed;
        }

function createPollEmbed(){
            console.log(votes)
        
            const pollEmbed = new EmbedBuilder()
                .setColor(0x0099FF)
                .setTitle(pollTitle)
                .setDescription('Choose one of the following options')
                .addFields(
                    { name: '\u200B', value: `${firstChoice} - ${calculatePercentage(votes.firstChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.firstChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.firstChoice, votes.total)))}
                    ${secondChoice} - ${calculatePercentage(votes.secondChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.secondChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.secondChoice, votes.total)))}
                    ${thirdChoice} - ${calculatePercentage(votes.thirdChoice, votes.total)}
                    ${':blue_square:'.repeat(calculateNumSquares(votes.thirdChoice, votes.total))}${'⬛'.repeat((10 - calculateNumSquares(votes.thirdChoice, votes.total)))}` },
                );
            return pollEmbed;
        }

P

PenitentOP•3/27/24, 8:39 PM

its an array of only 1 element

D

duck•3/27/24, 8:40 PM

not sure what you mean by it's an array of only 1 element
to remove all embeds from a message when editing, you should pass an empty array for

embeds

embeds

embeds

embeds
it does not edit properties you don't specify

P

PenitentOP•3/27/24, 8:40 PM

ahh sorry i misunderstood

P

PenitentOP•3/27/24, 8:41 PM

i thought you were asking if in the initial interaction i was passing an empty array for embeds and then populating

P

PenitentOP•3/27/24, 8:41 PM

sorry

P

PenitentOP•3/27/24, 8:43 PM

got it, it works now! thanks @duck