WStarting a thread since I didn't want to continue to disrupt the other meaningful conversation. So there was a typo more or less, that should be resolved. Could you possibly kick off a new build with the revised changes?
W@Kyle Gospo sorry for the poke, to be honest I have no idea if it pings folks when you make a thread like this. That said, I resolved that obvious issue in the akmods.
Kall good, ty
Kyep, kicking off now
W
Wthe ones that are failing are failing in build prep, I'll take a look
WWThat uh, doesn't feel like my stuff at all?
Kit's not, you can ignore
Kshould only apply to fsync builds
Kdid any common build?
WW
Koop
Wgit doesn't track ownership like that right? Like, if I chmod it locally, that doesn't change the file as far as git sees right? I'm guessing its not quite that?
Kit does, give it ashot
W(when you've used a tool for over a decade and had no idea how that kinda stuff worked)
Wone
chmod a+x and we're pushed again.WWait... can I just run the action in my own forked repo to not poke you every time I fix a tiny thing?
Wyes... yes I can.
WGood news is we got a lot farther! Bad news is, at least on my build, its failing and its no longer clear to me why. https://github.com/Waffleophagus/akmods/actions/runs/8543889511/job/23408689155
WWwait, since I'm running it on my fork... my key needs to be different right?
Kcorrect
Kbest to continue in your PR
Wright, I just can't kick off the builds there, was trying to remove from having to poke you every time I made a change. THAT SAID I'm starting to actually get hopeful
WThat said, whenever you get a minute, I think we... might be good? 
Woh uh... I don't think I enabled 38 images on the copr?
W
Kdid any 39s build?
W ok, well that's just odd
WOh uh, ok, I think I see what happened here.
WI think I targeted the wrong platform in my COPR... Targeted the right ones (and included 38 while I was at it)
Wok, so I saw two issues, the first was the fact that I wasn't building to x86_64, the other is
framework_laptop isn't a thing, but framework-laptop is, so I thinnkkk I solved that by trying to find all instances of the former and making them the latter? The slightly revised version of the COPR is building now.Wok, COPR built
WJust to learn a bit,
Warning: figure out the default kernel [WARNING] that's normal right?Kyep you're good
Werror: Packages not found: framework_laptop-*.fc39.x86_64 grrrr.... I don't know what is causing it to be an underscore. It should be a dash nowWthe file is definitively a dash
Wok, question, the package its looking for, where is that defined in your akmod setup? Cause I realized that the actual kmod written is named framework_laptop.c and it refers to itself as underscore in a few places. I'm wondering if I should actually default to the underscore.
WThat said I did find 1 spot and it should be good to go, but figure I'd anticipate the issue again
W@Kyle Gospo just lemme know when you get a chance to run it. Or do you think it'd make sense for me to change the signing key to something of my own, iterate on it, and then change it back for the PR so I don't poke you? Also, ideas on the above question? Again, trying to make it to where I just... give you a PR that's ready and not hassle you with every change
WUgh, its still giving and I don't know why
