Matti Airas - User Offspring (on GitHub, don) h...
User Offspring (on GitHub, don't know whether he's here) has made several code quality improvement PRs against a few SensESP-related repos. (Thanks!!) Inspired by that, I ran the
The PR does break some old code because the
clang-tidy static analysis tool against SensESP proper and fixed a ton of warnings. The result is in this PR: https://github.com/SignalK/SensESP/pull/737The PR does break some old code because the
reactesp namespace needs to be explicitly declared whenever the code is not using reactesp (which is a no-no in header files).GitHub
I ran clang-tidy against the SensESP codebase and fixed (most of) the issues. While this overall results in improved code quality and consistency, there are some breaking changes as well. In partic...