mikesky - @andybak regarding https://github.com...
@andybak regarding https://github.com/icosa-foundation/three-icosa/issues/3 were the brush shaders
icosa-sketch-assets updated, but not the ones in three-icosa?GitHub
Brush shader mismatch · Issue #3 · icosa-foundation/three-icosa
The shaders in this repository (example) don't match the ones on the hosted server (example). Fatally, the ones in this repository start with #version 300 es, which stops them compiling in thre...
13 Replies
andy said "I was going to look at that later - possibly"
oh - lol
these threads
yeah...
is there any reason they're hosted separately?
dunno. i wanted the assets repo to be fairly strictly "stuff that needs to load over the network and should be permanently hosted somewhere"
not just a whole repo that happens to also have that stuff
but it could be done differently i guess
i think i had them in a cloud bucket on gcp
i want updating them to be as simple as a git push. it's all a big chore as it is (hence why this got overlooked)
smells like submodules 😄
ugh
i guess i fixed https://github.com/icosa-foundation/icosa-sketch-assets - because it solved the actual problem i was having
at that moment in time
Also - icosa-sketch-assets contains all the textures, environment prefabs, skyboxes etc - so it's a big repo. Not sure we want three-icosa to have all that clutter when it's fairly narrowly focused.
although the gallery-viewer <> three-icosa split is a bit confusing to me tbh
so
three-icosa is the specific gltf extension implementer, as you say it's somewhat narrowly focused. it can be used by any threejs app to get support for the shaders. gallery-viewer is our own threejs app that implements it, specifically for the gallery websiteyeah - i figure some of the other stuff i'm doing in the viewer should be part of an extension - but three-icosa seemed to specifically be about shaders
i'm doing a ton of stuff now that other people might also want to do in a loader
I'm far from happy with my changes to gallery-viewer but i've repeatedly failed to persuade anyone else to work on it so I do it with simmering sullen resentment 😉
Maybe when we launch the gallery there will be more interest and more volunteers
it of course is on my very long backlog 😅 the environment stuff is calculated from an
extras field right? I reckon that falls into three-icosa territoryyeah. although i did the environment stuff early on my journey into exploring the poly scrape - i've learned a lot since then so i might need to cast an eye over how i did things back then
i know i guessed wrong about initial camera stuff. that turned out to be quite hard to get right (and i'm only getting most of them mostly right.)
Hello, if it's not much trouble would it be possible to publish the latest changes to the three-icosa package? I see that the last publish was months ago: https://www.npmjs.com/package/three-icosa?activeTab=versions
whoops, sorry I don't know why I messaged in this thread. I should've put this in the icosa dev chat. My bad.