✅ World generation optimization

Mąż Zuzanny Harmider Szczęście · 2025-01-28T13:30:49.363Z

Hey guys, i'm having issues with world generation for my game, do you guys know how i could optimize it? it takes 15s for the window to load rn

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 1:34 PM

        public Tile(MainWindow window, double x, double y, TileType type) : this(window)
        {
            X = x;
            Y = y;
            Type = type;
            List<Tile> tiles = _MainWindow.Display.Children.OfType<Tile>().ToList();
            tiles = tiles.Where(r => r.Type == Type && r.Source != null).ToList();
            if (tiles.Count>0)
            {
                Tile tile = tiles.First();
                Source=tile.Source;
            }
            else
            {
                ImageBrush brush = new ImageBrush();
                try
                {

                    brush.ImageSource = new BitmapImage(new Uri(GetImagePath(type), UriKind.RelativeOrAbsolute));
                }
                catch (Exception ex)
                {
                    Debug.WriteLine(ex.Message);
                }

                Source = brush.ImageSource;

            }
            MouseLeftButtonDown += TileClicked;
        }

        public Tile(MainWindow window, double x, double y, TileType type) : this(window)
        {
            X = x;
            Y = y;
            Type = type;
            List<Tile> tiles = _MainWindow.Display.Children.OfType<Tile>().ToList();
            tiles = tiles.Where(r => r.Type == Type && r.Source != null).ToList();
            if (tiles.Count>0)
            {
                Tile tile = tiles.First();
                Source=tile.Source;
            }
            else
            {
                ImageBrush brush = new ImageBrush();
                try
                {

                    brush.ImageSource = new BitmapImage(new Uri(GetImagePath(type), UriKind.RelativeOrAbsolute));
                }
                catch (Exception ex)
                {
                    Debug.WriteLine(ex.Message);
                }

                Source = brush.ImageSource;

            }
            MouseLeftButtonDown += TileClicked;
        }

        public Tile(MainWindow window, double x, double y, TileType type) : this(window)
        {
            X = x;
            Y = y;
            Type = type;
            List<Tile> tiles = _MainWindow.Display.Children.OfType<Tile>().ToList();
            tiles = tiles.Where(r => r.Type == Type && r.Source != null).ToList();
            if (tiles.Count>0)
            {
                Tile tile = tiles.First();
                Source=tile.Source;
            }
            else
            {
                ImageBrush brush = new ImageBrush();
                try
                {

                    brush.ImageSource = new BitmapImage(new Uri(GetImagePath(type), UriKind.RelativeOrAbsolute));
                }
                catch (Exception ex)
                {
                    Debug.WriteLine(ex.Message);
                }

                Source = brush.ImageSource;

            }
            MouseLeftButtonDown += TileClicked;
        }

        public Tile(MainWindow window, double x, double y, TileType type) : this(window)
        {
            X = x;
            Y = y;
            Type = type;
            List<Tile> tiles = _MainWindow.Display.Children.OfType<Tile>().ToList();
            tiles = tiles.Where(r => r.Type == Type && r.Source != null).ToList();
            if (tiles.Count>0)
            {
                Tile tile = tiles.First();
                Source=tile.Source;
            }
            else
            {
                ImageBrush brush = new ImageBrush();
                try
                {

                    brush.ImageSource = new BitmapImage(new Uri(GetImagePath(type), UriKind.RelativeOrAbsolute));
                }
                catch (Exception ex)
                {
                    Debug.WriteLine(ex.Message);
                }

                Source = brush.ImageSource;

            }
            MouseLeftButtonDown += TileClicked;
        }

tried to shorten the time of each individual image to load, but it changed nothing

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:04 PM

anyone? please i need help

F

FusedQyou•1/28/25, 3:08 PM

I have a really hard time understanding why half this code is the way it is

F

FusedQyou•1/28/25, 3:08 PM

Dispatchers? 2 second timers? Why the hell do these things exist in a world generator?

F

FusedQyou•1/28/25, 3:09 PM

I would expect an asynchronous method that builds the world in the background. You'd then delegate the result to the UI thread using a Dispatcher which does STRICTLY the visualization

F

FusedQyou•1/28/25, 3:09 PM

What is this anyway? Please tell me it's not Winforms?

FFusedQyou Dispatchers? 2 second timers? Why the hell do these things exist in a world gene...

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:10 PM

Dispatcher is for it to be async ig, and the timer is for tick

FFusedQyou What is this anyway? Please tell me it's not Winforms?

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:10 PM

wpf

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:11 PM

this is the game

F

FusedQyou•1/28/25, 3:11 PM

Dispatchers and timers are not async

F

FusedQyou•1/28/25, 3:11 PM

A Dispatcher just delegates stuff to the UI thread

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:11 PM

oh, ok

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:11 PM

how should i do it then

F

FusedQyou•1/28/25, 3:12 PM

Make it async, use an async Task

FFusedQyou A Dispatcher just delegates stuff to the UI thread

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:12 PM

thats why it takes so much for the window to load...

F

FusedQyou•1/28/25, 3:12 PM

Just make sure it doesn't involve UI modification because WPF doesn't like that

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:12 PM

okey, could u send me a example/tutorial to Task?

F

FusedQyou•1/28/25, 3:13 PM

You have to use Dispatcher when you want to delegate calls to the UI thread for modifying the UI after the task ran

FFusedQyou Dispatchers and timers are not async

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:13 PM

whats the async alternative to timer?

F

FusedQyou•1/28/25, 3:13 PM

There's an async timer variant

FFusedQyou You have to use Dispatcher when you want to delegate calls to the UI thread for ...

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:13 PM

dont understand

F

FusedQyou•1/28/25, 3:13 PM

You don't really need to modify the timer though

F

FusedQyou•1/28/25, 3:13 PM

Here's an explanation about async https://learn.microsoft.com/en-us/dotnet/csharp/asynchronous-programming/

Asynchronous programming - C#

An overview of the C# language support for asynchronous programming using async, await, Task, and Task

F

FusedQyou•1/28/25, 3:14 PM

You can also use a thread, which kind of works the same but is more lower level. I'd use

async Task

async Task

async Task

async Task though

FFusedQyou Here's an explanation about async https://learn.microsoft.com/en-us/dotnet/cshar...

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:21 PM

i dont understand ;-;

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:21 PM

async in

js

js

js

js for example is so much simpler

F

FusedQyou•1/28/25, 3:26 PM

It's not hard

F

FusedQyou•1/28/25, 3:26 PM

Idk what you want me to say

F

FusedQyou•1/28/25, 3:27 PM

Even in javascript you have to explicitly define an async function and await it

F

FusedQyou•1/28/25, 3:27 PM

That's also the case here, but you can work with a return type called

Task

Task

Task

Task which basically defines the internal workings on asynchronous programming

F

FusedQyou•1/28/25, 3:27 PM

That's nothing you have to worry about, you just have to understand that

Task

Task

Task

Task means asychronous. This means you can switch between asynchronous and synchronous in C#

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:31 PM

like i get the await part, but what if i just want to make it not wait to generate the world?

F

FusedQyou•1/28/25, 3:32 PM

Then call the method but don't await it

F

FusedQyou•1/28/25, 3:32 PM

Note the method executed regardless if you wait for it

F

FusedQyou•1/28/25, 3:33 PM

A good idea is to wrap it in

Task.Run

Task.Run

Task.Run

Task.Run, due to the way asynchronous works with threads

F

FusedQyou•1/28/25, 3:33 PM

It doesn't always run asynchronous because it efficiently determines if it has to

F

FusedQyou•1/28/25, 3:33 PM

Task.Run

Task.Run

Task.Run

Task.Run ensures it guarantees that it's run in the background

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:35 PM

public MainWindow()
{
var generate = GenerateWorld()
}

private async Task GenerateWorld()
{
  //code here
}

public MainWindow()
{
var generate = GenerateWorld()
}

private async Task GenerateWorld()
{
  //code here
}

public MainWindow()
{
var generate = GenerateWorld()
}

private async Task GenerateWorld()
{
  //code here
}

public MainWindow()
{
var generate = GenerateWorld()
}

private async Task GenerateWorld()
{
  //code here
}

like this?

F

FusedQyou•1/28/25, 3:35 PM

Just

GenerateWorld()

GenerateWorld()

GenerateWorld()

GenerateWorld(). You don't need the return type

F

FusedQyou•1/28/25, 3:35 PM

But it does absolutely nothing because

GenerateWorld

GenerateWorld

GenerateWorld

GenerateWorld is not asynchronous

F

FusedQyou•1/28/25, 3:36 PM

You have to understand you can't just wrap this in an asynchronous method and get an improvement. Your code is not set up in a way where it will work properly for it

F

FusedQyou•1/28/25, 3:36 PM

A big ass Dispatcher method prevents it from reaching half the code because it's all moved to the UI thread

F

FusedQyou•1/28/25, 3:37 PM

You have to write code that generates the world asynchronously in the background in full, and when it's done it has to tell the UI to update

F

FusedQyou•1/28/25, 3:37 PM

Alternatively, even better, is to generate parts and move each resulting part to the UI thread for it to be stored and rendered

F

FusedQyou•1/28/25, 3:37 PM

I can't/won't help you with it because I literally can't wrap my head around half this code and what you try to accomplish

F

FusedQyou•1/28/25, 3:38 PM

You should really look into asynchronous programming tho

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:38 PM

ok, so like push all the tiles to a list and move the list to a dispatcher?

M

Mąż Zuzanny Harmider SzczęścieOP•1/28/25, 3:46 PM

@Foosed am i doing it right?:

private async void GenerateWorld()
{
  List<Tile> tiles = new List<Tile>();
  for(int i=0;i<WorldHeight;i++)
  {
    for(int j=0;j<WorldWidth;j++)
    {
      //populate list
      tiles.Add(new Tile(i,j))
    }
  }
  await Dispatcher.InvokeAsync(()=>{
    foreach(Tile tile in tiles)Display.Children.Add(tile)
  })
}

private async void GenerateWorld()
{
  List<Tile> tiles = new List<Tile>();
  for(int i=0;i<WorldHeight;i++)
  {
    for(int j=0;j<WorldWidth;j++)
    {
      //populate list
      tiles.Add(new Tile(i,j))
    }
  }
  await Dispatcher.InvokeAsync(()=>{
    foreach(Tile tile in tiles)Display.Children.Add(tile)
  })
}

private async void GenerateWorld()
{
  List<Tile> tiles = new List<Tile>();
  for(int i=0;i<WorldHeight;i++)
  {
    for(int j=0;j<WorldWidth;j++)
    {
      //populate list
      tiles.Add(new Tile(i,j))
    }
  }
  await Dispatcher.InvokeAsync(()=>{
    foreach(Tile tile in tiles)Display.Children.Add(tile)
  })
}

private async void GenerateWorld()
{
  List<Tile> tiles = new List<Tile>();
  for(int i=0;i<WorldHeight;i++)
  {
    for(int j=0;j<WorldWidth;j++)
    {
      //populate list
      tiles.Add(new Tile(i,j))
    }
  }
  await Dispatcher.InvokeAsync(()=>{
    foreach(Tile tile in tiles)Display.Children.Add(tile)
  })
}

F

FusedQyou•1/28/25, 3:48 PM

No, you should really learn asynchronous programming using a more basic example

F

FusedQyou•1/28/25, 3:49 PM

But maybe take a step back. Figure out what specifically takes an ass load of time to happen in your code. Maybe it's simpler to fix when it comes to speeding things up

✅ World generation optimization

Similar Threads

Similar Threads

Similar Threads