C#•9mo ago

.NET Api Setup

Hello all,
I just need advice in the setup of my .net project.

I was making it using the typical Unit of work (Repository) architecture where you have a unit of work & services that call unit of work which has a bunch of classes that are repositories.

Anyway, a week ago, someone here advised that because i am using EntityFramework, Unit of work is a bad practice, or not recommended.

So I decided to get rid of unit of work & services. And inject the IRepository class in my apis.
Program.cs:

builder.Services.AddTransient<IUserRepository, UserRepository>();

builder.Services.AddTransient<IUserRepository, UserRepository>();

And this is the repository, i am not declaring dbcontext, it's injected as well

    public class UserRepository(IHttpContextAccessor httpContextAccessor, OnlineShopContext myContext) : Repository<User>(httpContextAccessor, myContext), IUserRepository

    public class UserRepository(IHttpContextAccessor httpContextAccessor, OnlineShopContext myContext) : Repository<User>(httpContextAccessor, myContext), IUserRepository

user controller:

    public class UserController(
        IUserRepository userRepository,
        IHttpContextAccessor httpContextAccessor,
        IConfiguration configuration) : Helper(httpContextAccessor, configuration)

    public class UserController(
        IUserRepository userRepository,
        IHttpContextAccessor httpContextAccessor,
        IConfiguration configuration) : Helper(httpContextAccessor, configuration)

This works fine but
Question is, in unit of work, i had to dispose the context

do i need to do that here

Angius•4/12/25, 7:13 PM

The DI container handles the lifetime of injected services automatically

BordinOP•4/12/25, 7:24 PM

UserRepository.cs:

    public class UserRepository(IHttpContextAccessor httpContextAccessor, OnlineShopContext myContext) : Repository<User>(httpContextAccessor, myContext), IUserRepository
    {
        public async Task<User?>  GetUserById(int id)
        {
            return await myContext.Users.Where(u => u.Id == id).FirstOrDefaultAsync() ;
        }

        public async Task<User?> GetUserByEmail(string email)
        {
            try
            {
                return await myContext.Users.Where(u => u.Email == email).FirstOrDefaultAsync();

            }
            catch (Exception ex)
            {
                Console.WriteLine(ex.Message);
                return null;
            }
        }
    }

    public class UserRepository(IHttpContextAccessor httpContextAccessor, OnlineShopContext myContext) : Repository<User>(httpContextAccessor, myContext), IUserRepository
    {
        public async Task<User?>  GetUserById(int id)
        {
            return await myContext.Users.Where(u => u.Id == id).FirstOrDefaultAsync() ;
        }

        public async Task<User?> GetUserByEmail(string email)
        {
            try
            {
                return await myContext.Users.Where(u => u.Email == email).FirstOrDefaultAsync();

            }
            catch (Exception ex)
            {
                Console.WriteLine(ex.Message);
                return null;
            }
        }
    }

UserController.cs:

[Route("api/[controller]")]
[ApiController]
public class UserController(
    IUserRepository userRepository,
    IHttpContextAccessor httpContextAccessor,
    IConfiguration configuration) : Helper(httpContextAccessor, configuration)
{
    [HttpPost("Signup")]
    public async Task<ActionResult> Signup(Signup loginResource)
    {
      some stuff
    }
    [HttpPost("SignIn")]
``public async Task<ActionResult> Signup(LoginResource loginResource){
   var user = await userRepository.GetUserByEmail(loginResource.Email!);
      some other stuff
    }
}

[Route("api/[controller]")]
[ApiController]
public class UserController(
    IUserRepository userRepository,
    IHttpContextAccessor httpContextAccessor,
    IConfiguration configuration) : Helper(httpContextAccessor, configuration)
{
    [HttpPost("Signup")]
    public async Task<ActionResult> Signup(Signup loginResource)
    {
      some stuff
    }
    [HttpPost("SignIn")]
``public async Task<ActionResult> Signup(LoginResource loginResource){
   var user = await userRepository.GetUserByEmail(loginResource.Email!);
      some other stuff
    }
}

TTeBeCo > Anyway, a week ago, someone here advised that because i am using EntityFramewo...

BordinOP•4/12/25, 7:26 PM

public async Task UpdateAsync(TEntity entity)
{
    Context.Set<TEntity>().Update(entity);
    await Context.SaveChangesAsync();
}

public async Task UpdateAsync(TEntity entity)
{
    Context.Set<TEntity>().Update(entity);
    await Context.SaveChangesAsync();
}

i should not use stuff like this?

TTeBeCo * `IHttpContextAccessor httpContextAccessor` in a Controller is trully abnormal...

BordinOP•4/12/25, 7:27 PM

what do you mean I already have Context

BordinOP•4/12/25, 7:30 PM

I am passing it to Helper which gets me the UserId claim of the token

 public Helper(IHttpContextAccessor httpContextAccessor)
 {
     try
     {
         var tokenForUser = httpContextAccessor.HttpContext!.User;
         IpAddress = httpContextAccessor.HttpContext.Connection.RemoteIpAddress!.ToString();
         if (tokenForUser.Identity?.IsAuthenticated == false)
         {
             return;
         }
         UserId = Convert.ToInt32(tokenForUser.Claims.FirstOrDefault(c => c.Type == "UserId")!.Value);
     }
     catch (Exception)
     {
         // ignored
     }
 }

 public Helper(IHttpContextAccessor httpContextAccessor)
 {
     try
     {
         var tokenForUser = httpContextAccessor.HttpContext!.User;
         IpAddress = httpContextAccessor.HttpContext.Connection.RemoteIpAddress!.ToString();
         if (tokenForUser.Identity?.IsAuthenticated == false)
         {
             return;
         }
         UserId = Convert.ToInt32(tokenForUser.Claims.FirstOrDefault(c => c.Type == "UserId")!.Value);
     }
     catch (Exception)
     {
         // ignored
     }
 }

BordinOP•4/12/25, 7:30 PM

also does other stuff

Angius•4/12/25, 7:30 PM

That's where extension methods are useful

Angius•4/12/25, 7:30 PM

User

User

is already in the controller too, btw

BordinOP•4/12/25, 7:32 PM

yeah exactly

BordinOP•4/12/25, 7:32 PM

yeah

BordinOP•4/12/25, 7:33 PM

Yeah

BordinOP•4/12/25, 7:33 PM

huh

BordinOP•4/12/25, 7:33 PM

hang on leme tr

BordinOP•4/12/25, 7:33 PM

holy shit

BordinOP•4/12/25, 7:34 PM

I am mind blown rn

BordinOP•4/12/25, 7:34 PM

i have no idea

BordinOP•4/12/25, 7:35 PM

yeah

BordinOP•4/12/25, 7:35 PM

it checks automatically

BordinOP•4/12/25, 7:35 PM

yeah