Congratulations, you've found a 🐞 -
Congratulations, you've found a 🐞 - there is a line missing from the C++ source code that would return a or when the install succeeded or not...!
true false depending on whether9 Replies
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
It doesn't return a
true on success - I'm just writting a fix. I'm supplimenting that with making uninstalPackage(...) also return a true/nil on success/failure although, unlike the install case there will not be any additional error message as a second return value at this time.GitHub
Fix: make installPackage(...) return the boolean it is supposed to ...
Brief overview of PR changes/additions
Put in the code needed for this Lua API function to return true on success. Also put in code that ensures that the related uninstallPackage(...) also returns ...
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Above PR merged - so will be in tonight's PTB.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
That error message could, perhaps be improved to say what the
'' (presumably the "default") location is. As for "overloading" the install/uninstall I suspect that is entirely possible - I haven't really had a hand in the "background" file saving process but I can well believe that it could be possible to try and do too much at once!Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
I'm puzzled by the lack of an error message -
display(installPackage(...)) should be reporting what the problem was...
Oh 💩 someone has overridden the C++ core API function with something in the bundled ./src/mudlet-lua/lua/Other.lua file - and the effects of that are not something I fully grok...
:neko_facepalm: