HGL
eastern-cyan
Another "Not enough disk space" bug on v2.17.2
I'm on Windows 11 and I have Heroic installed through Scoop.
After updating to 2.17.2, I can only force install games as it falsely detects my disk size telling me that I don't have enough space even though I have. It happens in all games, both on Epic and GOG.
It also happened after a computer restart. I have only one disk with no custom partitions.
Also, I don't have Powertoys or custom Powershell stuff, which caused similar issues for other people.
At this point, I'm 99.99% sure, it's a Heroic issue and I'm willing to patch it if I can find what causes it.
Does anyone has similar issues from this update? Thanks.
(I also had issues posting this, I have no idea if it is on me.)
12 Replies
(I also had issues posting this, I have no idea if it is on me.)Seems like Discord issue:
Investigating - We are investigating an issue with attachments and embeds not being rendered in the app.- https://discordstatus.com/ Heroic uses PowerShell to query for free disk space. If something goes wrong with that, it reports 0/0 as you saw Try opening a command prompt and running the following command:
eastern-cyanOP•3mo ago
This line reports correct disk size on my machine
Thanks for letting me know
Could you send in the full output of that command? Invalid values for other drives might throw off the validation here
eastern-cyanOP•3mo ago
As I said, I only have one drive but here it is anyways:
I just also tried clearing the cache and resetting heroic from the advanced settings menu and exited/restarted it from the tray icon afterwards
Sorry, missed that
To confirm, are there no
[]
around the object? In that case, I see what has gone wrong here. We assume that command always returns an array of objects, but it seems PS flattens it to just be the one object in case there's only oneeastern-cyanOP•3mo ago
Yeah there are no [] around that object
I know how to fix it, I'm going to make a PR if you don't mind
Oops, sorry, already made one now: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/4658
Would you have made the same changes?
eastern-cyanOP•3mo ago
Yes but I think there are similar powershell calls in other places
Maybe ensure this is handled in the same way to prevent future bugs
Thank you for your help btw.
A generic
Get-CimInstance
wrapper would be neat, yeah. I don't know how easy it is to make a type-safe function accepting a Zod schema though, IIRC there's some complications thereeastern-cyanOP•3mo ago
Still I could try to make one
I'm looking for an oportunity to contribute to this project for a while now tbh. I really like it, mainly because I hate the official epic and gog launchers
When I can expect a new version containing this fix to be shipped?
Sure, feel free to do so if you want to!
We don't have a fixed release schedule, releases just happen whenever there's "enough" changes (with no concrete definition of "enough")
You can use the version auto-built from that PR in the meantime if you want to (or, y'know, just ignore what Heroic says & install anyways)
eastern-cyanOP•3mo ago
I installed it with force anyways already