SK
Signal K•4w ago
Karl-Erik Gustafsson

Karl-Erik Gustafsson - @Scott Bender Any idea w...

@Scott Bender Any idea why docker build from master fails to start? 
node:internal/modules/cjs/loader:1404
  throw err;
  ^
Error: Cannot find module '@canboat/canboatjs'
Require stack:
- /usr/lib/node_modules/signalk-server/node_modules/@signalk/n2k-signalk/dist/n2kMapper.js
- /usr/lib/node_modules/signalk-server/dist/interfaces/playground.js
- /usr/lib/node_modules/signalk-server/dist/interfaces/index.js
- /usr/lib/node_modules/signalk-server/dist/serverroutes.js
- /usr/lib/node_modules/signalk-server/dist/index.js
- /usr/lib/node_modules/signalk-server/bin/signalk-server
node:internal/modules/cjs/loader:1404
  throw err;
  ^
Error: Cannot find module '@canboat/canboatjs'
Require stack:
- /usr/lib/node_modules/signalk-server/node_modules/@signalk/n2k-signalk/dist/n2kMapper.js
- /usr/lib/node_modules/signalk-server/dist/interfaces/playground.js
- /usr/lib/node_modules/signalk-server/dist/interfaces/index.js
- /usr/lib/node_modules/signalk-server/dist/serverroutes.js
- /usr/lib/node_modules/signalk-server/dist/index.js
- /usr/lib/node_modules/signalk-server/bin/signalk-server
11 Replies
Scott Bender
Scott Bender•4w ago
Looks like canboatjs is failing to install for some reason… Just tested with master, and things are fine. Not sure why it's not working in docker. @Teppo Kurki ?
Karl-Erik Gustafsson
Karl-Erik GustafssonOP•4w ago
Recently build docker missing canboatjs, but older has the folder (Jul-9). Cant understand. New 
node@intel-linux:/usr/lib/node_modules/signalk-server/node_modules/@canboat$ ls -la
total 24
drwxr-xr-x   3 root root  4096 Jul 30 10:35 .
drwxr-xr-x 387 root root 16384 Jul 30 10:35 ..
drwxr-xr-x   3 root root  4096 Jul 30 10:35 ts-pgns
node@intel-linux:/usr/lib/node_modules/signalk-server/node_modules/@canboat$ ls -la
total 24
drwxr-xr-x   3 root root  4096 Jul 30 10:35 .
drwxr-xr-x 387 root root 16384 Jul 30 10:35 ..
drwxr-xr-x   3 root root  4096 Jul 30 10:35 ts-pgns
Old 
node@xavier:/usr/lib/node_modules/signalk-server/node_modules/@canboat$ ls -la
total 32
drwxr-xr-x   4 root root  4096 Jul  9 13:34 .
drwxr-xr-x 494 root root 20480 Jul  9 13:34 ..
drwxr-xr-x   5 root root  4096 Jul  9 13:34 canboatjs
drwxr-xr-x   3 root root  4096 Jul  9 13:34 ts-pgns
node@xavier:/usr/lib/node_modules/signalk-server/node_modules/@canboat$ ls -la
total 32
drwxr-xr-x   4 root root  4096 Jul  9 13:34 .
drwxr-xr-x 494 root root 20480 Jul  9 13:34 ..
drwxr-xr-x   5 root root  4096 Jul  9 13:34 canboatjs
drwxr-xr-x   3 root root  4096 Jul  9 13:34 ts-pgns
@signalk/streams has canboat installed in both cases 
node@intel-linux:/usr/lib/node_modules/signalk-server/node_modules/@signalk/streams/node_modules$ ls -la \@canboat/
total 24
drwxr-xr-x   4 root root  4096 Jul 30 10:35 .
drwxr-xr-x 210 root root 12288 Jul 30 10:35 ..
drwxr-xr-x   4 root root  4096 Jul 30 10:35 canboatjs
drwxr-xr-x   3 root root  4096 Jul 30 10:35 ts-pgns


node@xavier:/usr/lib/node_modules/signalk-server/node_modules/@signalk/streams/node_modules$ ls -la \@canboat/
total 16
drwxr-xr-x   4 root root 4096 Jul  9 13:34 .
drwxr-xr-x 199 root root 4096 Jul  9 13:34 ..
drwxr-xr-x   4 root root 4096 Jul  9 13:34 canboatjs
drwxr-xr-x   3 root root 4096 Jul  9 13:34 ts-pgns
node@intel-linux:/usr/lib/node_modules/signalk-server/node_modules/@signalk/streams/node_modules$ ls -la \@canboat/
total 24
drwxr-xr-x   4 root root  4096 Jul 30 10:35 .
drwxr-xr-x 210 root root 12288 Jul 30 10:35 ..
drwxr-xr-x   4 root root  4096 Jul 30 10:35 canboatjs
drwxr-xr-x   3 root root  4096 Jul 30 10:35 ts-pgns


node@xavier:/usr/lib/node_modules/signalk-server/node_modules/@signalk/streams/node_modules$ ls -la \@canboat/
total 16
drwxr-xr-x   4 root root 4096 Jul  9 13:34 .
drwxr-xr-x 199 root root 4096 Jul  9 13:34 ..
drwxr-xr-x   4 root root 4096 Jul  9 13:34 canboatjs
drwxr-xr-x   3 root root 4096 Jul  9 13:34 ts-pgns
Installing @canboat/canboatjs in /usr/lib/node_modules/signalk-server/ add it and then SK can be started. Can see anything that have changed?!? Have these sub-folders had own node_modules folders earlier? Now there are at least two locations where e.g. canboatjs and ts-pgns are installed. Haven't check if there other multiple installation for other packages too.
Scott Bender
Scott Bender•4w ago
I don't understand why this only happens in docker... or maybe we just need a new docker build there's a build happening now I am going to release a new beta noew also...
Teppo Kurki
Teppo Kurki•4w ago
docker build off master does a bit of black magic, shuffling dependencies, so this may be fallout from that i am a bit bandwidth limited at the moment, but this may be related to the fact that n2k-signalk used to depend on canboatjs, but no longer does 
% docker run -it --rm --entrypoint bash signalk/signalk-server:v2.13.4 -c "npm -g ls @canboat/canboatjs" 
/usr/lib
`-- signalk-server@2.13.4
  +-- @signalk/n2k-signalk@3.3.0
  | `-- @canboat/canboatjs@2.10.0
  `-- @signalk/streams@4.4.1
    `-- @canboat/canboatjs@2.10.0 deduped
% docker run -it --rm --entrypoint bash signalk/signalk-server:v2.13.4 -c "npm -g ls @canboat/canboatjs" 
/usr/lib
`-- signalk-server@2.13.4
  +-- @signalk/n2k-signalk@3.3.0
  | `-- @canboat/canboatjs@2.10.0
  `-- @signalk/streams@4.4.1
    `-- @canboat/canboatjs@2.10.0 deduped
% docker run -it --rm --entrypoint bash signalk/signalk-server:master -c "npm -g ls @canboat/canboatjs"
/usr/lib
`-- signalk-server@2.15.0-beta.6
  `-- @signalk/streams@5.0.4
    `-- @canboat/canboatjs@3.8.0
% docker run -it --rm --entrypoint bash signalk/signalk-server:master -c "npm -g ls @canboat/canboatjs"
/usr/lib
`-- signalk-server@2.15.0-beta.6
  `-- @signalk/streams@5.0.4
    `-- @canboat/canboatjs@3.8.0
in my local workspace: 
% npm ls @canboat/canboatjs
signalk-server@2.15.0-beta.6 /Users/tjk/git-workspace/signalk/server
└─┬ @signalk/streams@5.0.4 -> ./packages/streams
  └── @canboat/canboatjs@3.8.0
% find . -name canboatjs
./node_modules/@canboat/canboatjs
% npm ls @canboat/canboatjs
signalk-server@2.15.0-beta.6 /Users/tjk/git-workspace/signalk/server
└─┬ @signalk/streams@5.0.4 -> ./packages/streams
  └── @canboat/canboatjs@3.8.0
% find . -name canboatjs
./node_modules/@canboat/canboatjs
so while canboatjs is being pulled in my streams it is installed under workspace root's node_modules, where the server code can find it npm pack & install from the tar file also places canboatjs at ./node_modules/@canboat/canboatjs
Teppo Kurki
Teppo Kurki•4w ago
No description
Teppo Kurki
Teppo Kurki•4w ago
tried adding an ESLint rule for catching implicit deps https://github.com/SignalK/signalk-server/pull/2049 (no fixes yet, just the eslint rule) i think if server depends on @canboat/canboatjs we should add it as a dependency, i believe that should take care of this particular quirk
GitHub
chore: add eslint rule for implicit dependencies by tkurki · Pull ...
npm hoists transitive dependencies to the top level node_modules, from where they are easy to inadvertedly use. Also we may accidentally remove dependencies that are actually used via this implicit...
Teppo Kurki
Teppo Kurki•4w ago
see https://github.com/SignalK/signalk-server/actions/runs/16631539313/job/47061929188?pr=2049
GitHub
chore: add eslint rule for implicit dependencies · SignalK/signalk...
An implementation of a Signal K central server for boats. - chore: add eslint rule for implicit dependencies · SignalK/signalk-server@fb90ce7
Teppo Kurki
Teppo Kurki•4w ago
demo.signalk.org is now running 2.15.0-beta.6 so clearly the problem is related to master vs release build differences
Karl-Erik Gustafsson
Karl-Erik GustafssonOP•4w ago
It seems that SK master docker build is working fine. Also tested that beta.6 and did not see any issues. With my own docker build development environment, where I clone Signal K repo and do same build steps + tagging stuff, it fails with @canboat(canboatjs missing. Tagging step just rip needed info from cloned SK repo to get same tags to build. I added npm i --save @canboat/canboatjs before building modules, here https://github.com/SignalK/signalk-server/blob/master/.github/workflows/build-docker.yml#L27 and then all fine again. Timing when issue appeared and this change is a match. https://github.com/SignalK/n2k-signalk/commit/858dda02c94c8672442a2cb8b85a41774666057c As the server seems to need @canboat/canboatjs, then can it be added?
Scott Bender
Scott Bender•4w ago
Oh! Shoot! Well I screwed that up. I should not have removed that dependency. Will add back and do a release… ok, that's done. n2k-signalk 4.2.3 published
Karl-Erik Gustafsson
Karl-Erik GustafssonOP•4w ago
And all fine again 👍

Did you find this page helpful?