Karl-Erik Gustafsson - @Teppo Kurki SK v2.17.0 ...
@Teppo Kurki SK v2.17.0 is reporting issue with
SerialStream.start
17 Replies
thanks. too quickly from merge to publish..
Hello. I don’t know if it’s related, but I also have a connection error in 2.17, with CAN interface :
TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Object
at _write (node:internal/streams/writable:482:13)
at Writable.write (node:internal/streams/writable:510:10)
at CanboatJs.ondata (node:internal/streams/readable:1009:22)
at CanboatJs.emit (node:events:519:28)
at addChunk (node:internal/streams/readable:561:12)
at readableAddChunkPushObjectMode (node:internal/streams/readable:538:3)
at Readable.push (node:internal/streams/readable:393:5)
at CanboatJs._transform (/usr/lib/node_modules/signalk-server/node_modules/@signalk/streams/canboatjs.js:62:12)
at Transform._write (node:internal/streams/transform:171:8)
at writeOrBuffer (node:internal/streams/writable:572:12)
at _write (node:internal/streams/writable:501:10)
at Writable.write (node:internal/streams/writable:510:10)
at Log.ondata (node:internal/streams/readable:1009:22)
at Log.emit (node:events:519:28)
at addChunk (node:internal/streams/readable:561:12)
at readableAddChunkPushObjectMode (node:internal/streams/readable:538:3)
at Readable.push (node:internal/streams/readable:393:5)
at Log._transform (/usr/lib/node_modules/signalk-server/node_modules/@signalk/streams/log.js:46:8)
at Transform._write (node:internal/streams/transform:171:8)
at writeOrBuffer (node:internal/streams/writable:572:12)
at _write (node:internal/streams/writable:501:10)
at Writable.write (node:internal/streams/writable:510:10) {
code: 'ERR_INVALID_ARG_TYPE'
}
seems i've screwed up and need to deprecate 2.17 and take the time to fix things
server v2.17.2 is building, with @signalk/streams reverted back to 5.0.x that should fix both serialport and canboatjs errors
GitHub
2.17.2 · SignalK/signalk-server@d641a75
An implementation of a Signal K central server for boats. - 2.17.2 · SignalK/signalk-server@d641a75
published. sorry about that
2.17.2 installed, and all is working fine again. Thank you !
Something is now blocking dev docker build to run correctly.
🤔?
@Scott Bender was your n2k problem the same as above or something else?
Something else
Wait. Same as @MacJL
And the problem did not go away when I reverted to 2.16
And I ran out of time. I will be on it first thing in the morning….
Streams needs to go back a notch, so may depend on how you reverted
Workaround for 2.17.2 dev docker.
https://github.com/SignalK/signalk-server/blob/master/docker/Dockerfile#L26
@Teppo Kurki reason found https://github.com/SignalK/signalk-server/blob/master/package.json#L79
That clashes with what’s in npm workspace? Need to fix streams for good and move on..
Move failed as there was 5.0.6 (5.0.x).
@Teppo Kurki master is still broken, right?
Do you need help fixing it?
I am otherwise occupied until the weekend, so sure if you have the time, but can also get to it in a while
If
@signalk/streams in root package.json is set 5.1.1, then dev docker build will work again.fixes for the actual problems in streams:
- https://github.com/SignalK/signalk-server/pull/2120
- https://github.com/SignalK/signalk-server/pull/2119
GitHub
fix: standard input events by tkurki · Pull Request #2120 · Signa...
Fix for standard input events added in #2113.
GitHub
Fix: standard serialport toStdout events by tkurki · Pull Request ...
Re-enable the serialport toStdout events added in
#2113 published in https://github.com/SignalK/signalk-server/releases/tag/v2.17.0