How do I hide my (old) JavaScript from "View Page Source"?

I am passing info from PHP to local storage via one page, by basically writing JavaScript in PHP

echo '
<script>
    localStorage.clear();
    localStorage.setItem("userPhotos", JSON.stringify(' . $photos . '));
</script>';

echo '
<script>
    localStorage.clear();
    localStorage.setItem("userPhotos", JSON.stringify(' . $photos . '));
</script>';

THEN when loading the second page, the original JavaScript is still visible when you "View Page Source" How do I make this disappear? It's not because it's sensitive data, it just looks untidy when there is a lot, and that messes with my OCD lol

44 Replies

Jochem•2w ago

you can delete elements from the DOM, and that should include script elements, using .removeChild()

BlackwolfOP•2w ago

I need the data in the DOM, just not the JS I would've thought loading a new page would overwrite the first

Jochem•2w ago

then I'm not sure what you're asking loading a new page does completely clear and rebuild the DOM from scratch based on the newly sent data

BlackwolfOP•2w ago

but it's retaining the JS from the previous page

Jochem•2w ago

then it's not loading a new page how are you loading this page?

BlackwolfOP•2w ago

using MVC, showing the first page, followed by the second

Jochem•2w ago

is it a POST or GET request?

BlackwolfOP•2w ago

neither

Jochem•2w ago

so what are you using to show the new page then? MVC isn't a browser mechanism

BlackwolfOP•2w ago

i'm literally loading 2 seperate php pages one after the other

Jochem•2w ago

how though

BlackwolfOP•2w ago

intially i had the Controller load the JS, which kept it on the page, so thought adding it to its own page would rectify this

Jochem•2w ago

like... with fetch? setting window.location? someone clicking a link?

BlackwolfOP•2w ago

just clicking a href link, which redirects to the controller, which then loads the relevant page

Jochem•2w ago

the controller is in PHP?

BlackwolfOP•2w ago

yea

Jochem•2w ago

then the controller must be sending the original javascript along as well, cause a page load from clicking an <a href="page2"> link will fully clear the DOM and replace it with a new DOM

BlackwolfOP•2w ago

page 2 doesn't have it's own link page 1 is like a "pre" page, just to send data to localstorage

Jochem•2w ago

so how does the browser go from page1 to page2?

BlackwolfOP•2w ago

the controller loads page1, then immediately loads page2

Jochem•2w ago

so the one request from the browser loads both pages in a single request

BlackwolfOP•2w ago

essentially

Jochem•2w ago

okay, so that's not a new DOM then

BlackwolfOP•2w ago

no, but it is a new page on the browser

Jochem•2w ago

not if it's sent in the same request cause the browser doesn't give a fuck about the controller, it will load whatever is sent to it from one request as a single page

BlackwolfOP•2w ago

so how do i clear the JS from the first page before loading the second?

Jochem•2w ago

delete it with removeChild or if you want, load page1 in one request, and after the JS there has run, have it redirect the browser to page2 with window.location but also? It's entirely pointless to remove that JS. No one will look at your source code

BlackwolfOP•2w ago

i do, and i hate it looking untidy. you should see how meticulously organised it all is lol i'll look into removeChild - thank you sir 🙂

Jochem•2w ago

it does honestly sound a bit of a cursed way to load data though just hardcoding it into a script tag? if you have to load data, generally you'd set up an API endpoint, then load the data with a fetch request

BlackwolfOP•2w ago

i just need session data putting into JS all my data is accessed via php and kept secure only snippets get moved to JS in fact only this photo editting thing has data in JS

Jochem•2w ago

alright... well, just keep in mind that any complications you add to your site is more cross section for bugs to appear in. If it's unnecessary except for -_-*code aesthetics*-_-, it's not going through any professional pull request

BlackwolfOP•2w ago

i know, it's just my OCD, when there are 20 images and all associated data, it looks really untidy

Jochem•2w ago

that can also be an indication that your chosen approach isn't the most suitable

BlackwolfOP•2w ago

is there another way to add session data to localstorage? gtg, gone midnight and i'm up at 6am - will look back tomorrow, thanks for your input

Jochem•2w ago

^ 20 images isn't session data, that's just data

13eck•2w ago

Why are you trying to load 20 images via session data? Why not use an img tag? Or an API call? This feels like an X/Y problem going on here…

BlackwolfOP•2w ago

the images are all on the same account, stored in one variable (serialised). essentially $account['photos'] is an array of photos and tags / flags however, i have taken your advice and decided to leave the info in the "View Page Source", and just moved it all to the bottom out of the way 😄

Jochem•2w ago

I would argue that that's not the right way to store 20 photos one or two, maybe, but once you hit that kind of amount it's time to pull out the image table and use a foreign key back to the user table

13eck•2w ago

But again, why? Why not just use an image tag? What makes your images so special they need special handling?

Ray•2w ago

I think they are using image tags to actually display the images; it sounds like they're using the browser's local storage as a database, which, uh. Yeah i would also argue that's the wrong way to store that.

Jochem•2w ago

I think Beck is suggesting they just use php to output the image tags rather than using Javascript after the page loads

Ray•2w ago

Oh that makes more sense, and yeah i agree

13eck•2w ago

Yeah, this. If you’re using PHP then use PHP

Jochem•2w ago

agreed

Gaming

Programming

How do I hide my (old) JavaScript from "View Page Source"?

Did you find this page helpful?