Ray Kholodovsky - https://docs.tscircuit.com/gu...
https://docs.tscircuit.com/guides/importing-modules-and-chips/importing-from-jlcpcb
docs do not say that
I have to give it a name="" prop
<A_74HC05D_118 name ="ray"/> fixed itImporting from JLCPCB | tscircuit docs
JLCPCB has a massive component catalog of 3d models and footprints.
12 Replies
đź‘Ť
Also I've JLC imported C5592 and the 3D Model is not aligned properly.
CC @Techmannih
yea idk why this started happening but i'm getting very very annoyed- this should not be happening. We have 3d snapshot testing now
CC @anyreviewer lets get PNG snapshots in that repo and fix this once and for all. I've been seeing JLCPCB 3d flipping reporting errors for a year. We have snapshot testing- it's not crazy to pull out a rotation value
CC @Andrii
look at how core does 3d snapshot testing, get a PR with 3d snapshot testing in (idc if it's broken) and let's get this fully fixed.
GitHub
feat: render 3d snapshots with poppygl by seveibar · Pull Request ...
Summary
replace the 3D snapshot matcher to render GLB output with poppygl and circuit-json-to-gltf
expose matcher options for camera configuration and tighten snapshot diffing behavior
bump the at...
Still needs the actual fix but now we have extremely solid 3d snapshots at least
This behavior doesn’t appear in EasyEDA?????
@Techmannih this is because I made major patches yesterday
i've probably fixed all the issues, but the task is now to confirm the fixes via snapshot tests
also why are legs missing lol
i noticed this in some of my snapshots but assumed it was the easyeda model (i guess i was wrong)
that is probably a circuit-json-to-gltf bug that we should repro @Techmannih , but the legs will show up in the regular 3d-viewer so we can still create the snapshots and use it for basic orientation testing
yeas, in tscircuit.com looks ok, but fetching wrong position offsets, its work with 0,0,0
where are you fetching these position offsets from?
And yes, I changed mine to 0,0,0 and it worked beautifully
I manually fetched the data via EasyEDA and used it in tscircuit.com.
I think tscircuit.com isn’t working for importing JLCPCB parts.
why don't you try some random parts with all 0 values on the offsets and run the tests on those. see what happens.
there is no legs issue
