Ray Kholodovsky - tscircuit's "processed" kicad...
tscircuit's "processed" kicad footprints do not have rounded edges like the original ones do.
on the same note, the courtyard rect, etc...
Thus, when I do
I get a not-true-to-source not-rounded footprint on my PCB.
21 Replies
GitHub
Support "rounded rects" for pcb smtpads · Issue #1077 · tscircuit...
Propose change the circuit json specification (probably adding corner_radius to the rect shape Add support in tscircuit/props for cornerRadius Add support in circuit-to-svg Add support in pcb-viewe...
Make sense we can support border radius
@Techmannih do you want to take this
Yeah sure
also for rotated_rect smtpads?
yes
going to be a bit of work lol
yes, just confirm😁
@Techmannih let me know you want some work or you want to divide the work
Ready to help
yeah sure
Before working on the docs, which repo should I target to add cornerRadius support? Add in these repo
iiuc, you want to do circuit-to-svg first, then core, then all the others the order doesn't matter
i think you already did circuit-to-svg
do we need to implement or any other way to set?
@Seve
Yea needs to be implemented
Easy to implement using some trigonometry
I have supported to circuit-json, props, core, circuit-to-svg, pcb-viewer and 3d viewer,
but still I am not getting the update in doc? what is missing
have you checked that svg.tscircuit.com is up to date, does it work on tscircuit.com?
on passing the props its wroking but not working in pcb output
i think you might just need to make sure everything is updated, it's easy to test on tscircuit.com so start there.
run it locally and update deps
yes i m trying lika that
repro in core
no working in core i have implemented in core
I am just trying this not done yet
i think you have a dep issue then, maybe the pcb-viewer, but this is a support thread so we shouldn't be discussing little technical details here