tscircuit•4d ago

Mustafa7 - https://github.com/tscircuit/runfram...

https://github.com/tscircuit/runframe/pull/2075
Vercel deployement failing, cannot merge

Rishabh•12/12/25, 12:57 PM

Something is wrong with your package

Mustafa7OP•12/12/25, 1:58 PM

@Rishabh https://github.com/tscircuit/circuit-json-to-step/pull/21
Is this the correct solution for this?

RRishabh Something is wrong with your package

Mustafa7OP•12/12/25, 2:37 PM

is it becasue of the nodejs imports at the top of the file?
Like this:

import { promises as fs } from "node:fs"
import path from "node:path"
import { fileURLToPath } from "node:url"

import { promises as fs } from "node:fs"
import path from "node:path"
import { fileURLToPath } from "node:url"

How about loading it dynamically?

Rishabh•12/12/25, 2:46 PM

I think so, why do you need to import promisespromises?

Mustafa7OP•12/12/25, 2:51 PM

Its imported so we can use the promise-based readFile API with await (without callbacks) for local file paths

Rishabh•12/12/25, 3:00 PM

But that won't work in browser. You might need to do two exports for this if you want to use this library in browser too. Not sure

@Seve can help in this?

Seve•12/12/25, 4:01 PM

yea you can't use node imports

Seve•12/12/25, 4:01 PM

circuit-json-to-step shouldn't use node imports

Seve•12/12/25, 4:02 PM

@Mustafa7 none of our circuit-json-to-*circuit-json-to-* modules can import node-only modules as part of the lib. You can import them in tests, but not as part of the lib

Seve•12/12/25, 4:03 PM

this is also why you can never provide file paths to them- you must provide the file content