tscircuit•3d ago

Seve - @Abse i squashed this a long time ago, p...

@Abse i squashed this a long time ago, please make sure it doesn't come back!!!

Abse•12/13/25, 8:56 PM

On it

SeveOP•12/13/25, 9:25 PM

i think techman got it

Abse•12/13/25, 9:26 PM

@Techmannih you got it?

SeveOP•12/13/25, 9:26 PM

https://github.com/tscircuit/circuit-to-canvas/pull/18

AAbse <@1067854999889137715> you got it?

Techmannih•12/13/25, 9:27 PM

yes but this in circuit-to-canvas, I think need to do for core also

SeveOP•12/13/25, 9:27 PM

oh yea actually- the issue is in circuit-to-svg

SeveOP•12/13/25, 9:28 PM

but techmans approach is right

SSeve oh yea actually- the issue is in circuit-to-svg

Abse•12/13/25, 9:28 PM

Ok can we use canvas in circuit to svg

SeveOP•12/13/25, 9:28 PM

noooo

Techmannih•12/13/25, 9:28 PM

may be use logic

SeveOP•12/13/25, 9:28 PM

but the letters are being recentered

TTechmannih yes but this in circuit-to-canvas, I think need to do for core also

Abse•12/13/25, 9:28 PM

Wana do it?

SeveOP•12/13/25, 9:28 PM

yea it's bad logic

Abse•12/13/25, 9:29 PM

I will be on my cpu in half an hour

Abse•12/13/25, 9:29 PM

I can do it if techman don't

AAbse Wana do it?

Techmannih•12/13/25, 9:29 PM

yes I try to do it now

Abse•12/13/25, 9:57 PM

@Seve I've been trying to make this work for two days, I'm having an issue of how to transform inflated traces, can you take a look it's wasting time https://github.com/tscircuit/core/pull/1754

SeveOP•12/13/25, 9:57 PM

i can look tonight!

SeveOP•12/13/25, 9:58 PM

yea it's not easy at all

Abse•12/13/25, 9:58 PM

I want to do it but maybe you have an idea of how to do it

SeveOP•12/13/25, 9:58 PM

i mean your approach looks OK, just make sure i have some good test cases (maybe your PR already has this)

Abse•12/13/25, 9:59 PM

oh wait I didn't update the snapshot

Abse•12/13/25, 9:59 PM

the issue is with panel moving the board

SeveOP•12/13/25, 10:00 PM

hehe yea sorry i would take a deeper look but i'm very deep into an autorouter optimization

SeveOP•12/13/25, 10:00 PM

i will tonight tho

Abse•12/13/25, 10:00 PM

SeveOP•12/13/25, 10:00 PM

ah ok helpful

Techmannih•12/13/25, 10:26 PM

https://github.com/tscircuit/circuit-to-svg/pull/458

Techmannih•12/13/25, 10:27 PM

@Seve

Techmannih•12/13/25, 10:27 PM

@Abse

SeveOP•12/14/25, 5:33 AM

@Abse haven't forgotten about this Trace issue yet- i took a quick peek at the code and i think you might just need to implement transformPcbElementstransformPcbElements for traces (from circuit-json-util) has support for moving traces or otherwise make sure that _repositionOnPcb is being called against traces. But it seems like you're pretty close

I left some comments because it seems like there's an unrelated bug related to source traces, but i think your approach is right, just look at the render cycle, use the debuggerdebugger command with bun test /path/to/test --inspect-waitbun test /path/to/test --inspect-wait

SeveOP•12/14/25, 5:34 AM

i think i would try to follow the logic from Panel.ts realizing it needs to call Board._repositionOnPcb, which calls chil methods, then making sure those child methods actually move the trace. The debugger can make it easy to get a console to do realtime inspection.

Abse•12/14/25, 2:11 PM

@Seve https://github.com/tscircuit/core/pull/1767

Abse•12/14/25, 2:13 PM

the group box width and height in pcb viewer are not drawn from the pcb group circuit json width and height, I would say this is a bug ?

Abse•12/14/25, 2:13 PM

I fixed it but we need to merge core first

AAbse the group box width and height in pcb viewer are not drawn from the pcb group ci...

Techmannih•12/14/25, 2:46 PM

are you taking about this?
https://pcb-viewer.vercel.app/?fixture=%7B%22path%22%3A%22src%2Fexamples%2F2025%2Fboard-anchor-offset.fixture.tsx%22%7D

Abse•12/14/25, 2:46 PM

No no it's an old bug I would say

Abse•12/14/25, 2:47 PM