I added As<T> method to all the math types - I'm looking at the box/rect code right now. Was there a

I added As<T> method to all the math types - I'm looking at the box/rect code right now. Was there anything else you noticed that I didn't write down?

Perksey•5/7/21, 10:27 AM

it was @nathanaldensr which was using maths only

Deleted UserOP•5/7/21, 10:27 AM

Perksey•5/7/21, 10:27 AM

just do a from:@NathanAldenSrfrom:@NathanAldenSr to double check

TheLetterG•5/7/21, 10:27 AM

Deleted UserOP•5/7/21, 10:28 AM

yup, you are correct, memory isn't great

Perksey•5/7/21, 10:32 AM

looks like

look at box/rectangle methods (GetScaled was multiplying by 1.8 instead of 0.8)
rectangle casting
align rectangle APIs with box2d APIs
TScale for GetScaled

Perksey•5/7/21, 10:34 AM

yeah regen had no changes after the SDK release

Perksey•5/7/21, 10:35 AM

(they were already in Vulkan-Headers before LunarG finalised the SDK)

Perksey•5/7/21, 10:35 AM

so we're good to go

Deleted UserOP•5/7/21, 10:36 AM

amazing

Deleted UserOP•5/7/21, 10:37 AM

will approve in a couple of minutes

Deleted UserOP•5/7/21, 10:48 AM

that was insane - first time I approved a CI completed auto merge PR

Deleted UserOP•5/7/21, 10:48 AM

just an instant commit, branch deleted, issues closed

Deleted UserOP•5/7/21, 10:48 AM

all split second

Deleted UserOP•5/7/21, 10:48 AM

so fast in fact github UI got confused

Deleted UserOP•5/7/21, 10:51 AM

whereas GitHub is smart enough to follow through to the CSharp folder on the inside atm

note that GitHub would click through examples/CSharp too. @Perksey

Perksey•5/7/21, 10:52 AM

......

Perksey•5/7/21, 10:52 AM

ah yes

Perksey•5/7/21, 10:52 AM

in which case

Perksey•5/7/21, 10:52 AM

outside will work fine

Perksey•5/7/21, 10:52 AM

wait

Perksey•5/7/21, 10:52 AM

why doesn't it currently

Perksey•5/7/21, 10:52 AM

Directory.Build.props

Perksey•5/7/21, 10:52 AM

eh we can just move that

Deleted UserOP•5/7/21, 10:52 AM

oh lol yup that's a bit weird

Perksey•5/7/21, 10:52 AM

<LangVersion>9</LangVersion><LangVersion>9</LangVersion> this is c# specific anyway

Perksey•5/7/21, 10:52 AM

so yeah move that into the CSharp folder

Deleted UserOP•5/7/21, 10:53 AM

will do

Perksey•5/7/21, 10:53 AM

awesome!

Deleted UserOP•5/7/21, 11:06 AM

aaaaaaaaaaaaah why are solution files so garbage

Deleted UserOP•5/7/21, 11:06 AM

hand editing is literally impossible

TheLetterG•5/7/21, 11:07 AM

My VS updates every guid in the sln every time i add a test project. So i've been manually editing the sln in every pull request to avoid that :I

Deleted UserOP•5/7/21, 11:07 AM

Rider just reloads the entire solution each time

Deleted UserOP•5/7/21, 11:07 AM

so it's waiting like 2 minutes per project

Deleted UserOP•5/7/21, 11:08 AM

quite nice when you do some restructuring of a bunch of projects

Deleted UserOP•5/7/21, 11:08 AM

oh also

Deleted UserOP•5/7/21, 11:08 AM

@Perksey can we maybe first merge the benchmark project

Deleted UserOP•5/7/21, 11:08 AM

cause I'm not sure how well SLN merging works

Deleted UserOP•5/7/21, 11:08 AM

just noticed

DDeleted User cause I'm not sure how well SLN merging works

Perksey•5/7/21, 11:13 AM

In GitKraken tick both

Perksey•5/7/21, 11:13 AM

simplest way

Perksey•5/7/21, 11:14 AM

If you accidentally changed all the other GUIDs though it is more complicated

Perksey•5/7/21, 11:14 AM

but if you’ve only added new stuff merge in main and tick both sides on the sln

Deleted UserOP•5/7/21, 11:17 AM

TheLetterG•5/7/21, 11:18 AM

So apparently we can stop that 'guid constantly changing' thing by specifically setting the <ProjectGuid> field in the csproj's, if it doesnt have one set then apparently the sln's are allowed to just reinvent them as they see fit

Perksey•5/7/21, 11:18 AM

Yeah but that’s just so damn ugly

Perksey•5/7/21, 11:19 AM

and is only a VS thing, whereas we both use Rider so it’s only a concern for incoming contributions

Perksey•5/7/21, 11:19 AM

which are currently few and far between

TheLetterG•5/7/21, 11:20 AM

They are, might make it easier to get more though, as we're less likely to see people stick around if using their IDE of choice means they have to manually make sure the guids dont change every time they want to contribute

I added As<T> method to all the math types - I'm looking at the box/rect code right now. Was there a

Similar Threads

Similar Threads

Similar Threads