Actor Sheet Changes

Actor Sheet changes:
-NPC, Character: systems/dnd5e/templates/actors/parts/actor-warnings.html partial that displays warnings in-sheet.

-NPC, Character: AC now has a config instead of being an input. class="config-button" data-action="armor"

- Vehicle: AC input now targets data.attributes.ac.flat and does not have the same config as creatures.

-NPC, Character: attributable class with a data-property is what drives the AC tooltip. This can be placed on any element and the tooltip will be appended to that element.

-NPC, Character Main Attribute checkbox input values did this: value={{ability.proficient}} -> value={{ability.baseProf}}

-NPC, Character Skill prof checkbox input values did this: value="{{skill.value}}" -> value="{{skill.baseValue}}"
(unsure why these changed, the name didn't)

- cases of {{localize "DND5E.AbbreviationLbs"}} -> {{ @root.weightUnit }}

- proficiency selector for the following has changed:
- Armor class="trait-selector" data-options="armorProficiencies" -> class="proficiency-selector" data-type="armor"
- Weapons class="trait-selector" data-options="weaponProficiencies" -> class="proficiency-selector" data-type="weapon"
- Tools class="trait-selector" data-options="toolProficiencies" -> class="proficiency-selector" data-type="tool"

@sdenec you might be interested in this thread. I'm looking through the Diff and cataloging every change I see to the Actor Sheets.

@Surge I notice in 1.4.0 the vehicle stock sheet does get the Effects Tab now.

@Surge gave LeaguePoints™ to @Calego (ElfFriend) (#1 • 989)

Hmmmmm innnteresting

I thought for sure I saw this in the diff

Can you check if the DOM for the tab exists, but not the tab control to activate it?

Right, wondering about the contents of sheet-body

Like I'm thinking the tab button didn't get added but the tab contents did (they're just inaccessible because of the missing tab button)

Lol

Rip

You wanna open a MR to fix that?

Oooh nice!

I remember seeing a MR from atro revamping those a little but haven't been paying close attention

I suspect it's 1.4.x, the milestone for 1.5 has other focuses

@Surge gave LeaguePoints™ to @Calego (ElfFriend) (#1 • 1001)