Crit confirm change target

Looks like Fury merged the thing already, so whatever you do would no longer be relevant for the MR. Whatever improvements you can think of tho would probably still be for the better.
6 Replies
Ethaks
Ethaks3y ago
What I wanted to check wrt the MR was stacking. Using the raw changes might (should) give you all of them regardless of stacking rules, for which using sourceDetails might be better since they ought to be the result of the Change application process
Mana
Mana3y ago
Ahh, then yeah, there's probably a stacking problem with it.
Ethaks
Ethaks3y ago
The actor's sourceDetails are mostly used for tooltips etc. and less for the actual application of things, but just throwing in the resulting value makes source tracking quite meh
Mana
Mana3y ago
I guess Fury missed that too, since they tweaked it a bit afterwards. I've been kinda clueless with the change system's bits overall. Amazed whenever I successfully(?) do anything with it honestly.
Ethaks
Ethaks3y ago
Yeah, the whole setup is a bit labyrinthine 😅
Mana
Mana3y ago
Morale bonus to crit confirm stacks, so I guess it is indeed wrong. Well, the correction is out there now: https://gitlab.com/Furyspark/foundryvtt-pathfinder1/-/merge_requests/210