Silk.NET•3y ago

IDisposable changes to the PFN structs

Created a PR for the IDisposable changes to the PFN structs that are manually written: https://github.com/dotnet/Silk.NET/pull/615

GitHub

Add IDisposable call to SilkMarshall.Free for all PFN-structs by p3...

Adding the IDisposable interface as it is implemented for the generated PFN structs (see StructWriter)

6 Replies

peterix•3y ago

Is the failing build my fault ?

Deleted User•3y ago

@Perksey CI is sad

       1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(131,5): error : '[**FromWorkload**]' is not a valid version string. [D:\a\Silk.NET\Silk.NET\build\sln\Legacy-iOS.gen.sln]

       1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(131,5): error : '[**FromWorkload**]' is not a valid version string. [D:\a\Silk.NET\Silk.NET\build\sln\Legacy-iOS.gen.sln]

Perksey•3y ago

errrrr

peterix•3y ago

So is this something i need to adapt or is it "just" the CI that fails ?

Perksey•3y ago

this is something I hope to fix today, I think there was a breaking change in the .NET 6 Pre 7 -> RC1 transition that we need to update our repo for once I’ve fixed it, you’ll just need to merge the latest main into your branch and it’ll work

peterix•3y ago

ok. just @ me when you get around doing it 🙂

Gaming

Programming

IDisposable changes to the PFN structs