item preCreate

CCalego9/28/2021
@VTTA.io @MrPrimate (pinging you two in particular because you do import stuff involving existing actors)

There was a change to the 5e logic around the _onCreateOwnedXXXX methods in Item5e during _preCreate to better support automatically setting the proficiency of said items. https://gitlab.com/foundrynet/dnd5e/-/blob/1.5.x/module/item/entity.js#L1474

This caused a problem for equipment (but probably other item types too, being investigated) which was just found and MRed: https://gitlab.com/foundrynet/dnd5e/-/merge_requests/422

I bring this up because it only affects cases where incomplete data is used to create the Item, which feels to me more likely with your use cases of programmatically creating/updating items. If you have a chance, it would be great to give your use cases a test in the 1.5.x branch and double check there wasn't an accidental breaking change.
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
It'll work on 0.8.9
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
:chef_kiss: thanks for checking
LTLLLeo The League Lion9/28/2021
@Calego (ElfFriend) gave :vote: LeaguePoints™ to @MrPrimate (#66 • 23)
CCalego9/28/2021
How's the odds these changes to applying prof for items make life easier for you?
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
This in particular might be useful for you
https://gitlab.com/foundrynet/dnd5e/-/merge_requests/320
UUUnknown User9/28/2021
3 Messages Not Public
Sign In & Join Server To View
CCalego9/28/2021
cool
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
I believe the theory is that adding new things to CONFIG.DND5E.(weapon|armor|etc..)Ids will "just work".
Similarly, the compendium being used is configurable with CONFIG.DND5E.sourcePacks.ITEMS.

@arbron can probably speak more to the theory of this, but my understanding is that it's meant to be expandable and localizable with these constants
UUUnknown User9/28/2021
2 Messages Not Public
Sign In & Join Server To View
Aarbron9/28/2021
This is to keep backwards compatibility with the old tool proficiencies for things like disguise kit which were available in the old proficiency selector
Aarbron9/28/2021
Yeah, if you want to add new items you can either include just their id (e.g. gun: "hHdQmHFPgTLEwBfY") or the full UUID if it isn't in the default items compendium (e.g. gun: "mymodule.items.hHdQmHFPgTLEwBfY")
CCalego9/28/2021
Oooo shit full UUID supported too? niiiiice
Aarbron9/28/2021
Yeah, new in 1.5
CCalego9/28/2021
thanks @arbron
LTLLLeo The League Lion9/28/2021
@Calego (ElfFriend) gave :vote: LeaguePoints™ to @arbron (#79 • 15)
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View