CCalego9/28/2021
@sol.folango @mrprimate (pinging you two in particular because you do import stuff involving existing actors)

There was a change to the 5e logic around the _onCreateOwnedXXXX methods in Item5e during _preCreate to better support automatically setting the proficiency of said items. https://gitlab.com/foundrynet/dnd5e/-/blob/1.5.x/module/item/entity.js#L1474

This caused a problem for equipment (but probably other item types too, being investigated) which was just found and MRed: https://gitlab.com/foundrynet/dnd5e/-/merge_requests/422

I bring this up because it only affects cases where incomplete data is used to create the Item, which feels to me more likely with your use cases of programmatically creating/updating items. If you have a chance, it would be great to give your use cases a test in the 1.5.x branch and double check there wasn't an accidental breaking change.
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
It'll work on 0.8.9
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
:chef_kiss: thanks for checking
LTLLeo The League Lion9/28/2021
@calego gave :vote: LeaguePoints™ to @mrprimate (#66 • 23)
CCalego9/28/2021
How's the odds these changes to applying prof for items make life easier for you?
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
This in particular might be useful for you
https://gitlab.com/foundrynet/dnd5e/-/merge_requests/320
UUUnknown User9/28/2021
3 Messages Not Public
Sign In & Join Server To View
CCalego9/28/2021
cool
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View
CCalego9/28/2021
I believe the theory is that adding new things to CONFIG.DND5E.(weapon|armor|etc..)Ids will "just work".
Similarly, the compendium being used is configurable with CONFIG.DND5E.sourcePacks.ITEMS.

@arbron can probably speak more to the theory of this, but my understanding is that it's meant to be expandable and localizable with these constants
UUUnknown User9/28/2021
2 Messages Not Public
Sign In & Join Server To View
Aarbron9/28/2021
This is to keep backwards compatibility with the old tool proficiencies for things like disguise kit which were available in the old proficiency selector
Yeah, if you want to add new items you can either include just their id (e.g. gun: "hHdQmHFPgTLEwBfY") or the full UUID if it isn't in the default items compendium (e.g. gun: "mymodule.items.hHdQmHFPgTLEwBfY")
CCalego9/28/2021
Oooo shit full UUID supported too? niiiiice
Aarbron9/28/2021
Yeah, new in 1.5
CCalego9/28/2021
thanks @arbron
LTLLeo The League Lion9/28/2021
@calego gave :vote: LeaguePoints™ to @arbron (#79 • 15)
UUUnknown User9/28/2021
Message Not Public
Sign In & Join Server To View

Looking for more? Join the community!

Recommended Posts
Item Macro Compendium WorkflowOkay, here's a long one that's a bit of a doozy. I'm looking at setting up some sort of tooling/workItem Specific Crit DetailsOh that critical hit thing is gonna hit MRE too isn't it... hrm...1.5.x 72%@dnd5e No action required (but suggested 🙂 ) The 1.5.0 milestone is ~72% complete. It has a due daV9 Tabs IssueIf you never figured this out, here's why this happened: A small change in `Tabs` during v9 causes sDeck Creation MacroI created a macro to fill out a 52-card deck, you set the ID of the deck and the base URL of the foldevmode-issues@arcanist figured out, the flex layout elements have `pointer-events: none`, so anything injected wifunction vs methodAnyone know of a good guide that explains the difference between a function and a method? I don't reActive Effect HelpAnd it should be the actual ActiveEffect document for the effect, not just the id. I don't have theTOL JEs@badgerwerks I haven't had a chance to poke around in TOB/BoL yet, but I wanted to ask how you did tCI 2 minute windowAlright, I've got a Gitlab CI pipeline I'm reasonably pleased with as a result of yesterday's effortGitLab CI PipelinesToday's project is Gitlab CI. Wow me with your pipelines if you got em.Storybook Shennanegins@wyrmisis I have a headcannon for you, one who also uses Storybook. _What if_ we could load foundryjsxDammit I want this...react librarySo far I've seen Vue 2, Vue 3, Alpine, and Svelte pulled into Foundry. No one has yet been crazy enoweb componentsA comment @n1xx1 made over in #development-basics (https://discord.com/channels/732325252788387980/7UI element JS Classeshttps://discord.com/channels/732325252788387980/734922093967310910/882979923483037696 @wyrmisis > Imid-milestone ping feedback@dnd5e **No Action Required** Wanted to ping you to make you aware that the 1.5.0 milestone is >50%Hot ReloadingIs there a way to do something like hot module reloading/live reloading on change for Foundry?Tagger Code ReviewWould anyone be keen to code review Tagger? I'd like to git better 😄 https://github.com/Haxxer/Founsocket woesnot the socket firing