flag shenannegins

TIL you can set the flags key on a document to whatever you want to (e.g. a string). This is a sure fire way to completely ruin someone else's day, or your own day when another module un-does this by setting a flag 'correctly'.

game.actors.getName('A Character').update({
  ['flags']: 'A value'
})

game.actors.getName('A Character').data.flags // 'A value'

game.actors.getName('A Character').setFlag('world', 'someKey', 'some string value')

game.actors.getName('A Character').data.flags // { world: { someKey: 'some string value' }}

dnd5e for instance gets big mad when its flags disappear from an actor.

It seems that core doesn't care

this falls squarely under "play stupid games win stupid prizes" lol

speaking of...

I want to try this with items or like data itself, but am too scared

omg lol

Alright well. TIL update has great power and thus comes with great responsibility.

[removed gif]
oo no that looks like it actually hurt

no more of that gif thanks

much better

lol

Is this a "bug"?

I would not categorize it as such.

If I got sent a bug with this at work, my reply to it would be "... don't" and I'd WONTFIX it.

Makes sense, thanks

if I couldn't get away with telling them to "just don't" I'd say something like:

The amount of complexity and performance overhead that would be introduced by adding validations to this low-level API do not outweight being able to prevent the edge case described by this issue.

😛