compendium errors upgrading to v9

hmm im not entirely sure how this will work though.. because I did just a quick smell test to my module under v9, and it broke on the compendium settings which is absolutely core to the module 😛 and I'm not sure if whatever I do to fix it will work on 0.8.x
C
corporat•932d ago
Mind sharing what errors you got? I know of one change that should only produce a deprecation warning
C
ccjmk•932d ago
i am .. not entirely sure, but I built a FormApplication on my module to have users select compendiums, and then I mapped those into an array. but the application result is now different
C
corporat•932d ago
And I know of at least one bug with compendiums
C
ccjmk•932d ago
its a little hard to explain, honestly, I would need to produce some examples and/or show you but I don't recall ANY deprecation message and/or error it just.. returned something different than before (firing up v8)
C
corporat•932d ago
There should be a deprecation warning if a pre-v9 compendium is being used in v9. The schema has changed Could be causing weirdness
C
ccjmk•932d ago
hmmm I did some HB shenanigans to implement this, registered a checked helper, but it's all a little finnicky, never fully understood what I was doing honestly xD so.. here's 0.8.9 working response.. when the FormApplication is closed, I get this formData on _updateObject(event, formData).
{"races":[false,false,false,false,false,true,false,false,false,false,false,false,false,false,false],"racialFeatures":[false,false,false,false,false,false,false,false,false,false,false,false,true,false,false],"classes":[false,false,false,true,false,false,false,false,false,false,false,false,false,false,false],"classFeatures":[false,false,false,false,true,false,false,false,false,false,false,false,false,false,false],"backgroundFeatures":[false,false,false,false,false,false,false,false,false,false,false,false,false,false,false],"spells":[false,false,true,false,false,false,false,false,false,false,false,false,false,false,false],"feats":[false,false,false,false,false,false,false,false,false,false,false,false,false,false,false]}"
{"races":[false,false,false,false,false,true,false,false,false,false,false,false,false,false,false],"racialFeatures":[false,false,false,false,false,false,false,false,false,false,false,false,true,false,false],"classes":[false,false,false,true,false,false,false,false,false,false,false,false,false,false,false],"classFeatures":[false,false,false,false,true,false,false,false,false,false,false,false,false,false,false],"backgroundFeatures":[false,false,false,false,false,false,false,false,false,false,false,false,false,false,false],"spells":[false,false,true,false,false,false,false,false,false,false,false,false,false,false,false],"feats":[false,false,false,false,false,false,false,false,false,false,false,false,false,false,false]}"
those arrays of booleans map to the Item compendiums the user has on the world, I map those later into their appropriate names to save them reversed (e.g. races: { 'dnd5e.races': true, ...} IIRC) and what I get on v9.... (a min)
'{"races":["dnd5e.items","dnd5e.races"],"racialFeatures":["dnd5e.races"],"classes":["dnd5e.classes"],"classFeatures":["dnd5e.classfeatures"],"backgroundFeatures":[],"spells":["dnd5e.spells"],"feats":[]}'
'{"races":["dnd5e.items","dnd5e.races"],"racialFeatures":["dnd5e.races"],"classes":["dnd5e.classes"],"classFeatures":["dnd5e.classfeatures"],"backgroundFeatures":[],"spells":["dnd5e.spells"],"feats":[]}'
interestingly, this seems even easier to work with xD but I have no idea why this changed i don't remember why I didn't save stuff this way directly on the setting, but I will give it a try! saving exactly which compendiums have each data instead of marking them all should probably help a little with performance when reading them this is how my setting is supposed to look (i forgot I trimmed unused compendia hahah)
{
"races":{"dnd5e.races":true},
"racialFeatures":{"dnd5e.races":true},
"classes":{"dnd5e.classes":true},
"classFeatures":{"dnd5e.classfeatures":true},
"backgroundFeatures":{},
"spells":{"dnd5e.spells":true},
"feats":{}
}
{
"races":{"dnd5e.races":true},
"racialFeatures":{"dnd5e.races":true},
"classes":{"dnd5e.classes":true},
"classFeatures":{"dnd5e.classfeatures":true},
"backgroundFeatures":{},
"spells":{"dnd5e.spells":true},
"feats":{}
}
I do some complicated mappings back and forth, there might be an easier and more straightforward way of doing this :/
Want results from more Discord servers?
Add your server
More Posts
Blind Chat MessagesAnyone have good examples of creating a chat message that should only be visible to a connected GM, compendium shennaneginsTIL about `CompendiumContent.getDocuments` taking nedb queries. ``` game.packs.get('dnd5e.heroes').gwith just a parent class and the class name, is there a way to instantiate a new class?JamesB and @veterini have a question for y'all in #coc7-dev https://discord.com/channels/7323252527More Hooks 5ehttps://github.com/ElfFriend-DnD/foundryvtt-more-hooks-5e I'm going to try to use this library to hacreateEmbeddedDocuments issueI'm going to throw my code in a thread so I don't clutter this channel up with a wall of textBase Item@otigon it occurs to me that the new `baseItem` property on weapons and such is probably of interestCompendium loadinghmm ghost, I added some console.time tags here and there to measure the difference between loading oSkill and Ability bonusesA massive enhancement of Skills and Ability Checks/Saves allows them to be individually affected by 150 Sheet Changes@sdenec @lordzeel Sheet Changes required: - New Cog-menu for Ability Scores and Skills to support neDocumentData shennaneginsTIL: It is possible to `update` an Actor or Item's `data.data` with arbitrary information that isn'tflag shenanneginsTIL you can set the `flags` key on a document to whatever you want to (e.g. a string). This is a surraaeAfter some discussion yesterday in #active-effects , I decided to try to create a system-agnostic modevMode json changed warningI checked the module repo and I honestly can't figure out where I would plug in my code. I'd be guesS3 File Picker SettingsCan someone with an S3 configuration give me a test of the FilePicker settings api and tell me if a item preCreate@sol.folango @mrprimate (pinging you two in particular because you do import stuff involving existinItem Macro Compendium WorkflowOkay, here's a long one that's a bit of a doozy. I'm looking at setting up some sort of tooling/workItem Specific Crit DetailsOh that critical hit thing is gonna hit MRE too isn't it... hrm...1.5.x 72%@dnd5e No action required (but suggested 🙂 ) The 1.5.0 milestone is ~72% complete. It has a due daV9 Tabs IssueIf you never figured this out, here's why this happened: A small change in `Tabs` during v9 causes sDeck Creation MacroI created a macro to fill out a 52-card deck, you set the ID of the deck and the base URL of the fol