I _think_ we’re going to be automatically excluding all folders named `node_modules`. We should prob

J

James•4/17/22, 7:29 PM

Yeah seems like it from my testing.

node_modules/*

node_modules/*

node_modules/*

node_modules/* at any depth seems ignored

G

GregBrimbleOP•4/17/22, 7:30 PM

Same will be true for _headers and _redirects. Again, should probably only ignore the ones at root.

G

GregBrimbleOP•4/17/22, 7:30 PM

I’ll look into it next week

W

Walshy•4/17/22, 7:35 PM

can you see if it works now, if it fails can you send me the deployment ID?

W

Walshy•4/17/22, 7:52 PM

#cloudflare-status

S

Specy•4/17/22, 11:31 PM

why arent they deployed to prod but stay as previews?

S

Specy•4/17/22, 11:34 PM

ah nvm branch name is case sensitive

B

Brandon Pittman•4/18/22, 3:34 AM

Trying to publish a Remix Pages project with

wrangler publish

wrangler publish

wrangler publish

wrangler publish but getting this error:

Could not resolve "public" after running custom build: npm run build

Could not resolve "public" after running custom build: npm run build

Could not resolve "public" after running custom build: npm run build

Could not resolve "public" after running custom build: npm run build

There's definitely a public directory.

BBrandon Pittman Trying to publish a Remix Pages project with `wrangler publish` but getting this...

H

Hello, I’m Allie!•4/18/22, 3:36 AM

Are you trying to publish a Worker, or a Pages project?

HHello, I’m Allie!Are you trying to publish a Worker, or a Pages project?

B

Brandon Pittman•4/18/22, 3:36 AM

Sorry, Pages.

Got the same thing working with Workers, but wanted to try Pages.

BBrandon Pittman Sorry, Pages. Got the same thing working with Workers, but wanted to try Pages...

H

Hello, I’m Allie!•4/18/22, 3:37 AM

Pages only currently supports deploys from Git. You can test, but you cannot deploy a Pages project with

wrangler

wrangler

wrangler

wrangler.

HHello, I’m Allie!Pages only currently supports deploys from Git. You can test, but you cannot dep...

B

Brandon Pittman•4/18/22, 3:37 AM

Okay, thanks.

C

Cоle•4/18/22, 4:57 AM

All of a sudden I'm getting 1101 on all of my static assets. Any ideas lol?

C

Cоle•4/18/22, 4:58 AM

my

/functions

/functions

/functions

/functions are working fine

CCоle All of a sudden I'm getting 1101 on all of my static assets. Any ideas lol?

W

Walshy•4/18/22, 7:36 AM

Is your repo public. If so, could you share

WWalshy Is your repo public. If so, could you share

C

Cоle•4/18/22, 7:47 AM

my repo isn't public, but I can share files + urls

C

Cоle•4/18/22, 7:48 AM

I'll info dump, lmk if there's anything in particular I should post

C

Cоle•4/18/22, 7:49 AM

https://api.pvplegacy.net/docs

C

Cоle•4/18/22, 7:50 AM

_middleware.ts

_middleware.ts

_middleware.ts

_middleware.ts just adds CORS headers, works fine on the other functions

C

Cоle•4/18/22, 7:50 AM

export const CORSHeaders: PagesFunction<{}> = async ({ request, env, next, data }): Promise<Response> => {
    let newRes = (await next()).clone();

    newRes.headers.set("Access-Control-Allow-Origin", "*");
    newRes.headers.set("Access-Control-Allow-Headers", "*");
    newRes.headers.set("Access-Control-Allow-Methods", "*");
    return newRes;
};

export const onRequest = [CORSHeaders];

export const CORSHeaders: PagesFunction<{}> = async ({ request, env, next, data }): Promise<Response> => {
    let newRes = (await next()).clone();

    newRes.headers.set("Access-Control-Allow-Origin", "*");
    newRes.headers.set("Access-Control-Allow-Headers", "*");
    newRes.headers.set("Access-Control-Allow-Methods", "*");
    return newRes;
};

export const onRequest = [CORSHeaders];

export const CORSHeaders: PagesFunction<{}> = async ({ request, env, next, data }): Promise<Response> => {
    let newRes = (await next()).clone();

    newRes.headers.set("Access-Control-Allow-Origin", "*");
    newRes.headers.set("Access-Control-Allow-Headers", "*");
    newRes.headers.set("Access-Control-Allow-Methods", "*");
    return newRes;
};

export const onRequest = [CORSHeaders];

export const CORSHeaders: PagesFunction<{}> = async ({ request, env, next, data }): Promise<Response> => {
    let newRes = (await next()).clone();

    newRes.headers.set("Access-Control-Allow-Origin", "*");
    newRes.headers.set("Access-Control-Allow-Headers", "*");
    newRes.headers.set("Access-Control-Allow-Methods", "*");
    return newRes;
};

export const onRequest = [CORSHeaders];

C

Cоle•4/18/22, 7:52 AM

I redeployed some other sites and all seems well, so I imagine I'm messing something up

C

Cоle•4/18/22, 7:53 AM

all urls that aren't covered by a

function/

function/

function/

function/ work fine. every other URL automatically breaks. even the

404.html

404.html

404.html

404.html is out

C

Cоle•4/18/22, 7:56 AM

I added ls's and stat's to my

npm build

npm build

npm build

npm build just to confirm that everything's there + permissions on the edge

CCоle ```ts export const CORSHeaders: PagesFunction<{}> = async ({ request, env, next,...

W

Walshy•4/18/22, 9:24 AM

This is what I suspect is failing. If it is hitting everything it'll be the middleware.

Now it should work but there is an issue with next currently (https://github.com/cloudflare/wrangler2/pull/796 you can also try this build)
This should work:

export const onRequest = async ({ next }) => {
  let response = await next()
  const headers = new Headers([...response.headers.entries()])

  // set cors headers
  headers.set('x-new-header', 'new value')

  response = new Response([101, 204, 205, 304].includes(response.status) ? null : response.body, { ...response, headers })
  return response
}

export const onRequest = async ({ next }) => {
  let response = await next()
  const headers = new Headers([...response.headers.entries()])

  // set cors headers
  headers.set('x-new-header', 'new value')

  response = new Response([101, 204, 205, 304].includes(response.status) ? null : response.body, { ...response, headers })
  return response
}

export const onRequest = async ({ next }) => {
  let response = await next()
  const headers = new Headers([...response.headers.entries()])

  // set cors headers
  headers.set('x-new-header', 'new value')

  response = new Response([101, 204, 205, 304].includes(response.status) ? null : response.body, { ...response, headers })
  return response
}

export const onRequest = async ({ next }) => {
  let response = await next()
  const headers = new Headers([...response.headers.entries()])

  // set cors headers
  headers.set('x-new-header', 'new value')

  response = new Response([101, 204, 205, 304].includes(response.status) ? null : response.body, { ...response, headers })
  return response
}

RRui Saraiva Hi 👋 Is anyone getting an immediate error on the "Initializing build environme...

W

Walshy•4/18/22, 9:25 AM

Yo, what's the deployment ID? The UUID in the URL

RRui Saraiva Here it is: d54d0d44-8a67-4a4d-b1a5-0b322ec203a5

W

Walshy•4/18/22, 9:43 AM

We no longer have your GitHub installation anymore. Make sure Pages is still added as an App in your account and re-create the project

Ppaper clover it seems others are getting this on sveltekit with workers ``` Note: No function...

W

Walshy•4/18/22, 1:47 PM

Hey, can you provide me the deployment ID? (Check #

pages-faq for how to get it)

DDeleted User Hello!... I am having some issue with custom domain... If I add custom domain i...

W

Walshy•4/18/22, 1:47 PM

Do you have something like a redirect covering your custom domain?

W

Walshy•4/18/22, 1:52 PM

can you please send me the pages.dev and custom domain?

W

Walshy•4/18/22, 1:54 PM

Uncaught ReferenceError: process is not defined

W

Walshy•4/18/22, 1:54 PM

(and yeah... we need to improve the logs there)

W

Walshy•4/18/22, 1:55 PM

Yep

I _think_ we’re going to be automatically excluding all folders named `node_modules`. We should prob

Similar Threads

Similar Threads

Similar Threads