early v10 compat testing

@dnd5e - No action required

Work is being done on fixing the core system compatibility with v10 in this branch:
https://github.com/foundryvtt/dnd5e/tree/v10-dev

This branch is at a point where all v10 warnings and errors are believed to be gone, and as such, assistance in proving this true or false is requested.

If you have a mind to try things out and report back about broken things, please pull down that branch and give things a test. Anything you find that seems out of the ordinary, holler about and/or open tickets for.

Happy hunting!

🧵

there seems to be an issue with completing the step2 from class advancements

ItemGrantAdvancements

yup, cause it happens with the Background too.. so it seems to be that type of advancement only. I will make a class with HP and scale only and see if that one goes through

Scale seems to work!

on a slightly unrelated topic, Advancements are not shown on the table, but they seem to exist just fine:

at first I noticed this while inspecting a class I had imported to edit, and I thought the advancements disappeared on import, but a class on the compendium and a class I created from scratch look the same and work except for the ItemGrant thingy, so it seems just a visual glitch, no console errors on this one

I will see if I can dit into this later with the code, just reporting the issue as of now (cause I imagine we are not yet opening gh issues for v10 right ?)

there also seems to be an issue with rests overall, and rolling dice on short rests

Some things still work apparently: I tried setting one resource to SR, another to LR, and another to both, and the long rest one gets replenished, HP also. Short rest resource doesn't replenish, and as you can't roll dice it can't heal HP either 🤷‍♂️

thanks @ccjmk

@Calego (ElfFriend) gave LeaguePoints™ to @ccjmk (#10 • 231)

np! I took the change to also update my module to v10 so it was a no-effort for me!

thanks @honeybadger

@Calego (ElfFriend) gave LeaguePoints™ to @honeybadger (#31 • 83)

thanks @MaxPat

@Calego (ElfFriend) gave LeaguePoints™ to @MaxPat (#110 • 11)

does isNumeric filter out NaN?

👍

Thanks @Zhell

@Calego (ElfFriend) gave LeaguePoints™ to @Zhell (#136 • 8)