early v10 compat testing

CCalego7/11/2022
@dnd5e - No action required

Work is being done on fixing the core system compatibility with v10 in this branch:
https://github.com/foundryvtt/dnd5e/tree/v10-dev

This branch is at a point where all v10 warnings and errors are believed to be gone, and as such, assistance in proving this true or false is requested.

If you have a mind to try things out and report back about broken things, please pull down that branch and give things a test. Anything you find that seems out of the ordinary, holler about and/or open tickets for.

Happy hunting!
CCalego7/11/2022
🧵
Cccjmk7/11/2022
there seems to be an issue with completing the step2 from class advancements
Cccjmk7/11/2022
ItemGrantAdvancements
Cccjmk7/11/2022
yup, cause it happens with the Background too.. so it seems to be that type of advancement only. I will make a class with HP and scale only and see if that one goes through
Cccjmk7/11/2022
Scale seems to work!
Cccjmk7/11/2022
on a slightly unrelated topic, Advancements are not shown on the table, but they seem to exist just fine:
Cccjmk7/11/2022
at first I noticed this while inspecting a class I had imported to edit, and I thought the advancements disappeared on import, but a class on the compendium and a class I created from scratch look the same and work except for the ItemGrant thingy, so it seems just a visual glitch, no console errors on this one
Cccjmk7/11/2022
I will see if I can dit into this later with the code, just reporting the issue as of now (cause I imagine we are not yet opening gh issues for v10 right ?)
Cccjmk7/11/2022
there also seems to be an issue with rests overall, and rolling dice on short rests
Cccjmk7/11/2022
Some things still work apparently: I tried setting one resource to SR, another to LR, and another to both, and the long rest one gets replenished, HP also. Short rest resource doesn't replenish, and as you can't roll dice it can't heal HP either 🤷‍♂️
CCalego7/11/2022
thanks @ccjmk
LTLLLeo The League Lion7/11/2022
@Calego (ElfFriend) gave :vote: LeaguePoints™ to @ccjmk (#10 • 231)
Cccjmk7/11/2022
np! I took the change to also update my module to v10 so it was a no-effort for me!
UUUnknown User7/11/2022
3 Messages Not Public
Sign In & Join Server To View
CCalego7/11/2022
thanks @honeybadger
LTLLLeo The League Lion7/11/2022
@Calego (ElfFriend) gave :vote: LeaguePoints™ to @honeybadger (#31 • 83)
UUUnknown User7/13/2022
4 Messages Not Public
Sign In & Join Server To View
CCalego7/13/2022
thanks @MaxPat
LTLLLeo The League Lion7/13/2022
@Calego (ElfFriend) gave :vote: LeaguePoints™ to @MaxPat (#110 • 11)
UUUnknown User7/13/2022
2 Messages Not Public
Sign In & Join Server To View
CCalego7/13/2022
does isNumeric filter out NaN?
UUUnknown User7/13/2022
Message Not Public
Sign In & Join Server To View
CCalego7/13/2022
đź‘Ť
UUUnknown User7/15/2022
8 Messages Not Public
Sign In & Join Server To View
CCalego7/15/2022
Thanks @Zhell
LTLLLeo The League Lion7/15/2022
@Calego (ElfFriend) gave :vote: LeaguePoints™ to @Zhell (#136 • 8)
UUUnknown User7/15/2022
Message Not Public
Sign In & Join Server To View