But we can't use the default GITHUB_TOKEN since it doesn't have permissions on forked workflows. Wha

But we can't use the default GITHUB_TOKEN since it doesn't have permissions on forked workflows.
What other options are there?

j0rge•2/28/23, 1:31 PM

we just need a way to test stuff

j0rge•2/28/23, 1:31 PM

like herm's pr I want to test in a VM to test all the flatpak installation, etc.

Jj0rge like herm's pr I want to test in a VM to test all the flatpak installation, etc.

Bigpod•2/28/23, 1:54 PM

yea its a dilema

RRobert But we can't use the default GITHUB_TOKEN since it doesn't have permissions on f...

Marco (马可)•2/28/23, 1:54 PM

The current workflow we have fixes that

Marco (马可)•2/28/23, 1:55 PM

which is a pull_request that pushes to an artifact on the run, then a second run that executes when that workflow completes, using the artifact that was uploaded to publish

Marco (马可)•2/28/23, 1:55 PM

@j0rge I'm going to dig back in and finish up what we were doing last night

Marco (马可)•2/28/23, 1:55 PM

If we use the above require approval for all outside contributors we can remove the need to use PR labels

Marco (马可)•2/28/23, 2:20 PM

Actually, I guess using ECR for PR pushes and GHCR for prod would be good (or any other registry)

j0rge•2/28/23, 3:24 PM

@marcoceppi I hadn't thought about that "Require approval" setting in github, I think if we had that we wouldn't want the label

Marco (马可)•2/28/23, 3:24 PM

Yeah, I think we can use that and drop the label

j0rge•2/28/23, 5:05 PM

@herm @marcoceppi tested PR-79 in a vanilla VM and everything worked perfectly!

Marco (马可)•2/28/23, 5:06 PM

@j0rge you can approve and merge

j0rge•2/28/23, 5:06 PM

yeah on it

j0rge•2/28/23, 5:08 PM

https://github.com/ublue-os/base/blob/main/Containerfile

GitHub

base/Containerfile at main · ublue-os/base

Base image: Silverblue with unfiltered Flathub, distrobox, and automatic updates - base/Containerfile at main · ublue-os/base

j0rge•2/28/23, 5:08 PM

oh yeah

j0rge•2/28/23, 5:08 PM

much cleaner now too

j0rge•2/28/23, 5:09 PM

j0rge•2/28/23, 5:10 PM

nice and cleaaaaaan!

Marco (马可)•2/28/23, 5:12 PM

I'll make sure this format is compat with the installer we're building for 38 as well

Marco (马可)•2/28/23, 5:12 PM

@hermmm thanks for the contribution!

j0rge•2/28/23, 5:12 PM

yeah that's much nicer in general

ChaiQi•2/28/23, 5:13 PM

Oooo, tidy!

j0rge•2/28/23, 5:13 PM

https://github.com/rhinstaller/anaconda/pull/4561#issuecomment-1448473181

GitHub

Master enable ostree containers by jkonecny12 · Pull Request #4561 ...

RPM OSTree is getting new functionality to use containers as the base
image. Thanks to that it's possible to use standard container
repositories.
This source enables to use these repositories.
...

j0rge•2/28/23, 5:13 PM

they're getting close

j0rge•2/28/23, 5:15 PM

ok we'll need to add the file stuff to the readme, I'll try to get to that later

RRobert By requiring approval, i mean this. The label wouldn't work as the logic in the...

j0rge•2/28/23, 5:20 PM

Alright, I turned this on org-wide everyone

Marco (马可)•2/28/23, 5:20 PM

@j0rge I'll update the action to drop the label requirement

j0rge•2/28/23, 5:20 PM

I'd like to sort out our label story ... but that, is a fight for another day

MMarco (马可)@hermmm thanks for the contribution!

xyny•2/28/23, 5:28 PM

np, cheers!

xyny•2/28/23, 5:28 PM

https://tenor.com/view/honest-word-its-honest-work-it-aint-much-it-aint-much-but-its-honest-work-gif-13763573

Tenor

it ain't much, but it's honest work.

xyny•2/28/23, 5:31 PM

I was going to try it in a vm too, I created a vm with the same password as my host but I got a typo in it and now I have clean silverblue a vm I'm locked out of...

xyny•2/28/23, 5:35 PM

Also: I'm probably going to be updating the Making your own page in the docs, but the base repository should probably link to it as a guide for people forking, as both guides are currently about forking base.

j0rge•2/28/23, 5:36 PM

I create one VM, install it, then I run through the first run of it, adding my username, etc. and then I shut that down, then I take a snapshot of it and then never touch it again, when I test a new thing I call it "silverblue-pr-79" for example

j0rge•2/28/23, 5:36 PM

but virt-manager is kinda clunky

xyny•2/28/23, 5:37 PM

I was supposed to ostree pin the vanilla image, but I guess it's no use now. Next time round I'll maybe use another password...

j0rge•2/28/23, 5:38 PM

yeah the reason I VM, especially with base is that we're touching flatpaks and I don't want to mess with that on my host

Jj0rge but virt-manager is kinda clunky

xyny•2/28/23, 5:39 PM

I used to use virtualbox and TBH virt-manager is pretty good, atleast as good as virtualbox. After installing the correct packages it just works. I tried the gnome Boxes flatpak, and it didn't work one bit, so I gave up and added virt-manager in my container. It's a breeze.

Xxyny I used to use virtualbox and TBH virt-manager is pretty good, atleast as good as...

bsherman•2/28/23, 5:41 PM

oh, you don't need libvirtd and friends in the silverblue host? just virt-manager and deps in a distrobox container is good enough?

j0rge•2/28/23, 5:42 PM

AGREED: The Change "Ostree Native Container (Phase 2,
stable)" has not been implemented for F38 and will be deferred to
F39 (+7, 0, -0)
AGREED: In addition to being deferred to F39, FESCo requests
that the Change "Ostree Native Container (Phase 2, stable)" will
have a contingency deadline of F39 Beta Freeze and the Scope of the
proposal will be filled (+7, 0, -0)

AGREED: The Change "Ostree Native Container (Phase 2,
stable)" has not been implemented for F38 and will be deferred to
F39 (+7, 0, -0)
AGREED: In addition to being deferred to F39, FESCo requests
that the Change "Ostree Native Container (Phase 2, stable)" will
have a contingency deadline of F39 Beta Freeze and the Scope of the
proposal will be filled (+7, 0, -0)

j0rge•2/28/23, 5:42 PM

looks like they won't be switching until F39

Bbsherman oh, you don't need libvirtd and friends in the silverblue host? just virt-manage...

xyny•2/28/23, 5:46 PM

By container-layering I meant not exactly layering by running rpm-ostree installs on the host but installing it in my own rpm-ostree native container image. I don't know if installing in a distrobox would cut it, as as far as I know some of the required deps have some kernel-level interfaces and need to be priviliged on the host.

xyny•2/28/23, 5:47 PM

Sorry for saying it in a bit of a confusing way, I'm not sure what would be a better term for it.

Xxyny By container-layering I meant not exactly layering by running rpm-ostree install...

bsherman•2/28/23, 5:48 PM

Ok, yes, what you meant is what I would have expected. I was surprised that perhaps one could make it work with what I thought I read.

Xxyny Sorry for saying it in a bit of a confusing way, I'm not sure what would be a be...

bsherman•2/28/23, 5:48 PM

maybe "host container image"?

it's a new world of terminology

xyny•2/28/23, 5:48 PM

or native container, as that's what they're officially

xyny•2/28/23, 5:50 PM

installing in native container
adding to native container

bsherman•2/28/23, 5:51 PM

I've been meaning to add libvirtd & virt-manager to my native container image as well, also because the Gnome Boxes flatpak doesn't work well... and really, even when Boxes works, it's still not as good.

j0rge•2/28/23, 5:52 PM

you mean just a container right?

j0rge•2/28/23, 5:52 PM

"native container" doesn't seem to make sense in this context to me?

j0rge•2/28/23, 5:53 PM

yeah the reason I use virt-manager is gnome boxes was just too unreliable for me, flatpak or otherwise. I'll give it a shot next cycle because the ui is nice.

AGREED: The Change "Ostree Native Container (Phase 2, stable)" has not been implemented for F38 and will be deferred to F39 (+7, 0, -0) AGREED: In addition to being deferred to F39, FESCo requests that the Change "Ostree Native Container (Phase 2, stable)" will have a contingency deadline of F39 Beta Freeze and the Scope of the proposal will be filled (+7, 0, -0)

But we can't use the default GITHUB_TOKEN since it doesn't have permissions on forked workflows. Wha

Similar Threads

Similar Threads

Similar Threads