<https://docs.github.com/en/actions/learn-github-actions/contexts#github-context>

Ррибаня <https://docs.github.com/en/actions/learn-github-actions/contexts#github-context...

J

jstone•3/4/23, 4:25 AM

Ah, no variable for just the repo name, or I suppose you'd have to trim

github.repository

github.repository

github.repository

github.repository?

Р

рибаняOP•3/4/23, 4:28 AM

you can try

${{ index (split github.repository "/") 1 }}

${{ index (split github.repository "/") 1 }}

${{ index (split github.repository "/") 1 }}

${{ index (split github.repository "/") 1 }}

but I haven't tested it

Ррибаня you can try ```go ${{ index (split github.repository "/") 1 }} ``` but I haven't...

J

jstone•3/4/23, 4:42 AM

Ah, so like

echo "IMAGE_NAME=${{ format('{0}-{1}', matrix.image_name, ${{ index (split github.repository "/") 1 }} }}" >> $GITHUB_ENV

echo "IMAGE_NAME=${{ format('{0}-{1}', matrix.image_name, ${{ index (split github.repository "/") 1 }} }}" >> $GITHUB_ENV

echo "IMAGE_NAME=${{ format('{0}-{1}', matrix.image_name, ${{ index (split github.repository "/") 1 }} }}" >> $GITHUB_ENV

echo "IMAGE_NAME=${{ format('{0}-{1}', matrix.image_name, ${{ index (split github.repository "/") 1 }} }}" >> $GITHUB_ENV

?

J

jstone•3/4/23, 5:33 AM

@j0rge Does this look good? https://github.com/ublue-os/nvidia/pull/55/files

GitHub

feat: Use variables more extensively in build workflow by joshua-st...

J

jstone•3/4/23, 5:34 AM

I'm seeing this in the metadata output:

      "org.opencontainers.image.title": "$IMAGE_NAME",
      "org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

      "org.opencontainers.image.title": "$IMAGE_NAME",
      "org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

      "org.opencontainers.image.title": "$IMAGE_NAME",
      "org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

      "org.opencontainers.image.title": "$IMAGE_NAME",
      "org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

J

jstone•3/4/23, 5:35 AM

Which appears to be the same as in here https://github.com/ublue-os/main/blob/main/.github/workflows/build.yml#L97

GitHub

main/build.yml at main · ublue-os/main

An OCI base image of Fedora with batteries included - main/build.yml at main · ublue-os/main

J

jstone•3/4/23, 5:37 AM

Oops

J

j0rge•3/4/23, 5:37 AM

lol

J

j0rge•3/4/23, 5:38 AM

deleting packages is annoying too

J

j0rge•3/4/23, 5:40 AM

done

J

jstone•3/4/23, 5:40 AM

ty

J

j0rge•3/4/23, 5:40 AM

ready to merge the fix then?

J

jstone•3/4/23, 5:41 AM

Is

"org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

"org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

"org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added",

"org.opencontainers.image.description": "ublue-os $IMAGE_NAME with Nvidia drivers added", intentional?

J

j0rge•3/4/23, 5:41 AM

yeah it's so the description can match each image

J

jstone•3/4/23, 5:41 AM

Not sure if that's just how it looks in the CI or there's some substitution going on elsewhere

J

jstone•3/4/23, 5:41 AM

Gotcha

J

jstone•3/4/23, 5:44 AM

Looks like the nvidia repo has crossed 10K downloads

J

jstone•3/4/23, 5:58 AM

I wonder what we could put in an -amd image. So far it looks like adding ROCm packages will add about 550M, which should justify having an image of its own

J

j0rge•3/4/23, 6:03 AM

J

j0rge•3/4/23, 6:03 AM

lol

J

jstone•3/4/23, 6:08 AM

Oh boy

X

xyny•3/4/23, 6:10 AM

hah

J

j0rge•3/4/23, 6:10 AM

yeah all the images have that in the metadata now

J

j0rge•3/4/23, 6:11 AM

but that can wait, night all!

K

Kyle Gospo•3/4/23, 10:02 AM

@j0rge https://copr.fedorainfracloud.org/coprs/kylegospo/hl2linux-selinux/

K

Kyle Gospo•3/4/23, 10:02 AM

Something new we may want to potentially add to ublue, perhaps in the udev package

K

Kyle Gospo•3/4/23, 10:03 AM

SELinux policy specifically for missing audio in Team Fortress 2

X

xyny•3/4/23, 10:13 AM

hoohhhh I have write access in ublue-os/website? well I just pushed some docs updates to it.

X

xyny•3/4/23, 10:13 AM

https://ublue.it/structure/

X

xyny•3/4/23, 11:01 AM

I went and made a startingpoint repo https://github.com/ublue-os/startingpoint

GitHub

GitHub - ublue-os/startingpoint: Starting point for making your own...

Starting point for making your own OS image (WIP). Contribute to ublue-os/startingpoint development by creating an account on GitHub.

X

xyny•3/4/23, 11:01 AM

lazy concencus

lazy concencus

lazy concencus

lazy concencus yehh

X

xyny•3/4/23, 11:07 AM

I'll document the containerfile extensively

J

j0rge•3/4/23, 2:39 PM

@hermmm "Architecture" would be better instead of structure

J

j0rge•3/4/23, 2:39 PM

that's our architecture diagram

Jj0rge @hermmm "Architecture" would be better instead of structure

X

xyny•3/4/23, 2:39 PM

Y'aright I'll change it

J

j0rge•3/4/23, 2:39 PM

I'

J

j0rge•3/4/23, 2:40 PM

I'm confused what startingpoint is for?

C

ChaiQi•3/4/23, 2:40 PM

I am also confused

C

ChaiQi•3/4/23, 2:41 PM

Main is specifically meant for creating images from, no?

J

j0rge•3/4/23, 2:41 PM

right, that's why it's a template

J

j0rge•3/4/23, 2:42 PM

@.jstone good call on that aptX thing, I did a search and the things people gotta do to make their headphones work. It's that kind of absurd toil that can just go away

Jj0rge right, that's why it's a template

X

xyny•3/4/23, 2:42 PM

I thought'd be a bit stupid to have both the common upstream image for including common qol and the downest downstream image intended for total customization be both the same repository and codebase.

X

xyny•3/4/23, 2:43 PM

Really all what startingpoint needs is the basic template for Making Your Own

J

j0rge•3/4/23, 2:44 PM

ok let's please not use words like stupid when referring to the stuff we're making.

X

xyny•3/4/23, 2:44 PM

When the Main docs talk about it's main function it's pretty confusing for someone just wanting to step into this and wanting to layer some packages in a native container

Jj0rge ok let's please not use words like stupid when referring to the stuff we're maki...

X

xyny•3/4/23, 2:44 PM

well i'll say not-smart then

C

ChaiQi•3/4/23, 2:44 PM

The total customization template is also just about the furthest possible upstream, not "downest downstream"

J

j0rge•3/4/23, 2:45 PM

let's just say WIP lol

CChaiQi The total customization template is also just about the furthest possible upstre...

X

xyny•3/4/23, 2:45 PM

Well, it's a template. It's not intended to be an image by itself but something that is used for you to make your own image based on the uBlue efforts.

C

ChaiQi•3/4/23, 2:46 PM

?
The template is and has to be a functional image

<https://docs.github.com/en/actions/learn-github-actions/contexts#github-context>

Similar Threads

Similar Threads

Similar Threads