I'm just going to do it all in the justfile. If people here cannot get it working, there's no use m

I'm just going to do it all in the justfile. If people here cannot get it working, there's no use me trying.
It'll be an extra step - running

just setup

just setup

or something, but I guess it'll only be me using it.

Any way of setting the system-wide default just recipe? At the minute, I must
cd
cd
to
/etc/
/etc/
in order to call it Cannot find anything in the docs, so I don't think it exists

Jj0rge file an issue in main, there's a template form you can fill out

ChaiQi•3/5/23, 12:38 AM

Done, good pointer, good template

RRobert I'm just going to do it all in the justfile. If people here cannot get it worki...

j0rge•3/5/23, 12:42 AM

yeah that's what I've been doing on mine, hopefully we'll get it sorted soon

j0rge•3/5/23, 12:51 AM

ok I keep missing PRs so I added a link to the open PRs across the org to the topic, so you can always click on there and help out: https://github.com/pulls?user=ublue-os ... reviews appreciated, even if you don't have write access every pair of eyes helps and it helps the next reviewer when multiple people have given things a once over.

j0rge•3/5/23, 12:52 AM

@.jstone sorry the timer PR got missed, I acked it just now, but now that we have a link we can check everyday.

Kyle Gospo•3/5/23, 12:56 AM

What's needed to fix signing for images?

Kyle Gospo•3/5/23, 12:56 AM

Missed that convo I think

j0rge•3/5/23, 12:56 AM

the cosign bits?

Kyle Gospo•3/5/23, 12:57 AM

Bazzite is failing to build with the same consign step that's in the main image atm

j0rge•3/5/23, 12:57 AM

https://github.com/ublue-os/main/blob/1df3593bc942c8dc2a685188805111e5672f28f3/.github/workflows/build.yml#L168

GitHub

main/build.yml at 1df3593bc942c8dc2a685188805111e5672f28f3 · ublue-...

An OCI base image of Fedora with batteries included - main/build.yml at 1df3593bc942c8dc2a685188805111e5672f28f3 · ublue-os/main

j0rge•3/5/23, 12:57 AM

this is what you need

j0rge•3/5/23, 12:58 AM

and if you look at line 160 we're pinned to 3.0.1 right now, so updates will get a dependabot alert so we can vet it before committing

Kyle Gospo•3/5/23, 12:58 AM

That's what I copied from, just the bits after the #sign comment

j0rge•3/5/23, 12:58 AM

you'll need that change too

Kyle Gospo•3/5/23, 12:58 AM

Checking

j0rge•3/5/23, 1:02 AM

Main:

cosign sign -y --key cosign.key ${{ steps.registry_case.outputs.lowercase }}/${{ env.IMAGE_NAME }}@${TAGS}

cosign sign -y --key cosign.key ${{ steps.registry_case.outputs.lowercase }}/${{ env.IMAGE_NAME }}@${TAGS}

j0rge•3/5/23, 1:02 AM

Bazzite:

cosign sign -y --key cosign.key ${{ steps.registry_case.outputs.lowercase }}/${{ steps.build_image.outputs.image }}@${TAGS}

cosign sign -y --key cosign.key ${{ steps.registry_case.outputs.lowercase }}/${{ steps.build_image.outputs.image }}@${TAGS}

j0rge•3/5/23, 1:03 AM

that has to be it, everything else is the same afaict?

Kyle Gospo•3/5/23, 1:03 AM

Ty, just pushed that now

j0rge•3/5/23, 1:04 AM

we need to think of a smarter way to snag updated actions from main

j0rge•3/5/23, 1:04 AM

I had to do the same thing for my image, etc.

Kyle Gospo•3/5/23, 1:04 AM

That's a tough one, bazzite in particular needs customizations made

Kyle Gospo•3/5/23, 1:05 AM

Since it's building two images

j0rge•3/5/23, 1:05 AM

yeah, I am hoping the actions will churn less, I suspect once we get a full cycle in (37 -> 38) we'll shake out more issues

Kyle Gospo•3/5/23, 1:07 AM

That'll be nice. Ty for the help

Marco (马可)•3/5/23, 1:33 AM

I’m going to build a few custom actions this evening to take a break from yafti. Co-sign is the first on my list

Marco (马可)•3/5/23, 1:34 AM

I’m about to push screen state to yafti. Only one item outstanding for v1

j0rge•3/5/23, 2:22 AM

dude this is awesome

j0rge•3/5/23, 2:22 AM

you think cosign is easier than the iso making one?

j0rge•3/5/23, 2:22 AM

I feel like the iso making one is easier than we think it is

RobertOP•3/5/23, 2:25 AM

I feel like the iso making one is easier than we think it is

It's just a single reusable GHA workflow, right?
Trigger on:

workflow_call

workflow_call

Steps:

Checkout
Install Fedora Installer
Execute mkksiso command
Cosign (will be reusable soon)
Publish image

It'll be different to the others - this would be a reusable workflow, whereas something like Cosign would be a reusable action

j0rge•3/5/23, 2:25 AM

https://github.com/ublue-os/isogenerator

GitHub

GitHub - ublue-os/isogenerator: An action to generate custom ISOs o...

An action to generate custom ISOs of OCI images. Contribute to ublue-os/isogenerator development by creating an account on GitHub.

j0rge•3/5/23, 2:26 AM

I made a repo for whoever wants to take a stab at it

j0rge•3/5/23, 2:26 AM

and wrote down how I was able to make one locally

RobertOP•3/5/23, 2:27 AM

I might give it a go tomorrow if nobody has picked it up by then.
I feel the GHA stuff should be easy, but actually building the ISO will be the difficult bit for me - since I've never done it

j0rge•3/5/23, 2:31 AM

yeah that command they made, it does it all for you

j0rge•3/5/23, 2:34 AM

at first I was doing it with this lorax thing

j0rge•3/5/23, 2:34 AM

and then I tried this and it worked immediately

j0rge•3/5/23, 2:34 AM

and the best part is they make daily builds of anaconda, so the day oci support lands, we'll have isos that night!

j0rge•3/5/23, 2:34 AM

(assuming it works as it's intended lol)

Marco (马可)•3/5/23, 2:35 AM

@_p5 isogenerator would still be an action, probably not a reusable workflow. A parameterized action setup that can be included by any workflow with inputs to customize an iso output

Marco (马可)•3/5/23, 2:36 AM

I'm going to build the cosign one now. Happy to let you have a go at isogenerator

RobertOP•3/5/23, 2:39 AM

FYI - I will be working here
https://github.com/ublue-os/isogenerator/pull/1

Will carry on with it tomorrow.

RobertOP•3/5/23, 2:44 AM

QQ: Would it be possible to become a maintainer in the experimental repo? I think it would be useful to test with this since it's already got the release-please action.
Also this PR will require a maintainer to one of the repos to test since it will need write access for publishing and updating a release.

Marco (马可)•3/5/23, 2:46 AM

@_p5 I can add you to experimental

Bigpod•3/5/23, 11:43 AM

imo it would make sense for it to be an action not just a workflow

RobertOP•3/5/23, 12:29 PM

Will the kickstart file be the same for all images/repos?

Bigpod•3/5/23, 12:34 PM

Bigpod•3/5/23, 12:35 PM

afaik only thing kickstart file actually does is tell what image you want

RobertOP•3/5/23, 12:35 PM

Ok. So I'll assume each repo will bring their own *.ks file

Bigpod•3/5/23, 12:36 PM

i think that should be correct @j0rge correct me if im wrong

I'm just going to do it all in the justfile. If people here cannot get it working, there's no use m

Similar Threads

Similar Threads

Similar Threads