So just so I'm clear, for example https://webstudio.is/build/entry.client-QHBMJZIF.js is taking 137m

Bbeelzabub So just so I'm clear, for example https://webstudio.is/build/entry.client-QHBMJZ...

O

Oleg Isonen•3/15/23, 4:49 PM

yes!

B

beelzabubOP•3/15/23, 5:02 PM

So looking at our backend, it looks like there's no KV asset for that file. It looks like you might be trying to put cache in front of KV but then forgetting to update KV on a miss?

I

Ivan Starkov•3/15/23, 5:13 PM

Its worker for platform, it has following code.

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

      // @todo the whole logic looks strange, add test, write what it solves
      if (asset) {
        finalRequest = new Request(
          url.origin + "/" + asset,
          request as RequestInit
        );
      }

      const response = await getAssetFromKV(
        {
          request: finalRequest,
          waitUntil(promise) {
            return ctx.waitUntil(promise);
          },
        },
        {
          ASSET_NAMESPACE: env.__STATIC_CONTENT,
          ASSET_MANIFEST: assetManifest,
          cacheControl: {
            browserTTL: ttl,
            edgeTTL: ttl,
          },
        }
      );

      return response;

KV is created by using

[site]
bucket = "./public"

[site]
bucket = "./public"

[site]
bucket = "./public"

[site]
bucket = "./public"

section in toml file
and exists and filled

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

4453161ad26e32a617c6c6d4b837c9d9/workers/kv/namespaces/989796259c334124b2e868bd9a0c3849

I

Ivan Starkov•3/15/23, 5:15 PM

This library https://github.com/cloudflare/kv-asset-handler std code is used for static assets hosting

I

Ivan Starkov•3/15/23, 5:17 PM

timings are very unstable and sometimes can be very good

I

Ivan Starkov•3/15/23, 5:17 PM

But next reload

I

Ivan Starkov•3/15/23, 5:17 PM

I

Ivan Starkov•3/15/23, 5:17 PM

Font timing (r2 with cache rule) is independent

B

beelzabubOP•3/15/23, 5:18 PM

That library seems to have a lot of magic and I've never looked at it before

O

Oleg Isonen•3/15/23, 5:20 PM

The weird thing is that R2 has consistently good timing. Should we put everything in R2 then?

B

beelzabubOP•3/15/23, 5:20 PM

No. I'd recommend using KV properly

I

Ivan Starkov•3/15/23, 5:21 PM

Can it be because of worker is blocked by some heavy script, like first request is coming and cause some heavy job on worker - really 100-200ms computation, and consequent requests are waiting for worker finish that task?

B

beelzabubOP•3/15/23, 5:21 PM

No

B

beelzabubOP•3/15/23, 5:21 PM

The problem is that that kv-asset-handler is doing a lot of complicated things more than just hitting KV

B

beelzabubOP•3/15/23, 5:21 PM

It's using cache in front of KV and trying to honor caching headers from the origin afaict.

B

beelzabubOP•3/15/23, 5:22 PM

Any one of those things could be tripping you up in theory

B

beelzabubOP•3/15/23, 5:22 PM

Try disabling

shouldEdgeCache

shouldEdgeCache

shouldEdgeCache

shouldEdgeCache in your options and see if that fixes it

I

Ivan Starkov•3/15/23, 5:23 PM

Trying

B

beelzabubOP•3/15/23, 5:23 PM

I think you do that by eliding ASSET_MANIFEST

B

beelzabubOP•3/15/23, 5:24 PM

(i.e. setting it to undefined)

I

Ivan Starkov•3/15/23, 5:27 PM

Seems like this https://github.com/cloudflare/kv-asset-handler/blob/c198236dc7444f99acad1f8ccffa2532b8fda879/src/index.ts#L227 i.e. bypassCache also set shouldEdgeCache=false

B

beelzabubOP•3/15/23, 5:28 PM

Yeah maybe

B

beelzabubOP•3/15/23, 5:30 PM

@cherryjimbo might know more about the specifics of this library as he seems to be the primary maintainer.

I

Ivan Starkov•3/15/23, 5:38 PM

Tried with cache bypass, seems like become worse but hard to say. Like 30/60ms worse

B

beelzabubOP•3/15/23, 5:39 PM

Can you try without that library at all?

I

Ivan Starkov•3/15/23, 5:41 PM

For me it looks like highlu correlated with 2nd request we have

I

Ivan Starkov•3/15/23, 5:41 PM

If it came from cache everything else is fast, KV etc

B

beelzabubOP•3/15/23, 5:41 PM

That library is doing too many fancy things. If KV is your source of truth, you can just read from it and set whatever cache control headers you need (e.g. you can store it within the KV metadata if you need to customize).

I

Ivan Starkov•3/15/23, 5:41 PM

If it calculated (and its really heavy on calulation) everything from KV is slow

J

James•3/15/23, 5:43 PM

Sorry I’m on mobile so can’t help too much at the moment, but kv-asset-handler shouldn’t be that far off normal KV performance. It uses

cache

cache

cache

cache manually though

I

Ivan Starkov•3/15/23, 5:56 PM

I disabled heavy script and have same results for all requests

I

Ivan Starkov•3/15/23, 5:56 PM

B

beelzabubOP•3/15/23, 5:57 PM

What do you mean by "heavy script"?

I

Ivan Starkov•3/15/23, 5:57 PM

So it looks like we have single worker which does not process KV until heavy work on requested script

I

Ivan Starkov•3/15/23, 5:57 PM

Heavy - heavy in computation like 200ms to compute response

I

Ivan Starkov•3/15/23, 5:58 PM

?css-hash

?css-hash

?css-hash

?css-hash in screenshots above

B

beelzabubOP•3/15/23, 5:59 PM

?css-hash in the last screenshot shows 41ms

B

beelzabubOP•3/15/23, 5:59 PM

So not disabled?

I

Ivan Starkov•3/15/23, 5:59 PM

I disabled generation inside and everything become works well

I

Ivan Starkov•3/15/23, 5:59 PM

Something left but small like return new Response ("")

B

beelzabubOP•3/15/23, 5:59 PM

Is that asset being generated dynamically instead of from KV?

I

Ivan Starkov•3/15/23, 6:00 PM

Yep that single asset was geerated dynamically

I

Ivan Starkov•3/15/23, 6:00 PM

all others are not

B

beelzabubOP•3/15/23, 6:00 PM

I don't think that fully explains it though as requests to independent assets should be unique parallelized requests.

I

Ivan Starkov•3/15/23, 6:01 PM

But that looks like requests to a single worker. Probably because we are using saas workers

B

beelzabubOP•3/15/23, 6:01 PM

I don't think I follow.

I

Ivan Starkov•3/15/23, 6:02 PM

There are workers for Platforms https://developers.cloudflare.com/cloudflare-for-platforms/workers-for-platforms/

I

Ivan Starkov•3/15/23, 6:03 PM

To call such worker additional worker with dispatch is used i.e.

const userWorker = env.dispatcher.get(workerName);
return await userWorker.fetch(request);

const userWorker = env.dispatcher.get(workerName);
return await userWorker.fetch(request);

const userWorker = env.dispatcher.get(workerName);
return await userWorker.fetch(request);

const userWorker = env.dispatcher.get(workerName);
return await userWorker.fetch(request);

I

Ivan Starkov•3/15/23, 6:04 PM

May be such workers don't work in parallel or dispatch somehow serializing calls, I don't know.

B

beelzabubOP•3/15/23, 6:13 PM

That shouldn't matter because your dispatcher is still receiving a request. There's no serialization of requests within the runtime.

So just so I'm clear, for example https://webstudio.is/build/entry.client-QHBMJZIF.js is taking 137m

Similar Threads

Similar Threads

Similar Threads