holy crap that git history was a challenge to wrangle
holy crap that git history was a challenge to wrangle
Pok cool, no new errors or even obsolete warnings in migrating Ryujinx to 2.17.0-build3299.0
Pnow for stride
Pok stride wasn't too bad either (they hadn't upgraded to 2.16 yet) but i can't build the whole thing
Pso far i can only find 3 things worth flagging up in "migration guidance":
- system.memory has been updated which if you reference it explicitly in your project will also need updating
- in the 2.16 update we added obsolete warnings to a lot of needlessly verbose enum names
- we have removed some overloads that are causing widespread confusion and misuse in the current silk.net versions - if you need to make changes as a result of this update, your existing code is either broken or more verbose than it needs to be.
Lyeah ill probably go through and manually merge, reorder, cleanup and fix the git history
Lits a bit of a mess from the rebases
Land yeah given all the circular dependencies, we should definitely merge D2D, DWrite, and WIC
Lits quite the Mess
L@Perksey how would we go about merging them? we cant just make one profile use all source files since to my knowledge we cant have multiple prefixes
Ldo we just have all the profiles output to the same folder?
Plook at how the compilers do it
Pdxc and d3dcompiler are in the same project
Loh
Pand then we'll just have to have a bunch of manual typemapping/exclusions unfortunately
Lfun
Lif we are gonna have typemapping anyway, might as well just manually typemap all the things together, and manually have all the projects include all the other relavent ones
LC# doesnt like circular project dependencies, but i think it still builds if you have them
Pti deoesn't
Ldamn
Lwell ill try to make this not So Bad and not cause Too Many headaches
Ld3dcompiler and dxc did this in a slightly more Annoying way where you made them share the same folderspace, so im going to make them Not Do That and have DWrite be a subdir of D2D (with no DWrite csproj), so the files dont overlap, since we need the typemaps and exclusions anyway, this just makes things slightly cleaner, without actually effecting the output assemblies in any way
Lyay for namespace != folder path
Pyeah that makes sense
Li was in the middle of typing thank you very much
Li think WIC can be solved in a future PR, perhaps after 2.17 launches so we dont delay it?
Lsince once we add WIC bindings ittl only add the new overloads it wont be a breaking change
Pif we're definitely putting it in the Direct2D package then yeah it should be fine
Lcool
Lill add the missing windows headers
Lhmm yeah adding those headers didnt help wait its the header order isnt it
Loh wait no some overloads lit up with the header order changed
Lbut not all
Loh it is in shared, weird it didnt cause an error when generating
Li would have expected it to
Lwhat does "traverse" even mean?
P"traverse" means "please add the symbols found in these headers to the profile"
Lah
Lhm
Pneeds more headers
P"looks like it needs more mud"
Lwow thats a lot of stuff from one header
Pdon't forget to rename the tag* structs to sensible names lol
Li also need
wtypes.h now wow this is header whackamoleLone missing header added and 2 more are needed
Li think im maybe hitting a generator bug now? not sure
Lnot generating types that do exist
L
Lthis is in wtypes.h
Lwait the type is being generated
Lbut