Cloudflare Developers•3y ago

you should be able to copy it out of there

dave•4/18/23, 6:00 PM

fudge

dave•4/18/23, 6:00 PM

I missed it

EErisa you should be able to copy it out of there

dave•4/18/23, 6:32 PM

I blame using an Apple Watch again for reading emails

chientrm.com•4/19/23, 5:35 AM

wrangler dev

wrangler dev

not usable every day at lunch time. Keep hanging connection

Alisson Acioli•4/19/23, 12:32 PM

Hello, a question about redirection in workers.

I'm trying to do a redirect like this:

return new Response.redirect('https://www.mywebsite.com', 307);

but it is not redirecting. Is there a different way or is my code wrong to redirect from the worker?

sakuta•4/19/23, 12:35 PM

return new Response(null, {
  status: 307, // temporary redirect
  headers: {
    location: 'https://...'
  }
})

return new Response(null, {
  status: 307, // temporary redirect
  headers: {
    location: 'https://...'
  }
})

sakuta•4/19/23, 12:35 PM

@alissonacioli that's not worker-specific, rather web standard

kian•4/19/23, 12:35 PM

remove the newnew before Response.redirectResponse.redirect

kian•4/19/23, 12:35 PM

it's a static method, not a constructor

kian•4/19/23, 12:36 PM

https://developer.mozilla.org/en-US/docs/Web/API/Response/redirect

Alisson Acioli•4/19/23, 1:40 PM

worked

Alisson Acioli•4/19/23, 1:40 PM

tanks

kian•4/19/23, 2:49 PM

What is your existing code?

kian•4/19/23, 3:48 PM

You're sending a JSON body from FormData, but is your origin expecting JSON?

kian•4/19/23, 5:03 PM

It doesn't look like the body is being used other than to send it on with

fetch

fetch

so the entire thing could be simplified down to

export default {
  fetch(req) {
    return fetch("http://localhost:9000/", req);
  }
}

export default {
  fetch(req) {
    return fetch("http://localhost:9000/", req);
  }
}

kian•4/19/23, 5:04 PM

You can adapt it as necessary if you want to implement decisions on where to send traffic based on the path, but there's no need to touch the body or headers.

kian•4/19/23, 5:04 PM

Just pass the original reqreq object as the second argument to

fetch

fetch

kian•4/19/23, 5:22 PM

That isn't touching the response body at all - what's the full error output?

dave•4/19/23, 5:27 PM

@Erisa | Support Engineer if I get a Ray ID from an error happening in my account, is that enough to get a trace?

Walshy•4/19/23, 6:12 PM

Erisa is OOO but not really

dave•4/19/23, 6:20 PM

yeah I didn't buy it tbh ;P

Walshy•4/19/23, 9:28 PM

#general-discussions

AAkarys What would be the best way to do that?

Hello, I’m Allie!•4/20/23, 11:07 AM

Give the team read-access to the repository?

AAkarys that doesn't prove someone from infra didn't inject code into the worker that's ...

Hello, I’m Allie!•4/20/23, 11:11 AM

Maybe have a service that runs the API call?

Hello, I’m Allie!•4/20/23, 11:12 AM

If the deployment runs in Actions, you could probably just let them inspect the repo, since any steps taken to inject something into the script would also show up in the repo

Hello, I’m Allie!•4/20/23, 11:13 AM

And also because most Workers are very difficult to inspect once they are deployed, since they may be minified, include a D1 stub, have random patches of binary, etc

Hello, I’m Allie!•4/20/23, 11:13 AM

So it might be more efficient to audit the pipeline and the source, rather than trying to audit the built output

AAkarys aren't worker builds reproducible?

Hello, I’m Allie!•4/20/23, 11:17 AM

Not without the build pipeline

Hello, I’m Allie!•4/20/23, 11:17 AM

You can probably guess at what dependencies were used

Hello, I’m Allie!•4/20/23, 11:17 AM

But for stuff like WebAssembly, it would be very difficult to reverse without the source

AAkarys I am OK with having the worker use a specific type if it means it is reproducibl...

Hello, I’m Allie!•4/20/23, 11:19 AM

I’m not sure what you mean, “a specific type”?

AAkarys I mean barebone JS vs webpack vs webassembly, etc..

Hello, I’m Allie!•4/20/23, 11:25 AM

I mean, it’s not so much that. It is more that it is a lot easier to audit a Worker when it is split into multiple files, the function/variable names are intact, etc. Most build tools minify your script, since JS runtimes don’t actually care about the names of stuff, but that means it is much harder for a human to read

Hello, I’m Allie!•4/20/23, 11:25 AM

And not using said build tools greatly reduces the amount of work you can do with a single Worker

you should be able to copy it out of there

Similar Threads