Wait whats your spec looking like right

Arcitec · 2023-05-12T18:35:50.322Z

Wait, whats your spec looking like right now? You should `%global` the variable first in the top section and then use that variable later.

B

bsherman•5/12/23, 6:36 PM

lets thread

A

ArcitecOP•5/12/23, 6:36 PM

Yeah

B

bsherman•5/12/23, 6:36 PM

this is getting busy

A

ArcitecOP•5/12/23, 6:36 PM

https://src.fedoraproject.org/rpms/sil-charis-fonts/blob/f38/f/sil-charis-fonts.spec

A

ArcitecOP•5/12/23, 6:36 PM

This is how they define using the longform, they do a similar thing to what we need. Cutting out a part of a word.

B

bsherman•5/12/23, 6:37 PM

snippets of known file

ublue-os-update-services.spec

ublue-os-update-services.spec

ublue-os-update-services.spec

ublue-os-update-services.spec

Source0:        ublue-os-update-services.tar.gz

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%-os%-", ""); print(t)}

%description
Adds systemd units and configuration files for enabling automatic updates in rpm-ostree and

Source0:        ublue-os-update-services.tar.gz

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%-os%-", ""); print(t)}

%description
Adds systemd units and configuration files for enabling automatic updates in rpm-ostree and

Source0:        ublue-os-update-services.tar.gz

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%-os%-", ""); print(t)}

%description
Adds systemd units and configuration files for enabling automatic updates in rpm-ostree and

Source0:        ublue-os-update-services.tar.gz

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%-os%-", ""); print(t)}

%description
Adds systemd units and configuration files for enabling automatic updates in rpm-ostree and

and...

%files
%dir %attr(0755,root,root) %{_datadir}/%{VENDOR}/%{project_name}
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system-preset/10-flatpak-system-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user-preset/10-flatpak-user-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_sysconfdir}/rpm-ostreed.conf

%files
%dir %attr(0755,root,root) %{_datadir}/%{VENDOR}/%{project_name}
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system-preset/10-flatpak-system-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user-preset/10-flatpak-user-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_sysconfdir}/rpm-ostreed.conf

%files
%dir %attr(0755,root,root) %{_datadir}/%{VENDOR}/%{project_name}
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system-preset/10-flatpak-system-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user-preset/10-flatpak-user-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_sysconfdir}/rpm-ostreed.conf

%files
%dir %attr(0755,root,root) %{_datadir}/%{VENDOR}/%{project_name}
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system-preset/10-flatpak-system-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/system/flatpak-system-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user-preset/10-flatpak-user-update.preset
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.service
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_exec_prefix}/lib/systemd/user/flatpak-user-update.timer
%attr(0644,root,root) %{_datadir}/%{VENDOR}/%{project_name}/%{_sysconfdir}/rpm-ostreed.conf

A

ArcitecOP•5/12/23, 6:37 PM

Hmm maybe put %global above the source like they did, right below all the standardized Name: etc.

A

ArcitecOP•5/12/23, 6:38 PM

You can use https://pb.envs.net btw

B

bsherman•5/12/23, 6:38 PM

fair

B

bsherman•5/12/23, 6:38 PM

location if global should be fine... that location with shorthand gsub was creating garbage values in the variable

A

ArcitecOP•5/12/23, 6:38 PM

When you used

${gsub

${gsub

${gsub

${gsub then the variable literally became the word gsub right?

B

bsherman•5/12/23, 6:39 PM

yeah like

error: Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/%{gsub:"ublue-os-update-services":"^ublue":""}

error: Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/%{gsub:"ublue-os-update-services":"^ublue":""}

error: Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/%{gsub:"ublue-os-update-services":"^ublue":""}

error: Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/%{gsub:"ublue-os-update-services":"^ublue":""}

A

ArcitecOP•5/12/23, 6:39 PM

Seems to me like gsub macro shorthand isn't implemented and the docs are old/wrong or maybe even for a newer version than waht Fedora uses

B

bsherman•5/12/23, 6:39 PM

i think the longhand is close, just missing the match

A

ArcitecOP•5/12/23, 6:39 PM

Yeah

A

ArcitecOP•5/12/23, 6:39 PM

The match is tricky, I am guessing the % gets interpreted before passing in

A

ArcitecOP•5/12/23, 6:39 PM

I think we need to escpe the %, try the usual things, first

%%

%%

%%

%% then

\%

\%

\%

\%

B

bsherman•5/12/23, 6:40 PM

yep, was just thinking the same

A

ArcitecOP•5/12/23, 6:40 PM

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%%-os%%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue\%-os\%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%%-os%%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue\%-os\%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%%-os%%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue\%-os\%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue%%-os%%-", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "^ublue\%-os\%-", ""); print(t)}

B

bsherman•5/12/23, 6:41 PM

neither

B

bsherman•5/12/23, 6:41 PM

hmm

A

ArcitecOP•5/12/23, 6:41 PM

Okay try this

%global project_name       %{lua:t=string.gsub("%{NAME}", "ublue", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "ublue", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "ublue", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}", "ublue", ""); print(t)}

Just to see what it does

B

bsherman•5/12/23, 6:42 PM

ok, somethings wrong

    Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-services

    Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-services

    Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-services

    Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-services

B

bsherman•5/12/23, 6:42 PM

using a simple "ublue" match should have at least changed that output

A

ArcitecOP•5/12/23, 6:43 PM

Yeah that's really mysterious

A

ArcitecOP•5/12/23, 6:43 PM

We're basically the same as fedora's own spec now

A

ArcitecOP•5/12/23, 6:43 PM

Can you post the full file on https://pb.envs.net ?

A

ArcitecOP•5/12/23, 6:47 PM

I saw from what you posted that you're using

%{project_name}

%{project_name}

%{project_name}

%{project_name} in the paths though so that's correct.

And the longform we are usign is identical to what Fedora uses, including the fact that

""

""

works inside

string.gsub()

string.gsub()

string.gsub()

string.gsub()... :/

https://src.fedoraproject.org/rpms/sil-charis-fonts/blob/f38/f/sil-charis-fonts.spec

A

ArcitecOP•5/12/23, 6:48 PM

Hmm

A

ArcitecOP•5/12/23, 6:48 PM

@bsherman What happens if you do this?

%global project_name       %{lua:t=string.gsub("%{NAME}FOO", "ublue", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}FOO", "ublue", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}FOO", "ublue", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}FOO", "ublue", ""); print(t)}

A

ArcitecOP•5/12/23, 6:49 PM

Does it at least add a foo to prove that it's doing anything at all?

B

bsherman•5/12/23, 6:51 PM

sorry, had to step away... i'm being loose with actual work today, but have to address a couple questions

B

bsherman•5/12/23, 6:51 PM

one sec and i'll test that

A

ArcitecOP•5/12/23, 6:52 PM

You know, the worst case scenario is that something is wrong with our RPM builder if it can't run Lua. In that case, a pure plaintext solution would be something like:

Name:           ublue-os-update-services
%global shared_data_dir  update-services

Name:           ublue-os-update-services
%global shared_data_dir  update-services

Name:           ublue-os-update-services
%global shared_data_dir  update-services

Name:           ublue-os-update-services
%global shared_data_dir  update-services

I am fairly sure globals can be defined anywhere in that top section, so keeping it next to name would work. I have seen people put %globals at the literal first line of the file.

AArcitec Does it at least add a foo to prove that it's doing anything at all?

B

bsherman•5/12/23, 6:57 PM

foo is in the result here

A

ArcitecOP•5/12/23, 6:57 PM

Ah, so it definitely ran the Lua and ran gsub with a parameter that was "projectnameFOO", and ended up with that in the output path, yeah?

A

ArcitecOP•5/12/23, 6:57 PM

Then why the heck isn't it replacing anything. It's the simplest string possible...

AArcitec Ah, so it definitely ran the Lua and ran gsub with a parameter that was "project...

B

bsherman•5/12/23, 6:58 PM

yup

Bbsherman yup

A

ArcitecOP•5/12/23, 6:58 PM

I ran this in real lua:

string.gsub("ublue-os-startup-scriptsFOO", "ublue", "")


-os-startup-scriptsFOO    1

string.gsub("ublue-os-startup-scriptsFOO", "ublue", "")


-os-startup-scriptsFOO    1

string.gsub("ublue-os-startup-scriptsFOO", "ublue", "")


-os-startup-scriptsFOO    1

string.gsub("ublue-os-startup-scriptsFOO", "ublue", "")


-os-startup-scriptsFOO    1

A

ArcitecOP•5/12/23, 6:58 PM

That's what we should have gotten. But your result didn't replace the ublue?

B

bsherman•5/12/23, 6:59 PM

right, i got "ublue-os-update-servicesfoo"

B

bsherman•5/12/23, 6:59 PM

(i used lowercase)

B

bsherman•5/12/23, 6:59 PM

i'm reading docs again myself, a moment plz

A

ArcitecOP•5/12/23, 6:59 PM

Okay, it makes no sense to me that it's literally runnign the lua, literally running the function, but getting no replacements.

A

ArcitecOP•5/12/23, 7:00 PM

We're calling string.gsub the same way Fedora calls it themselves in their spec

A

ArcitecOP•5/12/23, 7:01 PM

If you wanna try one more thing, try:

%global project_name       %{lua:t=string.gsub("%{NAME}bar", "b", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}bar", "b", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}bar", "b", ""); print(t)}

%global project_name       %{lua:t=string.gsub("%{NAME}bar", "b", ""); print(t)}

Literally one letter replacement.

B

bsherman•5/12/23, 7:01 PM

that worked

A

ArcitecOP•5/12/23, 7:01 PM

As a reminder, Fedora does:

%global archivename       %{lua:t=string.gsub(rpm.expand("%{fontfamily}"), "[%p%s]+", ""); print(t)}-%{version}

%global archivename       %{lua:t=string.gsub(rpm.expand("%{fontfamily}"), "[%p%s]+", ""); print(t)}-%{version}

%global archivename       %{lua:t=string.gsub(rpm.expand("%{fontfamily}"), "[%p%s]+", ""); print(t)}-%{version}

%global archivename       %{lua:t=string.gsub(rpm.expand("%{fontfamily}"), "[%p%s]+", ""); print(t)}-%{version}

B

bsherman•5/12/23, 7:01 PM

 Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-servicesar

 Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-servicesar

 Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-servicesar

 Directory not found: /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-update-services-0.3-1.fc38.x86_64/usr/share/ublue-os/ublue-os-update-servicesar

B

bsherman•5/12/23, 7:02 PM

yeah, so we shouldn't need the expand, because that's expanding a macro

Wait whats your spec looking like right

Similar Threads

Similar Threads

Similar Threads