Problem saving data 2 times in 1 request

When I send a request 1 time to an index.html file that says hello world, the data KV is recorded 2 times, how can I solve this problem?

async function handleRequest(request) {
  // Get the IP address of the incoming user from the request headers
  const ip = request.headers.get("CF-Connecting-IP");
  
  // Generate a 3-digit key
  const key = Math.random().toString().slice(2, 5);
  
  // Save the data to the KV namespace using the generated key
  await LOG_IP.put(`${ip}<${key}`, 8);
  
  // Return the original request
  return fetch(request);
}

addEventListener("fetch", (event) => {
  event.respondWith(handleRequest(event.request));
});

async function handleRequest(request) {
  // Get the IP address of the incoming user from the request headers
  const ip = request.headers.get("CF-Connecting-IP");
  
  // Generate a 3-digit key
  const key = Math.random().toString().slice(2, 5);
  
  // Save the data to the KV namespace using the generated key
  await LOG_IP.put(`${ip}<${key}`, 8);
  
  // Return the original request
  return fetch(request);
}

addEventListener("fetch", (event) => {
  event.respondWith(handleRequest(event.request));
});

async function handleRequest(request) {
  // Get the IP address of the incoming user from the request headers
  const ip = request.headers.get("CF-Connecting-IP");
  
  // Generate a 3-digit key
  const key = Math.random().toString().slice(2, 5);
  
  // Save the data to the KV namespace using the generated key
  await LOG_IP.put(`${ip}<${key}`, 8);
  
  // Return the original request
  return fetch(request);
}

addEventListener("fetch", (event) => {
  event.respondWith(handleRequest(event.request));
});

async function handleRequest(request) {
  // Get the IP address of the incoming user from the request headers
  const ip = request.headers.get("CF-Connecting-IP");
  
  // Generate a 3-digit key
  const key = Math.random().toString().slice(2, 5);
  
  // Save the data to the KV namespace using the generated key
  await LOG_IP.put(`${ip}<${key}`, 8);
  
  // Return the original request
  return fetch(request);
}

addEventListener("fetch", (event) => {
  event.respondWith(handleRequest(event.request));
});

Chaika•5/24/23, 7:21 PM

it's probably because your browser is doing at least 2 requests, even if the page has no other resources, it's getting the raw html & favicon.ico (automatic)

Chaika•5/24/23, 7:22 PM

The worker is ran for every request to every resource, unless you made the route just

and not /*/* (and not using a custom domain)

lokiwindOP•5/24/23, 7:24 PM

Thank you for your answer @chaika.me

if I do not use /* it will not work in other url paths how can I prevent this

Chaika•5/24/23, 7:30 PM

well just to exclude favicon requests, you could do something like

export default {
  async fetch(request, env, ctx) {
    if (request.url.endsWith('/favicon.ico') == false) {
      // Get the IP address of the incoming user from the request headers
      const ip = request.headers.get("CF-Connecting-IP");

      // Generate a 3-digit key
      const key = Math.random().toString().slice(2, 5);

      // Save the data to the KV namespace using the generated key
      await env.LOG_IP.put(`${ip}<${key}`, 8);
    }
    // Return the original request
    return fetch(request);
  },
};

export default {
  async fetch(request, env, ctx) {
    if (request.url.endsWith('/favicon.ico') == false) {
      // Get the IP address of the incoming user from the request headers
      const ip = request.headers.get("CF-Connecting-IP");

      // Generate a 3-digit key
      const key = Math.random().toString().slice(2, 5);

      // Save the data to the KV namespace using the generated key
      await env.LOG_IP.put(`${ip}<${key}`, 8);
    }
    // Return the original request
    return fetch(request);
  },
};

(rewritten to module format, don't use service worker format, it's ugly and slower)

Chaika•5/24/23, 7:30 PM

if you only want one log per user per session, you could send back set a cookie and check it

CChaika if you only want one log per user per session, you could send back set a cookie ...

lokiwindOP•5/24/23, 7:33 PM

I just want the ip address to be recorded as many requests as the user sends.

Chaika•5/24/23, 7:34 PM

well your browser automatically making a request to favicon.ico is a "request the user made"

CChaika well your browser automatically making a request to favicon.ico is a "request th...

lokiwindOP•5/24/23, 7:35 PM

I understand you... I do not want to record the request from other automatically running services such as png, ico, php that the website runs

lokiwindOP•5/24/23, 7:35 PM

For example, In xenforo forum software, many files are running in one request

lokiwindOP•5/24/23, 7:38 PM

It is really a pity that when a user sends a request, it is saved in the KV storage many times

lokiwindOP•5/24/23, 7:54 PM

one last question

lokiwindOP•5/24/23, 7:55 PM

do not want to include favicon.ico and style.css

lokiwindOP•5/24/23, 7:55 PM

js.js549B

lokiwindOP•5/24/23, 7:56 PM

is this usage correct

Chaika•5/24/23, 8:04 PM

looks ok to me

Llokiwind I understand you... I do not want to record the request from other automaticall...

Chaika•5/24/23, 8:05 PM

hmm being in a proxy position is a bit special, you could try something somewhat primitive like checking for the returned content-type being text/html, or maybe the referrer headers.

CChaika hmm being in a proxy position is a bit special, you could try something somewhat...

lokiwindOP•5/24/23, 8:07 PM

thank you I'll try that mate

export default { async fetch(request, env, ctx) { if (request.url.endsWith('/favicon.ico') == false) { // Get the IP address of the incoming user from the request headers const ip = request.headers.get("CF-Connecting-IP"); // Generate a 3-digit key const key = Math.random().toString().slice(2, 5); // Save the data to the KV namespace using the generated key await env.LOG_IP.put(`${ip}<${key}`, 8); } // Return the original request return fetch(request); }, };

Problem saving data 2 times in 1 request

Similar Threads

Similar Threads

Similar Threads