so probably that service returned something unexpectedly

WWalshy so probably that service returned something unexpectedly

I

its open source so here you go: https://github.com/DaBigBlob/FIT-Weather-Chan/blob/main/src/bot.ts

GitHub

FIT-Weather-Chan/bot.ts at main · DaBigBlob/FIT-Weather-Chan

Hourly weather updates for Florida Institute of Technology campus - FIT-Weather-Chan/bot.ts at main · DaBigBlob/FIT-Weather-Chan

WWalshy so probably that service returned something unexpectedly

I

IdkWhatever69•5/27/23, 7:07 PM

the requests are these:

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

//get hourly weather
    const wthr: Result<Period> = await (async () => {
        const proto_res = (await (await fetch(`${WeatherAPIEndpoint}/hourly`, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

        const result = proto_res.properties.periods.filter(p => (dateIsoToUnixSec(p.startTime)*1000 > now))[0];
        if (exists(result)) return new Ok(result);

        return new Err("Data too old");
    })();
    if (!wthr.isOk()) return;

    //get overall day dorcast
    const day_forcase = await (async () => {
        const proto_res = (await (await fetch(WeatherAPIEndpoint, { body: null, method: 'GET', headers: fetch_headers})).json()) as WeatherData|undefined;
        if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}`);

        const result = proto_res.properties.periods.find(p => (p.number == 1));
        if (exists(result)) return new Ok(result);

        return new Err("Today's data not found");
    })();

I

IdkWhatever69•5/27/23, 7:07 PM

my god that looks ugly

I

IdkWhatever69•5/27/23, 7:08 PM

(excuse my spelling mistakes)

J

James•5/27/23, 7:10 PM

Yeah you're making a lot of assumptions about those requests always returning a 200, and always returning valid JSON

J

James•5/27/23, 7:10 PM

I'd guess one of them had a hiccup

J

James•5/27/23, 7:11 PM

If you wanted to make it more resilient,, make the request, check if OK, check if JSON, and then call

.json()

.json()

J

James•5/27/23, 7:11 PM

Depending on the service, I might also check the data is returns, in case there's a chance

properties.periods

properties.periods

properties.periods

properties.periods doesn't exist, for example.

F

F0rce•5/27/23, 7:12 PM

is

[placement]
mode = "smart"

[placement]
mode = "smart"

[placement]
mode = "smart"

[placement]
mode = "smart"

inheritable ? The docs page does not seem to have it listed.

JJames If you wanted to make it more resilient,, make the request, check if OK, check i...

I

IdkWhatever69•5/27/23, 7:16 PM

right i should check .ok before .json()-ing

JJames Depending on the service, I might also check the data is returns, in case there'...

I

IdkWhatever69•5/27/23, 7:17 PM

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

if (!exists(proto_res) || !exists(proto_res.properties.periods)) return new Err(`No data from ${WeatherAPIEndpoint}/hourly`);

i do check that

J

James•5/27/23, 7:17 PM

yep I'd check

.ok

.ok

.ok

.ok and also check if the

content-type

content-type

includes

application/json

application/json

application/json

application/json. You'd be surprised at how many APIs are wonky sometimes and return a 200 but an HTML error page or something

IIdkWhatever69 ```ts if (!exists(proto_res) || !exists(proto_res.properties.periods)) return ne...

J

James•5/27/23, 7:18 PM

if

.properties

.properties

.properties

.properties doesn't exist there, you'll get a

TypeError

TypeError

TypeError

TypeError. I'd check

proto_res.properties

proto_res.properties

proto_res.properties

proto_res.properties exists too

JJames yep I'd check `.ok` and also check if the `content-type` includes `application/j...

I

IdkWhatever69•5/27/23, 7:18 PM

but this is in the geaders tho

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

const fetch_headers = {
    'User-Agent': `${fitweather_credentials.name}/1.0 (Florida Institute of Technology Weather Discord Bot (Student Run), https://github.com/DaBigBlob/FIT-Weather-Chan)`,
    'Accept': "application/geo+json"
};

J

James•5/27/23, 7:18 PM

Or just

if(!proto_res?.properties?.periods)

if(!proto_res?.properties?.periods)

if(!proto_res?.properties?.periods)

if(!proto_res?.properties?.periods) with optional chaining

IIdkWhatever69 but this is in the geaders tho ```ts const fetch_headers = { 'User-Agent': `...

J

James•5/27/23, 7:19 PM

are you 100% certain that API is perfect and only ever returns JSON when asked?

When working with external APIs, it's always better to add resilience by checking what's actually returned

FF0rce is ```toml [placement] mode = "smart" ``` inheritable ? The docs page does not s...

K

kian•5/27/23, 7:19 PM

Nope

JJames are you 100% certain that API is perfect and only ever returns JSON when asked? ...

I

IdkWhatever69•5/27/23, 7:19 PM

true true; i'll do that

K

kian•5/27/23, 7:19 PM

Oh no, it is

K

kian•5/27/23, 7:19 PM

It's the very last inheritable property

F

F0rce•5/27/23, 7:19 PM

perfect. thanks a lot

JJames if `.properties` doesn't exist there, you'll get a `TypeError`. I'd check `proto...

I

IdkWhatever69•5/27/23, 7:20 PM

if .properties dont exist shouldn't .properties.periods be undefined?
and if it is, i do check that

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

export function exists<T>(data: T|null|undefined): data is T {
  if (
      (data === null) ||
      (data === undefined)
  ) return false;
  return true;
}

IIdkWhatever69 if .properties dont exist shouldn't .properties.periods be undefined? and if it ...

J

James•5/27/23, 7:22 PM

.properties.periods

.properties.periods

.properties.periods

.properties.periods would throw a

TypeError

TypeError

TypeError

TypeError if

properties

properties

properties

properties doesn't exist. For example:

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

const obj = {foo: 'bar'}
console.log(obj.foo) // bar
console.log(obj.bar) // undefined
console.log(obj.bar.baz) // TypeError

A

AA•5/27/23, 7:23 PM

I want to create a single git repo, with lots of workers (mostly webhooks, so stripe/ses/etc) this seems smarter than 1 big project since i can update/change them 1 at a time.. anyone have a good example of how to structure this? just 1 directory per worker, with its own wrangler? or?

JJames `.properties.periods` would throw a `TypeError` if `properties` doesn't exist. F...

I

IdkWhatever69•5/27/23, 7:24 PM

right right

Screenshot_2023-05-28_at_12.53.54_AM.png

A

andrew•5/27/23, 7:52 PM

since

performance.now()

performance.now()

performance.now()

performance.now() isn’t available in Workers and

Date.now()

Date.now()

doesn’t increment unless you do I/O is there any way to actually benchmark CPU bound function execution times in a worker?

K

kian•5/27/23, 7:58 PM

Nope

K

kian•5/27/23, 7:58 PM

performance.now()

performance.now()

performance.now()

performance.now() is available but it just calls

Date.now()

Date.now()

A

andrew•5/27/23, 8:06 PM

That’s annoying. Other platforms mitigate timing attacks but just skewing the resolution, but outright disabling it is an approach i guess

A

AA•5/27/23, 8:08 PM

wrangler tail <-- all i get are OKs even tho I'm generating

internal server error

internal server error

internal server error

internal server error anyplace to look to see better logging?

A

AA•5/27/23, 8:08 PM

maybe this is a wrangler question..

W

WalshyOP•5/27/23, 8:09 PM

what do you mean you're generating it?

W

WalshyOP•5/27/23, 8:09 PM

are you catching the exception?

A

AA•5/27/23, 8:10 PM

not naturally. only if hono is

A

AA•5/27/23, 8:10 PM

import { Hono } from 'hono'
import { Client } from 'pg'

const app = new Hono()

const connstring = "postgresql://postgres@localhost:5432/hhscdev?schema=public"

app.get('*', async (c) => {
  const client = new Client("postgresql://postgres@localhost:5432/hhscdev?schema=public");
  await client.connect();
  
  const { rows: [{ now }] } = await client.query('select now();');
  return c.text(`Hello Hono! ${now}`)
})

export default app

import { Hono } from 'hono'
import { Client } from 'pg'

const app = new Hono()

const connstring = "postgresql://postgres@localhost:5432/hhscdev?schema=public"

app.get('*', async (c) => {
  const client = new Client("postgresql://postgres@localhost:5432/hhscdev?schema=public");
  await client.connect();
  
  const { rows: [{ now }] } = await client.query('select now();');
  return c.text(`Hello Hono! ${now}`)
})

export default app

import { Hono } from 'hono'
import { Client } from 'pg'

const app = new Hono()

const connstring = "postgresql://postgres@localhost:5432/hhscdev?schema=public"

app.get('*', async (c) => {
  const client = new Client("postgresql://postgres@localhost:5432/hhscdev?schema=public");
  await client.connect();
  
  const { rows: [{ now }] } = await client.query('select now();');
  return c.text(`Hello Hono! ${now}`)
})

export default app

import { Hono } from 'hono'
import { Client } from 'pg'

const app = new Hono()

const connstring = "postgresql://postgres@localhost:5432/hhscdev?schema=public"

app.get('*', async (c) => {
  const client = new Client("postgresql://postgres@localhost:5432/hhscdev?schema=public");
  await client.connect();
  
  const { rows: [{ now }] } = await client.query('select now();');
  return c.text(`Hello Hono! ${now}`)
})

export default app

W

WalshyOP•5/27/23, 8:11 PM

yeah Hono does it's own catching of unknown errors

W

WalshyOP•5/27/23, 8:11 PM

So that's why it's ok, the error is being handled

W

WalshyOP•5/27/23, 8:11 PM

you can do

app.onError

app.onError

to add your own handler

A

AA•5/27/23, 8:11 PM

ah, just using that because its recommended. wonder if i should abandon it. or find a way to dump the error

A

AA•5/27/23, 8:12 PM

really just using a single 'url' per project, so maybe hono is overkill

A

AA•5/27/23, 8:20 PM

@walshydev thanks. 1 problem down. 99 more to go

A

AA•5/27/23, 8:23 PM

ooh, another minor quirk. i'm doing a wrangler --env staging.. but in the workers dashboard it says the environment is 'production' are these things not linked?

A

AA•5/27/23, 8:23 PM

also did a vars = { ENVIRONMENT = "staging" }

C

Cyb3r-Jak3•5/27/23, 8:24 PM

You probably have two workers with different names and both using the production environment

AAA ooh, another minor quirk. i'm doing a wrangler --env staging.. but in the worke...

J

James•5/27/23, 8:24 PM

The terminology around environments is weird. I summarised a while back: https://community.cloudflare.com/t/environments-vs-deployments/451036/2?u=cherryjimbo

A

AA•5/27/23, 8:25 PM

@cherryjimbo Oh you're CherryJimbo! that explains so much

also this explains lots too. just ignore the dashboard one

J

James•5/27/23, 8:26 PM

Yep that's me

yeah, you're best just to ignore the

production

production

stuff on the dashboard entirely right now

J

James•5/27/23, 8:26 PM

This'll get better with Pages+Workers convergence long-term, but that's probably a ways off

A

AA•5/27/23, 8:26 PM

https://developers.cloudflare.com/workers/platform/environments/#introducing-environments <-- i'm setting up my workers like this, is this reasonable?

Environments · Cloudflare Workers docs

Environments are different contexts that your code runs in. The Workers platform allows you to create and manage different environments. Through …

so probably that service returned something unexpectedly

Similar Threads

Similar Threads

Similar Threads