Cloudflare Developers•3y ago

Does your Worker write to a file?

Hhanpolo https://github.com/cloudflare/workers-sdk/issues/3408

JacobMGEvansOP•6/12/23, 6:51 PM

@walshydev you have any input or someone that can skim the ticket?

JacobMGEvansOP•6/12/23, 6:51 PM

Want to just get initial assessment

JacobMGEvansOP•6/12/23, 6:51 PM

Seen more than one person mention this, trying to sus out if it's v3 related and how

JacobMGEvansOP•6/12/23, 6:52 PM

Maybe... @gregbrimble

Walshy•6/12/23, 6:52 PM

Interesting...

Walshy•6/12/23, 6:52 PM

@skye_31 any idea what's happening here?

Walshy•6/12/23, 6:52 PM

And you're the unofficial pages employee

Walshy•6/12/23, 6:54 PM

You're unofficial for a reason LuL

Walshy•6/12/23, 6:55 PM

... Bish

Walshy•6/12/23, 6:55 PM

Any idea any gzip decompression we do?

JJacobMGEvans Seen more than one person mention this, trying to sus out if it's v3 related and...

GregBrimble•6/12/23, 6:56 PM

Definitely v3 related. kjkj warnings are from workerd.

GregBrimble•6/12/23, 6:57 PM

https://github.com/cloudflare/workers-sdk/blob/05099f4c9ff1f57d62db5b73a8aea73d1ab1aac6/packages/pages-shared/asset-server/handler.ts#L479

GitHub

workers-sdk/handler.ts at 05099f4c9ff1f57d62db5b73a8aea73d1ab1aac6 ...

Home to Wrangler, the CLI for Cloudflare Workers® - workers-sdk/handler.ts at 05099f4c9ff1f57d62db5b73a8aea73d1ab1aac6 · cloudflare/workers-sdk

GregBrimble•6/12/23, 6:57 PM

This is the only manual encoding stuff we do that I’m aware of

GregBrimble•6/12/23, 6:59 PM

Smells like a workerd bug to me, rather than something Pages-specific

GregBrimble•6/12/23, 6:59 PM

Would be good to try repro in Workers-proper

Peter Belbin•6/12/23, 10:52 PM

Hey there! Would someone on the Cloudflare team be able to take a look at https://github.com/cloudflare/workers-sdk/issues/3385 and the associated pull request (https://github.com/cloudflare/workers-sdk/pull/3384 ) please? I'm kinda hoping this might be an easy add, but so far, have no feedback at all. Thank you!

GitHub

🚀 Feature Request: Allow Wrangler deployments to opt-in to expirati...

Background The place where I work has been using Wrangler 1.x, and likes having the old assets not immediately being removed from the KV storage when a new deploy happens. Reason: users that alread...

GitHub

[wrangler] Add deploy --old-asset-ttl option by Peter-Sparksuite · ...

Fixes #3385
What this PR solves / how to test:
When a wrangler deploy happens, the old assets are immediately deleted, causing users of previously obtained web applications that expect to find spec...

cmendoza•6/13/23, 2:15 AM

Hi, does miniflare@2's local KV persistence to redis (https://miniflare.dev/storage/kv#persistence) work on miniflare@3miniflare@3/wrangler@3wrangler@3? I am able to get it to work on miniflare@2miniflare@2, however when migrating to wrangler@3wrangler@3,

wrangler dev

wrangler dev

ignores the [miniflare][miniflare] section in the

wrangler.toml

wrangler.toml

If not, are there any plans on supporting that feature?
(we currently need it for our local dev testing to making the KV accessible to other external applications, any suggestions on alternatives would be welcome).

📦 KV · Miniflare

Fun, full-featured, fully-local simulator for Cloudflare Workers

kian•6/13/23, 2:23 AM

Miniflare 3 uses SQLite and blobs in a folder

kian•6/13/23, 2:23 AM

For Miniflare v3, we’re now using the industry-standard SQLite, with a separate blob store for KV values, R2 objects, and cached responses.

kian•6/13/23, 2:23 AM

There's no documentation on it so you'd have to dig through Miniflare 3's source code or trial & error

Ccmendoza Hi, does miniflare@2's local KV persistence to redis (https://miniflare.dev/stor...

DaniFoldi•6/13/23, 6:44 AM

They’ve dropped redis support in v3, as far as I know

cmendoza•6/13/23, 7:09 AM

Oh i see, okay. Looking through the .wrangler.wrangler folder again i do see those SQLite and blobs, was just partly hoping there's still a way for a redis support. Thanks!

JJacobMGEvans Does your Worker write to a file?

mukhtharcm•6/13/23, 12:42 PM

Got It fixed. don't exactly know how, but I think the problem was with my npm or something.

mukhtharcm•6/13/23, 12:43 PM

Do wrangler support nodejs 20 ?

Mmukhtharcm Do wrangler support nodejs 20 ?

JacobMGEvansOP•6/13/23, 12:53 PM

It should

PPeter Belbin Hey there! Would someone on the Cloudflare team be able to take a look at http...

Adam•6/13/23, 2:59 PM

Sorry for the delay getting back to you on this. I'll take a look asap and reply in GitHub.

AAdam Sorry for the delay getting back to you on this. I'll take a look asap and reply...

Peter Belbin•6/13/23, 3:36 PM

much appreciated!

Eusebio Trigo•6/14/23, 10:49 AM

I just created a new worker using

npm create cloudflare@2

npm create cloudflare@2

and when starting it it raises the warn/error:

[mf:wrn] The latest compatibility date supported by the installed Cloudflare Workers Runtime is "2023-05-18",
but you've requested "2023-06-14". Falling back to "2023-05-18"...

[mf:wrn] The latest compatibility date supported by the installed Cloudflare Workers Runtime is "2023-05-18",
but you've requested "2023-06-14". Falling back to "2023-05-18"...

EEusebio Trigo I just created a new worker using `npm create cloudflare@2` and when starting it...