Cloudflare Developers•3y ago

Yeah, looks like something the React dev server is returning breaks GZip...

HHello, I’m Allie!Yeah, looks like something the React dev server is returning breaks GZip...

Hasi•6/17/23, 1:08 PM

yep, I see it

Steved•6/18/23, 9:53 PM

I've just created a new svelte project with C3, and run

npm run pages:dev

npm run pages:dev

which in turn runs

wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev

wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev

. This triggers an oauth login to cloudflare in the browser. Out of interest, why? Given it's running locally with Wranger v3.

kian•6/19/23, 4:21 PM

Local development that uses

workerd

workerd

doesn't support that architecture, correct

kian•6/19/23, 9:27 PM

Pass it to

deploy

deploy

wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY

wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY

but those are plain-text in the dashboard & whatnot so ideally you'd use secrets.

kian•6/19/23, 9:27 PM

KV has no CLI arg unfortunately

DaniFoldi•6/19/23, 9:37 PM

wrangler-action also has a secrets: section where you can provide secrets it will upload every time

kian•6/19/23, 9:55 PM

Have you done

npm i

npm i

(or the equivalent in the package manager you're using) in CI already?

kian•6/19/23, 9:58 PM

preCommands: npm install

preCommands: npm install

should be all you need I suppose

kian•6/19/23, 9:58 PM

It'll go in the

with

with

block - put it before

command

command

(just aesthetics)

James•6/19/23, 9:59 PM

I'd heavily encourage using

npm ci

npm ci

over

npm install

npm install

if you have a lockfile, for stable and reproducible builds, but yep,

preCommands

preCommands

is great for that

James•6/19/23, 10:01 PM

devDependencies

devDependencies

is fine and what I'd recommend for something like this. But it won't matter here

kian•6/19/23, 10:01 PM

@cloudflare/workers-types

@cloudflare/workers-types

and

typescript

typescript

could probably be devDependencies I guess

James•6/19/23, 10:02 PM

My mentality:

dependencies

dependencies

are for runtime things, if you've got an app that runs and uses

express

express

for example.

devDependencies

devDependencies

for dev tooling, or anything that's only used to build, like everything here, since it's all bundled into a single output worker.

DaniFoldi•6/19/23, 10:02 PM

I keep dependencies required in the main build step in regular, everything else in dev, so the main build step only needs to install non-dev stuff

JJames My mentality: `dependencies` are for _runtime_ things, if you've got an app that...

James•6/19/23, 10:02 PM

But I know people have differing opinions on that

DaniFoldi•6/19/23, 10:03 PM

Yup

James•6/19/23, 10:03 PM

Yeah, in your case I would personally throw it all in

devDependencies

devDependencies

, but you're not publishing to npm... so it doesn't overly matter.

James•6/19/23, 10:04 PM

perfect haha

kian•6/19/23, 10:04 PM

that's a James move

James•6/19/23, 10:06 PM

we're always happy to help!! Love to see it

captain•6/20/23, 2:42 AM

hey what's up team...trying to update from wrangler 2.20.0 to the latest...but running:

sudo npm install -g wrangler

sudo npm install -g wrangler

but getting the following starting error:

npm ERR! code 1
npm ERR! path /Users/dev/.nvm/versions/node/v19.0.1/lib/node_modules/wrangler/node_modules/better-sqlite3
npm ERR! command failed

Any ideas?

captain•6/20/23, 2:49 AM

runing via m1 latest version of os

captain•6/20/23, 3:17 AM

follow up on this:
% sudo npm install -g wrangler
npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
npm ERR! code 1
npm ERR! path /Users/dev/.nvm/versions/node/v19.0.1/lib/node_modules/wrangler/node_modules/better-sqlite3
npm ERR! command failed

captain•6/20/23, 5:13 AM

bueler...

Yeah, looks like something the React dev server is returning breaks GZip...

Similar Threads