Is there any problem storing `request` in AsyncLocalStorage? I'm looking for a quick and easy way to

Is there any problem storing

request

request

request

request in AsyncLocalStorage? I'm looking for a quick and easy way to access

request

request

request

request,

env

env

context

context

context

context etc in various other functions/files. For example:

const asyncLocalStorage = new AsyncLocalStorage();
return asyncLocalStorage.run( { request, env, context, workerVersion }, async () => {
(...)

const asyncLocalStorage = new AsyncLocalStorage();
return asyncLocalStorage.run( { request, env, context, workerVersion }, async () => {
(...)

const asyncLocalStorage = new AsyncLocalStorage();
return asyncLocalStorage.run( { request, env, context, workerVersion }, async () => {
(...)

const asyncLocalStorage = new AsyncLocalStorage();
return asyncLocalStorage.run( { request, env, context, workerVersion }, async () => {
(...)

CCole-kun Is there any problem storing `request` in AsyncLocalStorage? I'm looking for a q...

Hello, I’m Allie!•6/19/23, 8:57 PM

Theoretically yes, I don’t see why it wouldn’t work, though I would be extra careful with it, since it makes it a lot easier to accidentally read the body twice

HHello, I’m Allie!Theoretically yes, I don’t see why it wouldn’t work, though I would be extra car...

Cole-kunOP•6/19/23, 9:08 PM

Yeah, I can see that. I learned that months ago with a retry logic I had. The first try consumed the body; if it failed, the retry also failed because the body was already consumed.

I don't think I'll hit this issue again, and this store will definitely help keep all the function parameters a bit cleaner. Thanks

James•6/19/23, 10:33 PM

await request.json()await request.json(), await request.text()await request.text(), etc.

James•6/19/23, 10:33 PM

Check https://developer.mozilla.org/en-US/docs/Web/API/Request/json for example

James•6/19/23, 10:50 PM

The JSON you're sending in your POST must not be valid

James•6/19/23, 10:50 PM

You can try await request.text()await request.text() to get the raw text, but you'll see it's not valid JSON that can be passed to JSON.parseJSON.parse

Cyb3r-Jak3•6/19/23, 10:55 PM

You can do const url = new URL(request.url)const url = new URL(request.url) then be able to use a URL object https://developer.mozilla.org/en-US/docs/Web/API/URL so https://developer.mozilla.org/en-US/docs/Web/API/URL/hostname

Ssquadus What is this error?

Hello, I’m Allie!•6/19/23, 11:06 PM

Wrangler no longer uses Webpack for bundling

Hello, I’m Allie!•6/19/23, 11:07 PM

Also, looks like you are trying to import the wrangler.toml for some reason

James•6/19/23, 11:17 PM

The top error you're getting would imply that you're trying to import a tomltoml file into your worker

James•6/19/23, 11:17 PM

The second one is due to changes from wrangler 1 -> 2: https://developers.cloudflare.com/workers/wrangler/migration/v1-to-v2/

James•6/19/23, 11:24 PM

I imagine you're assuming the request method is always a POST, and that the JSON is valid? You will likely want to check if the method is post, and wrap your request.jsonrequest.json in some error handling like try...catchtry...catch to ensure it's real JSON

James•6/19/23, 11:29 PM

request.bodyrequest.body in a POST will be a ReadableStreamReadableStream

James•6/19/23, 11:30 PM

you will have to read it to know if it's valid or not

James•6/19/23, 11:30 PM

so I would recommend wrapping in some error handling like a try...catchtry...catch

James•6/19/23, 11:30 PM

You can check other things too, like the content-typecontent-type header includes application/jsonapplication/json, but that still won't prevent someone POSTing you bad JSON if they so choose

Is there any problem storing `request` in AsyncLocalStorage? I'm looking for a quick and easy way to

Similar Threads