Stardust XR•3y ago

And if I press Ctrl + C in Stardust, it'll kill stardust instead of killing the program I've spawned

And if I press Ctrl + C in Stardust, it'll kill stardust instead of killing the program I've spawned from kitty

Mmatthewcroughan Once in kitty in sway, and secondly in the TTY where I spawned everything

Nova•6/21/23, 5:23 AM

ah, that's what happens when it's in the background

Mmatthewcroughan And if I press Ctrl + C in Stardust, it'll kill stardust instead of killing the ...

Nova•6/21/23, 5:24 AM

that however is weird

matthewcroughanOP•6/21/23, 5:25 AM

If I hold onto the process without backgrounding it, the CTRL + C can't propagate to the program

matthewcroughanOP•6/21/23, 5:25 AM

If I background it, the shell executes my input

Nova•6/21/23, 5:25 AM

so if it's in the background ctrl+c... stops it?

matthewcroughanOP•6/21/23, 5:27 AM

opposite way around

matthewcroughanOP•6/21/23, 5:27 AM

I'm just describing that there are two cases, and both are bad

Nova•6/21/23, 5:27 AM

oh that makes perfect sense then

Nova•6/21/23, 5:28 AM

wait no it doesn't

Nova•6/21/23, 5:28 AM

if the process isn't backgrounded... why is it executing your input??

Nova•6/21/23, 5:28 AM

that makes no sense

matthewcroughanOP•6/21/23, 5:28 AM

That's not what I mean

matthewcroughanOP•6/21/23, 5:28 AM

I'll try to be clearer

matthewcroughanOP•6/21/23, 5:28 AM

If I fork it like then

bash

bash

will execute my input

matthewcroughanOP•6/21/23, 5:29 AM

If I do not fork it like

stardust-xr-server

stardust-xr-server

then

bash

bash

will not execute my input, but signals are accepted from stdin by stardust-xr-server, such as CTRL + C, meaning the process will be killed, when what I really want to do is give that to

Nova•6/21/23, 5:29 AM

what do you mean by ==

bash

bash

matthewcroughanOP•6/21/23, 5:29 AM

that's what happens

Mmatthewcroughan If I do not fork it like `stardust-xr-server` then `bash` will not execute my i...

Nova•6/21/23, 5:30 AM

ohhhhhhhhhh i see the problem haha

Nova•6/21/23, 5:30 AM

it's not stdin

matthewcroughanOP•6/21/23, 5:30 AM

In sway, when I press it gets sent to kitty, which then sends it to bash

Nova•6/21/23, 5:30 AM

signals are controlled by the shell

matthewcroughanOP•6/21/23, 5:30 AM

in stardust launched from tty, when I press ^C, it gets sent to bash which then kills stardust

Nova•6/21/23, 5:31 AM

ctrl+c is intercepted by the shell

matthewcroughanOP•6/21/23, 5:31 AM

yeah

Nova•6/21/23, 5:31 AM

so we just need to figure out why sway doesn't have that

Nova•6/21/23, 5:31 AM

how can you quit sway from tty btw?

matthewcroughanOP•6/21/23, 5:31 AM

you don't and can't

matthewcroughanOP•6/21/23, 5:31 AM

you just launch it, and you have to either say from somewhere else on the system, or

Nova•6/21/23, 5:31 AM

well then... hmm

matthewcroughanOP•6/21/23, 5:32 AM

same with plasmashell

Nova•6/21/23, 5:32 AM

i know how that's done

Nova•6/21/23, 5:32 AM

it's done by intercepting all signals and ignoring them

Nova•6/21/23, 5:32 AM

but when stardust is launched from a regular terminal...

matthewcroughanOP•6/21/23, 5:32 AM

traps they're called in normal shell lingo

Nova•6/21/23, 5:32 AM

right yea

Nova•6/21/23, 5:33 AM

i guess i could make a flag for it

Nova•6/21/23, 5:33 AM

but what should the default be

Nova•6/21/23, 5:33 AM

to trap all the signals or not to

matthewcroughanOP•6/21/23, 5:33 AM

I'd suggest not doing that

matthewcroughanOP•6/21/23, 5:33 AM

just make it the normal way by default

matthewcroughanOP•6/21/23, 5:33 AM

--accept-signals could be a way of turning it off if you want to make it configurable

Nova•6/21/23, 5:33 AM

ok so to trap all signals?

matthewcroughanOP•6/21/23, 5:33 AM

but it definitely should be this way by default

Nova•6/21/23, 5:34 AM

what way by default?

matthewcroughanOP•6/21/23, 5:35 AM

ignoring signals

Nova•6/21/23, 5:35 AM

uhhhhhhhh

matthewcroughanOP•6/21/23, 5:35 AM

https://crates.io/crates/ctrlc

matthewcroughanOP•6/21/23, 5:35 AM

lolwut