discord js core issue

Sometime halfway through guilds.map(async (guild) =>{..} ) cpu usage goes abnormally high ,ram usage increases by like 50mb and server gets stuck , it doesn't continue . And remains stuck till it is killed
Full code: https://pastecode.io/s/mk7w8hu2
the code which could be responsable: https://pastecode.io/s/mk7w8hu2
Note: In this code guilds is a array of guilds fetched by api
And i am using discord js core
I asked from help from other servers first they told me nothing seems of in the code and it could be a discordjs core issue

d.js toolkit•7/8/23, 5:26 AM

• What's your exact discord.js

npm list discord.js

npm list discord.js

and node

node -v

node -v

version?
• Post the full error stack trace, not just the top part!
• Show your code!
• Explain what exactly your issue is.
• Not a discord.js issue? Check out #useful-servers.

jagritOP•7/8/23, 5:27 AM

Using latest discordjs core

jagritOP•7/8/23, 5:28 AM

Facing similar issue in discord.js I moved from discordjs to discord js core thinking it was cache issue but still facing it
In discordjs core

d4•7/8/23, 6:52 AM

in the attached code you aren't even using djs core, also you are not using discord.js for fetching the guilds, and it seems like you have a very outdated version of discord.js too

Dd4 in the attached code you aren't even using djs core, also you are not using disc...

jagritOP•7/8/23, 8:45 AM

What why are assuming this. I have imported client from my index.ts and in index.ts its a discord js core client

jagritOP•7/8/23, 8:46 AM

index.js:

const rest = new REST({ version: "10" }).setToken(token);
const gateway = new WebSocketManager({
token,
intents: GatewayIntentBits.Guilds,
rest,
});
const api = new Client({ rest, gateway });

export const client = api.api;

d4•7/8/23, 8:50 AM

ah apologies then, i assumed that because you named it

client

client

when typically it's named

api

api

d4•7/8/23, 8:51 AM

i would assume here that you are most likely being rate limited by discord, fetching every single guild like this would be api spam

jagritOP•7/8/23, 8:52 AM

No i am not getting rate limited

jagritOP•7/8/23, 8:52 AM

And a ratelimit shouldn't cause whole express server to hang

d4•7/8/23, 8:53 AM

it would cause the

guilds.get

guilds.get

request to hang iirc

jagritOP•7/8/23, 8:53 AM

But other endpoint should work even if only this one get stuck

jagritOP•7/8/23, 8:54 AM

But i receive 504 by ngnix in any endpoint

d4•7/8/23, 8:56 AM

also looks like you're fetching guilds using a

Bearer

Bearer

token? that's probably against TOS
also since users can be in 100 guilds or more and your bot has to fetch every single one, theoretically your bot could have over 100 hanging promises running in the background each one dealing with discord's rate limit

Dd4 also looks like you're fetching guilds using a `Bearer` token? that's probably a...

jagritOP•7/8/23, 8:59 AM

See two ratelimit can occur

Fetching user guilds by oauth token
Fetching guild by bot client

I think 1 shows the error when it happens so should 2?

jagritOP•7/8/23, 9:00 AM

If not whats the solution

jagritOP•7/8/23, 9:00 AM

Like stop going through every server at a rate limit

d4•7/8/23, 9:01 AM

djs handles rate limits for you thus the fetching with bot client doesn't show anything

d4•7/8/23, 9:01 AM

but since it handles them for you your promises hang

d4•7/8/23, 9:03 AM

why would you need to fetch with bot client anyway if you already fetch the user guilds?

Dd4 djs handles rate limits for you thus the fetching with bot client doesn't show a...

jagritOP•7/8/23, 9:03 AM

So adding try {} catch (e) {
if (// rate limit error code) {
// Exit
}
} Won't work?

Dd4 why would you need to fetch with bot client anyway if you already fetch the user...

jagritOP•7/8/23, 9:03 AM

To know if bot is in which guilds and show something like a invite button if its not present

Jjagrit To know if bot is in which guilds and show something like a invite button if it...

d4•7/8/23, 9:04 AM

you should use

UsersAPI#getGuilds

UsersAPI#getGuilds

then https://discord.js.org/docs/packages/core/0.6.0/UsersAPI:Class#getGuilds

jagritOP•7/8/23, 9:05 AM

Hmm its a partial tho

d4•7/8/23, 9:05 AM

so what? it still tells you which guilds you have

jagritOP•7/8/23, 9:06 AM

This can also get ratelimited

jagritOP•7/8/23, 9:06 AM

Jjagrit So adding try {} catch (e) { if (// rate limit error code) { // Ex...

jagritOP•7/8/23, 9:06 AM

Jjagrit So adding try {} catch (e) { if (// rate limit error code) { // Ex...

d4•7/8/23, 9:07 AM

this won't work because iirc djs won't throw an error if the rate limit is expected, the

rateLimited

rateLimited

event does exist for the

REST

REST

class though

Jjagrit This can also get ratelimited

d4•7/8/23, 9:08 AM

sure, theoretically anything can, but at least you won't have 100+ requests running at the same time

d4•7/8/23, 9:08 AM

i also recommend setting up caching here so you won't have to request guilds every single time

jagritOP•7/8/23, 9:09 AM

I will implement this but still there should be a solution to prevent the hang at a ratelimit by just stopping there

d4•7/8/23, 9:10 AM

again, the

rateLimited

rateLimited

event exists for

REST

REST

, and

RESTOptions

RESTOptions

also has something for ratelimits iirc

d4•7/8/23, 9:11 AM

https://discord.js.org/docs/packages/rest/main/RestEvents:Interface#rateLimited
https://discord.js.org/docs/packages/rest/main/RESTOptions:Interface#rejectOnRateLimit

jagritOP•7/8/23, 9:11 AM

Hmm

jagritOP•7/8/23, 9:11 AM

Thanks

jagritOP•7/8/23, 9:14 AM

I also wanted to tell this only happens sometimes. Once i kept reloading page every 1s but still didn't receive this issue. Happens at random instance , could be due to another main bot client which handles commands and all ( it runs on seperate server though )

Dd4 you should use `UsersAPI#getGuilds` then https://discord.js.org/docs/packages/co...

jagritOP•7/8/23, 9:26 AM

This won't work because documention says:

Returns a list of partial guild objects the current user is a member of

Returns a list of partial guild objects the current user is a member of

And going through 6000 servers bot is in would be a nightmare

d4•7/8/23, 9:33 AM

also since you said you'd implement caching you could do so using a Map or Collection in which case checking if a bot is in a guild would be easy and fast

jagritOP•7/8/23, 9:35 AM

Hmm thanks guys

jagritOP•7/8/23, 9:36 AM

I would have been clueless without both of you

jagritOP•7/8/23, 11:06 AM

As qjuh told be to use ws to add new guilds to cache by using guildcreate event
But old guild should be in the cache so i should fetch all of the guilds at once at startup and add them to cache

Original message was deleted

jagritOP•7/8/23, 11:08 AM

Uh i thought it would be similar to discord.js (main). Sorry

jagritOP•7/8/23, 11:09 AM

Yeah

Original message was deleted

jagritOP•7/8/23, 11:09 AM

I thought guildcreate would only fire and send the guild which bot jois in future

Original message was deleted

jagritOP•7/8/23, 11:10 AM

Oh ok

jagritOP•7/8/23, 11:15 AM