Cloudflare Developers•3y ago

Miniflare's Vitest environment hasn't been upgraded to v3 yet. We're working on it, but it's going t

Miniflare's Vitest environment hasn't been upgraded to v3 yet. We're working on it, but it's going to take a while...

If you've got existing Vitest tests written, I'd stick with v2 for the time being.

Muhymin•7/13/23, 11:26 AM

! I am having an issue with

wrangler tail

wrangler tail

that it always exits automatically after some time. Is it the expected behavior?? I didn't find any solution for this online.

MMrBBot Miniflare's Vitest environment hasn't been upgraded to v3 yet. We're working on ...

hanpolo•7/13/23, 11:43 AM

Thanks for the response. I came to that conclusion yesterday, removed miniflare from my tests and wrote my own mocks so I could run tests for 3.1.2. looking forward to getting the miniflare update sometime in the future.

Muhymin•7/13/23, 12:03 PM

Off-Topic: @mrbbot I really thought you were a bot who creates threads. And I wondered why the bot didn't create a thread from my message

Ssimpsojo Seems it should just work (TM), but didn't for me (On windows, I got the error: ...

Adam•7/13/23, 8:40 PM

If there's an issue with expected functionality, please help us by filing an issue here https://github.com/cloudflare/workers-sdk/issues so we can take a look!

GitHub

Issues · cloudflare/workers-sdk

Home to Wrangler, the CLI for Cloudflare Workers® - Issues · cloudflare/workers-sdk

beelzabub•7/14/23, 9:01 PM

Does Miniflare 3 have any mechanism to overwrite what domain names map to (within the API, not wrangler)? For example, if my worker is doing a fetch to

https://my.custom.domain.com

https://my.custom.domain.com

, I would like that to get routed to a localhost server for CI testing purposes without changing the URL within the code.

kian•7/14/23, 9:30 PM

Not yet https://github.com/cloudflare/miniflare/discussions/588#discussioncomment-5995047

Bbeelzabub Does Miniflare 3 have any mechanism to overwrite what domain names map to (withi...

MrBBotOP•7/14/23, 9:54 PM

Put a PR up, https://github.com/cloudflare/miniflare/pull/629, still planning to add support for fetch mocks like in Miniflare 2

ajgeiss0702•7/15/23, 1:16 AM

secrets are seperate for each worker, right?

James•7/15/23, 1:18 AM

yep!

James•7/15/23, 1:18 AM

I believe account-wide secrets is a feature that will be coming, but no ETA

ajgeiss0702•7/15/23, 1:21 AM

ok, cool. If i put a secret before publishing the worker, will it pick it up when published? Or will I need to wait to put secrets until after publishing?

ajgeiss0702•7/15/23, 1:22 AM

I guess ill find out in a few minutes anyway

James•7/15/23, 1:23 AM

I think you will have to create and publish the worker once before you add secrets? But honestly I've not tried that workflow in quite a while - let me know what happens

ajgeiss0702•7/15/23, 1:25 AM

will do

ajgeiss0702•7/15/23, 1:26 AM

looks like the pre-put secrets worked

James•7/15/23, 1:26 AM

awesome to hear!

vassbence•7/15/23, 6:38 PM

My tests using

unstable_dev()

unstable_dev()

and R2 fail in CI. Has anyone seen something similar? Sadly giving a longer timeout (5+sec) for the test doesn't seem to fix the problem. The test finishes in local in 24ms.

James•7/15/23, 6:41 PM

That's not a lot of info to work with unfortunately. Are these tests that used to work and no longer? Is it just the R2 tests - do other tests work? What kind of debugging have you done to see where they seemingly hang? What versions of wrangler, etc. are you using? Can you create a minimal reproducible example of a single test that works locally but then fails in CI so we can reproduce?

vassbence•7/15/23, 6:42 PM

Sadly

loglevel: debug

loglevel: debug

doesnt show any errors, test just hang with a simple

env.BUCKET.put

env.BUCKET.put

vassbence•7/15/23, 6:42 PM

Latest wrangler and all of that, it's a fresh repo

vassbence•7/15/23, 6:42 PM

Sure I can do a small repro but how should I go around the CI part? host it as a public github repo and do an action there?

vassbence•7/15/23, 6:43 PM

and yes, its R2 only

James•7/15/23, 6:44 PM

Something like that and an issue on the

workers-sdk

workers-sdk

repo would probably be the best idea, yeah

IItalyPaleAle Is there a way to start `wrangler dev` pointing to a different `.dev.vars`? My c...

Hello, I’m Allie!•7/15/23, 11:45 PM

I don’t think so. The only thing I could think of is temporarily renaming the existing .dev.vars

kian•7/15/23, 11:45 PM

Why wouldn't you be able to use unstable_dev?

kian•7/15/23, 11:45 PM

IItalyPaleAle Renaming the .dev.vars file is risky if the test suite exists non cleanly

Hello, I’m Allie!•7/16/23, 4:01 AM

Oh, I misread, you need the new .dev.vars to be generated dynamically? Can’t you catch any errors from the test suite, then nuke the .dev.vars? Worst comes to worst, you can manually restore the old one

IItalyPaleAle Im gonna try with miniflare tomorrow. Something more low-level may fit my use ca...

Hello, I’m Allie!•7/16/23, 4:03 AM

Note too that Miniflare 3 and onwards no longer have a local API, so it may not reflect the latest changes to the runtime

IItalyPaleAle What do you mean with “local API”?

Hello, I’m Allie!•7/16/23, 5:25 AM

Basically, Miniflare 3 and (afaik) onward will not support calling its APIs manually. As I understand it, Miniflare is transitioning from a local emulator of Workers to just a layer between workerd and wrangler + the binding emulators

Hello, I’m Allie!•7/16/23, 5:26 AM

So only wrangler should be used to emulate a Worker or a Pages Project

Hello, I’m Allie!•7/16/23, 5:28 AM

While it does mean you lose the flow you may have had with Miniflare, I do believe it is an improvement, since it reduces the number of different ways you can develop a Worker(and reduces the work you need to work around each methods oddities).

IItalyPaleAle I may even just look into merging everything into my own build tools, run the de...

Hello, I’m Allie!•7/16/23, 6:18 AM

Sorry, that’s what I meant. Starting with v3, you can only start dev servers with Wrangler

HHello, I’m Allie!Basically, Miniflare 3 and (afaik) onward will not support calling its APIs manu...

MrBBotOP•7/16/23, 9:01 AM

Hey!

Miniflare 3 will continue to provide API support indefinitely. Wrangler uses this API internally, and provides additional features on top like TypeScript support, but you can still use Miniflare standalone. API docs are here: https://github.com/cloudflare/miniflare/blob/tre/packages/miniflare/README.md /cc @italypaleale

GitHub

miniflare/packages/miniflare/README.md at tre · cloudflare/miniflare

Fully-local simulator for Cloudflare Workers. Contribute to cloudflare/miniflare development by creating an account on GitHub.

miniflare/packages/miniflare/README.md at tre · cloudflare/miniflare

MrBBotOP•7/16/23, 9:02 AM

Miniflare 3 just isn’t providing a CLI anymore

Miniflare's Vitest environment hasn't been upgraded to v3 yet. We're working on it, but it's going t

Similar Threads

Similar Threads

Similar Threads