release-please creates a "release PR" that creates a changelog with the commits, but doesn't actuall

A

akdev•8/2/23, 1:50 PM

Release please will create a release after the release PR has been merged not before

Xxyny release-please creates a "release PR" that creates a changelog with the commits,...

A

akdev•8/2/23, 1:59 PM

Let me know if I can help you somehow

Aakdev Release please will create a release after the release PR has been merged not be...

X

xynyOP•8/2/23, 2:22 PM

I did merge it on my testing repo and nothing happened

Aakdev Let me know if I can help you somehow 🙂

X

xynyOP•8/2/23, 2:22 PM

Well, you can either cook up a PR for this one or help me figure it out

X

xynyOP•8/2/23, 2:23 PM

This is the worflow rn https://github.com/EinoHR/linuXYZ/blob/iso/.github/workflows/release-iso.yml

A

akdev•8/2/23, 2:25 PM

It is working?

Aakdev It is working?

X

xynyOP•8/2/23, 2:27 PM

Ok, I ran it again and apparently it is working now.

X

xynyOP•8/2/23, 2:27 PM

Is the workflow like: run action once, PR gets created, rerun, release gets created, ISO built

A

akdev•8/2/23, 2:28 PM

Yes

A

akdev•8/2/23, 2:28 PM

On normal commits it will detect changes and add it to the release PR

A

akdev•8/2/23, 2:28 PM

When you merge that one then the release gets created

X

xynyOP•8/2/23, 2:29 PM

So the release PR should always exist and then when merged the release action should be ran again to release and create the new PR?

A

akdev•8/2/23, 2:29 PM

Yes

A

akdev•8/2/23, 2:30 PM

Actually it will only create the PR on the next commit after it creates a release

A

akdev•8/2/23, 2:30 PM

Normal commit -> add to release PR or create one if not exists
Release commit -> create release and trigger iso build

X

xynyOP•8/2/23, 2:31 PM

So is there something I should change in the PR to make it do all that automatically so I don't need to workflow_dispatch twice every release? Is it possible to make it so the user of the template can just press one button and the release will be made and ISO built?

X

xynyOP•8/2/23, 2:32 PM

For most people the release-please convcommits stuff does not really matter, since the ISOs always pull the latest version, correct?

X

xynyOP•8/2/23, 2:52 PM

Also, the recent action run failed but I'm unable to see what the error is. Or rather; It's a python runtime error in isogenerator, and I don't know what caused it. My understanding is that not providing a boot menu should just use the one in the isogenerator repo, and other than that it's basically the example with the ublue-os org related things replaced with ${{ github.repository_owner }}

X

xynyOP•8/2/23, 2:54 PM

Traceback (most recent call last):
  File "/usr/bin/jinja2", line 33, in <module>
    sys.exit(load_entry_point('jinja2-cli==0.8.2', 'console_scripts', 'jinja2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 449, in main
    sys.exit(cli(opts, args))
             ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 282, in cli
    if has_format(ext):
       ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 81, in has_format
    get_format(fmt)
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 74, in get_format
    return formats[fmt]()
           ~~~~~~~^^^^^
KeyError: ''

Traceback (most recent call last):
  File "/usr/bin/jinja2", line 33, in <module>
    sys.exit(load_entry_point('jinja2-cli==0.8.2', 'console_scripts', 'jinja2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 449, in main
    sys.exit(cli(opts, args))
             ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 282, in cli
    if has_format(ext):
       ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 81, in has_format
    get_format(fmt)
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 74, in get_format
    return formats[fmt]()
           ~~~~~~~^^^^^
KeyError: ''

Traceback (most recent call last):
  File "/usr/bin/jinja2", line 33, in <module>
    sys.exit(load_entry_point('jinja2-cli==0.8.2', 'console_scripts', 'jinja2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 449, in main
    sys.exit(cli(opts, args))
             ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 282, in cli
    if has_format(ext):
       ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 81, in has_format
    get_format(fmt)
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 74, in get_format
    return formats[fmt]()
           ~~~~~~~^^^^^
KeyError: ''

Traceback (most recent call last):
  File "/usr/bin/jinja2", line 33, in <module>
    sys.exit(load_entry_point('jinja2-cli==0.8.2', 'console_scripts', 'jinja2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 449, in main
    sys.exit(cli(opts, args))
             ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 282, in cli
    if has_format(ext):
       ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 81, in has_format
    get_format(fmt)
  File "/usr/lib/python3.11/site-packages/jinja2cli/cli.py", line 74, in get_format
    return formats[fmt]()
           ~~~~~~~^^^^^
KeyError: ''

Xxyny So is there something I should change in the PR to make it do all that automatic...

A

akdev•8/2/23, 4:18 PM

Don't use release please if this is the net result you want imo

Xxyny Also, the recent action run failed but I'm unable to see what the error is. Or r...

A

akdev•8/2/23, 4:20 PM

No you need to provide a boot_menu.yml

A

akdev•8/2/23, 4:21 PM

Or maybe that changed

let me check

A

akdev•8/2/23, 4:22 PM

Yeah it is required

Aakdev No you need to provide a boot_menu.yml

X

xynyOP•8/2/23, 4:22 PM

Ok

A

akdev•8/2/23, 4:23 PM

That's a very ugly error message huh

Aakdev Don't use release please if this is the net result you want imo

X

xynyOP•8/2/23, 4:23 PM

Hmm, well, it is useful for some situations, but is there something you recommend instead?

A

akdev•8/2/23, 4:24 PM

release-please requires understanding git tagging as it is supposed to overtake the entire release process basically

A

akdev•8/2/23, 4:24 PM

If you want a simple "click here to create release" then I think you could just do a workflow with the gh cli

X

xynyOP•8/2/23, 4:25 PM

Well sure. Maybe a short note in the docs that for serious projects you might consider using release_please.

B

bketelsen•8/3/23, 1:59 PM

any selinux experts here?

B

bketelsen•8/3/23, 2:02 PM

i layered

podmansh

podmansh

podmansh

podmansh in a bluefin-dx vm, and got it working after some trial and error. The docs (https://docs.podman.io/en/latest/markdown/podmansh.1.html) have some examples, but none of them worked out of the box. I got one working by moving the containerfile into /home/{containeruser}/.config/containers/systemd/podmansh.container

B

bketelsen•8/3/23, 2:04 PM

the last example on the page says

where the users inside this container are allowed to execute containers with SELinux separation and able to read and write content in the $HOME/data directory.

where the users inside this container are allowed to execute containers with SELinux separation and able to read and write content in the $HOME/data directory.

where the users inside this container are allowed to execute containers with SELinux separation and able to read and write content in the $HOME/data directory.

where the users inside this container are allowed to execute containers with SELinux separation and able to read and write content in the $HOME/data directory.

and it gives these arguments:

PodmanArgs=--security-opt=unmask=/sys/fs/selinux \
    --security-opt=label=nested \
    --security-opt=label=user:container_user_u \
    --security-opt=label=type:container_user_t \
    --security-opt=label=role:container_user_r \
    --security-opt=label=level:s0-s0:c0.c1023

PodmanArgs=--security-opt=unmask=/sys/fs/selinux \
    --security-opt=label=nested \
    --security-opt=label=user:container_user_u \
    --security-opt=label=type:container_user_t \
    --security-opt=label=role:container_user_r \
    --security-opt=label=level:s0-s0:c0.c1023

PodmanArgs=--security-opt=unmask=/sys/fs/selinux \
    --security-opt=label=nested \
    --security-opt=label=user:container_user_u \
    --security-opt=label=type:container_user_t \
    --security-opt=label=role:container_user_r \
    --security-opt=label=level:s0-s0:c0.c1023

PodmanArgs=--security-opt=unmask=/sys/fs/selinux \
    --security-opt=label=nested \
    --security-opt=label=user:container_user_u \
    --security-opt=label=type:container_user_t \
    --security-opt=label=role:container_user_r \
    --security-opt=label=level:s0-s0:c0.c1023

B

bketelsen•8/3/23, 2:05 PM

login fails with this error:

Aug 03 10:04:33 fedora kernel: SELinux: security_context_str_to_sid (container_user_u:object_r:container_file_t:s0-s0:c0.c1023) failed with errno=-22
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.397114165 -0400 EDT m=+0.138985435 image pull 919a420d29c6f5ae0bdc8d1872387d3a878d7f69debce9e24f3f2e0506b2ba0d registry.fedoraproject.org/fedora
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.560247123 -0400 EDT m=+0.302118503 container remove 856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203 (image=registry.fedoraproject.org/fedora:latest, name=podmansh, vendor=Fedora Project, version=38, PODMAN_SYSTEMD_UNIT=podmansh.service, license=MIT, name=fedora)
Aug 03 10:04:33 fedora podmansh[99965]: Error: failed to mount shm tmpfs "/var/home/fullu/.local/share/containers/storage/overlay-containers/856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203/userdata/shm": invalid argument

Aug 03 10:04:33 fedora kernel: SELinux: security_context_str_to_sid (container_user_u:object_r:container_file_t:s0-s0:c0.c1023) failed with errno=-22
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.397114165 -0400 EDT m=+0.138985435 image pull 919a420d29c6f5ae0bdc8d1872387d3a878d7f69debce9e24f3f2e0506b2ba0d registry.fedoraproject.org/fedora
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.560247123 -0400 EDT m=+0.302118503 container remove 856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203 (image=registry.fedoraproject.org/fedora:latest, name=podmansh, vendor=Fedora Project, version=38, PODMAN_SYSTEMD_UNIT=podmansh.service, license=MIT, name=fedora)
Aug 03 10:04:33 fedora podmansh[99965]: Error: failed to mount shm tmpfs "/var/home/fullu/.local/share/containers/storage/overlay-containers/856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203/userdata/shm": invalid argument

Aug 03 10:04:33 fedora kernel: SELinux: security_context_str_to_sid (container_user_u:object_r:container_file_t:s0-s0:c0.c1023) failed with errno=-22
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.397114165 -0400 EDT m=+0.138985435 image pull 919a420d29c6f5ae0bdc8d1872387d3a878d7f69debce9e24f3f2e0506b2ba0d registry.fedoraproject.org/fedora
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.560247123 -0400 EDT m=+0.302118503 container remove 856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203 (image=registry.fedoraproject.org/fedora:latest, name=podmansh, vendor=Fedora Project, version=38, PODMAN_SYSTEMD_UNIT=podmansh.service, license=MIT, name=fedora)
Aug 03 10:04:33 fedora podmansh[99965]: Error: failed to mount shm tmpfs "/var/home/fullu/.local/share/containers/storage/overlay-containers/856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203/userdata/shm": invalid argument

Aug 03 10:04:33 fedora kernel: SELinux: security_context_str_to_sid (container_user_u:object_r:container_file_t:s0-s0:c0.c1023) failed with errno=-22
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.397114165 -0400 EDT m=+0.138985435 image pull 919a420d29c6f5ae0bdc8d1872387d3a878d7f69debce9e24f3f2e0506b2ba0d registry.fedoraproject.org/fedora
Aug 03 10:04:33 fedora podman[99965]: 2023-08-03 10:04:33.560247123 -0400 EDT m=+0.302118503 container remove 856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203 (image=registry.fedoraproject.org/fedora:latest, name=podmansh, vendor=Fedora Project, version=38, PODMAN_SYSTEMD_UNIT=podmansh.service, license=MIT, name=fedora)
Aug 03 10:04:33 fedora podmansh[99965]: Error: failed to mount shm tmpfs "/var/home/fullu/.local/share/containers/storage/overlay-containers/856af025c3595f2ed5c978ad8f98b42b4b0f389d8b2e59f87d080c922db4d203/userdata/shm": invalid argument

B

bketelsen•8/3/23, 2:06 PM

I suspect the problem is this last line

    --security-opt=label=level:s0-s0:c0.c1023

    --security-opt=label=level:s0-s0:c0.c1023

    --security-opt=label=level:s0-s0:c0.c1023

    --security-opt=label=level:s0-s0:c0.c1023

but I don't even know what any of that means.

B

bketelsen•8/3/23, 2:06 PM

Any expert help would be appreciated, and of course upstreamed into bluefin

A

akdev•8/3/23, 2:15 PM

Have you tried label=disable

B

bketelsen•8/3/23, 2:22 PM

that doesn't fail.

B

bketelsen•8/3/23, 2:23 PM

i'm assuming it also doesn't allow nested confined containers

B

bketelsen•8/3/23, 2:26 PM

I can't figure out how to give the user sudo access inside the container

E

EyeCantCU•8/3/23, 2:33 PM

This is why Nvidia 37 is failing. Asus Linux Copr dropped 37

https://copr.fedorainfracloud.org/coprs/lukenukem/asus-linux/

J

j0rge•8/3/23, 2:34 PM

what's in there that we use?

J

j0rge•8/3/23, 2:35 PM

oh, that thing, sorry I'm on mobile

J

j0rge•8/3/23, 2:35 PM

can we skip that build just for 37?

E

EyeCantCU•8/3/23, 2:36 PM

I think just supergfxctl

E

EyeCantCU•8/3/23, 2:36 PM

We can skip it

E

EyeCantCU•8/3/23, 2:36 PM

Or I can rebuild it and add 37 back

J

j0rge•8/3/23, 2:38 PM

I don't know how the nvidia repo works, was hoping we had sections in in main's packages.json

J

j0rge•8/3/23, 2:38 PM

so we could exclude it for 37

J

j0rge•8/3/23, 2:38 PM

but whatever works, it's been three days so whatever gets them green so it unblocks you for bazzite

E

EyeCantCU•8/3/23, 2:39 PM

We don't have that. These packages get installed via install.sh by invoking rpm-ostree

release-please creates a "release PR" that creates a changelog with the commits, but doesn't actuall

Similar Threads

Similar Threads

Similar Threads