K
Lyes, method of type void can not have a return value
Kthat's what the compiler keeps telling me
Kit's really mean :(
KBEYLEY HAVE YOU SEEN THIS
Lyes
LUNUX
KUNUX lmao
Pthis is not true, the JIT does not recognise Vector4D and friends as TYP_SIMD thus it will not place our custom struct in VEX registers. This means that there is an enregistration penalty every time we want to do an operation using System.Numerics. That being said, it should still be possible and less expensive than regular float maths.
PThere was some work being done to recognise user structs as TYP_SIMD which, once implemented, will allow us to have the same performance as System.Numerics
Mahhhh
Mi didn't even think of that, fair cop
KGitHub
Summary of the PR
Fixes BreakneckSleep in the existing CPU usage PR to store the last tick timestamp and compare to that instead of to when Sleep is called.
The branch still doesnt actually use Bre...
Fixes BreakneckSleep in the existing CPU usage PR to store the last tick timestamp and compare to that instead of to when Sleep is called.
The branch still doesnt actually use Bre...
Previewed. Appreciate those comments probably may come across as a bit infuriating or cold, and that’s partially because I myself have a cold at this time, but also if I’m like that you know I think you’re competent because I don’t tip-toe around pointing out flaws haha.
Mthe brace style 
Fthe only correct one 
Myou will suffer /j
Pyeah little things like that I have to avoid bringing up in PR reviews because it becomes a waste of time unless it is egregious.
Mit is a waste of time but you have to fix it eventually anyway
Mi think you can set it up to fix automatically but i don't know how
Plike you can tell when beyley has been in a file when there’s no space after a //, you can tell when devvoid has been in a file because of that brace style (though I think they’re all gone now and I don’t mind telling beyley off for it given that most of their PRs are too perfect that I don’t want to merge them first try)
KI did it in like 10 minutes on the github web ui lol, i want the blunt feedback. will correct and go further in the morning after actually cloning it
Mquestion: why's BreakneckSleep a struct, especially a disposable one
Pperf
Pit’s a thin wrapper over a sleep primitive
Mis it repeatedly allocated
Pno if the user uses it properly
Mthen what perf benefit does it add to be a struct?
Palright you’ve got me there
Pbut this has no reason to be a class
Pgiven it is a thin wrapper over a sleep primitive
Mwell it's disposable and khitiara wants it to track state
Pyes and I’ve said to Not Do That
Pand structs can be disposable, see ComPtr
Myeah fair point
Kyeah which is fair and the question is now how to actually go about this
Mthey can be but since they have no lifetime tracking i hate doing so unless there's a really good reason to
Ktbh half of why i went and made this is i wanted something to progress with this branch
P- do the sleep
- figure out how much we’ve overshot the sleep and return it
- user passes it in for next time, overshoot is subtracted from the sleep duration
Mso you're tracking state via a ref... i do believe you've reinvented classes
Pbut we’re not tracking state?
Kok but how do we figure out how much weve overshot, because the issue that leads to this is that stuff outside Sleep() is also taking time
Kmy half implementation doesnt even compile since its a readonly struct lol
Myou have a variable that is passed to the method and then returned from the method to be passed again for the next call
Pahhhhh, good point
Pyeah, what part of that is us [BreakneckSleep] tracking state
Kan idea then:
- return GetTimeStamp() and take the last timestamp as a parameter
Kinstead of passing around TimeSpans
Myou're moving that responsibility to the caller but by having that parameter at all you're getting most of the theoretical drawbacks of using a class