can return the last timestamp, but I am hesitant to have the parameter be the timestamp as this impl

can return the last timestamp, but I am hesitant to have the parameter be the timestamp as this implies the previous sleep and the next sleep are related which they may not be in every case.

khitiara•8/15/23, 4:57 AM

if we did go that direction id suggest renaming to something like LoopRateLimiterLoopRateLimiter to not associate with Breakneck, or split that out into a seperate class and keep the native stuff seperate in BreakneckSleep

PPerksey can return the last timestamp, but I am hesitant to have the parameter be the ti...

khitiara•8/15/23, 4:57 AM

true but at that point why have the duration property at all?

PerkseyOP•8/15/23, 4:58 AM

…fair point.

khitiara•8/15/23, 4:58 AM

if youre disconnecting from a sequence of timestamps then this should take the sleep duration as a parameter and lose the inherent periodicity

khitiara•8/15/23, 4:58 AM

and then do as Maxine suggests and have a wrapper type to handle the timestamp part or just do that in the window implementation

Maxine•8/15/23, 4:59 AM

that would get it a lot closer to what its name implies

khitiara•8/15/23, 4:59 AM

id rather have the loop rate limiting aspect be separated so it can be used in other code too but theres no real reason to prefer that

Maxine•8/15/23, 5:01 AM

unrelated; the OS and architecture checks not being guarded in if-else if feels weird to me, is there a particular reason for that

Lyris the Kitori•8/15/23, 5:01 AM

does it matter

Maxine•8/15/23, 5:01 AM

does what matter

Kkhitiara if youre disconnecting from a sequence of timestamps then this should take the s...

PerkseyOP•8/15/23, 5:01 AM

I guess the main thing is the use case of this breakneck type is quite complicated. It needs to sleep for 1/UpdatesPerSecond, 1/FramesPerSecond, or 1/MaxThrottle, and needs to be able to resume sleeping for the next event. e.g. if we resume for render but update is not due yet, then we just need to sleep for the remaining time until update is due or the max throttle (whichever is smaller)

MMaxine does what matter

Lyris the Kitori•8/15/23, 5:01 AM

it not being elseelse

PerkseyOP•8/15/23, 5:01 AM

this is perhaps where the current design breaks down given that duration is not configurable

LLyris the Kitori it not being `else`

Maxine•8/15/23, 5:02 AM

from a readability perspective it would help to understand that none of these if blocks can be entered at the same time at runtime and it would also help if that had to be changed in the future

PPerksey this is perhaps where the current design breaks down given that duration is not ...

PerkseyOP•8/15/23, 5:02 AM

so perhaps duration also needs to be a parameter rather than a configuration option, which thinking about it makes more sense.

Maxine•8/15/23, 5:02 AM

but i know it's a nitpick i was just curious if it was on purpose

PPerksey so perhaps duration also needs to be a parameter rather than a configuration opt...

PerkseyOP•8/15/23, 5:04 AM

I mean really all of this out of scope of this type, this is basically just a wrapper over a sleep function, so really it needs to sleep for TimeSpan and maybe return how long we actually slept for. Any further time tracking is out of scope of this type.

PerkseyOP•8/15/23, 5:04 AM

and would instead be in scope for a proper FrameLimiter type that does track this state

khitiara•8/15/23, 5:05 AM

id call it LoopRateLimiter since its more than frame limits, also update or just general throttling

khitiara•8/15/23, 5:05 AM

but yeah

khitiara•8/15/23, 5:05 AM

adjusted BreakneckSleep to take a duration parameter and pushed

PerkseyOP•8/15/23, 5:06 AM

we can bikeshed the name a bit later on, I’m not 100% on Loop being in the name and just RateLimiter is ambiguous and/or misleading

khitiara•8/15/23, 5:06 AM

yeah

Maxine•8/15/23, 5:06 AM

make it work first figure out the name later

khitiara•8/15/23, 5:07 AM

in any case its 1am for me so i aint doing the actual limiter part now, but breaknecksleep now takes a duration like any self-respecting sleep function should

PPerksey yeah little things like that I have to avoid bringing up in PR reviews because i...

Kai•8/15/23, 10:02 AM

"nit: I would like there to be one more space"
+ GitHub suggestions field makes everything good

PerkseyOP•8/15/23, 2:25 PM

sure but if that’s the only comment I can come up with I just ignore it.

PerkseyOP•8/15/23, 7:13 PM

apologies for not working on silk, this cold is killing me

Lyris the Kitori•8/15/23, 7:19 PM

im still recovering from Sick too

khitiara•8/15/23, 7:19 PM

hope it passes soon

Lyris the Kitori•8/15/23, 7:19 PM

and now SCHOOL is starting in 1 hour

Lyris the Kitori•8/15/23, 7:19 PM

pain.

khitiara•8/15/23, 8:09 PM

whoops, turns out my pr from last night doesnt build still because i didnt have the lab sample thing in my .gen.sln and didnt notice it needed changing

khitiara•8/15/23, 8:09 PM

fixed that now

khitiara•8/15/23, 8:09 PM

dont think im up to actually do the framelimiter part anytime soon, life kinda hell rn and i cant focus, but got this done at least

PerkseyOP•8/20/23, 5:45 PM

experimented with TimeWindow (which uses BreakneckSleep):

PerkseyOP•8/20/23, 5:45 PM

quite all over the place

PerkseyOP•8/20/23, 5:47 PM

0.035 is ~29 FPS and 0.015 is ~66 FPS

PerkseyOP•8/20/23, 5:52 PM

saying that though, without no sleep at all it's very similar, so there may be some issue with how TimeWindow is implemented

PerkseyOP•8/20/23, 5:52 PM

PerkseyOP•8/20/23, 5:53 PM

i'll hand this over to the community to scrutinise further, this is far too intricate for too little for me to care anymore

PerkseyOP•8/20/23, 5:57 PM

OH I'M AN IDIOT

PerkseyOP•8/20/23, 5:58 PM

i still have the old spinny code in windowing

PerkseyOP•8/20/23, 6:02 PM

With BreakneckSleep

PerkseyOP•8/20/23, 6:03 PM

Without BreakneckSleep

PerkseyOP•8/20/23, 6:05 PM

CPU usage peaked around 20% on my laptop without BreakneckSleep

PerkseyOP•8/20/23, 6:05 PM

CPU usage peaked around 30% on my laptop with BreakneckSleep

PerkseyOP•8/20/23, 6:06 PM

yeah I seriously don't know anymore

PerkseyOP•8/20/23, 6:06 PM

unless anyone can figure out how to make BreakneckSleep/TimeWindow work, let's not ship anything here and just stick with our busy loop

PerkseyOP•8/20/23, 7:37 PM

doing updates on the GitHub Runner, don't do anything for a sec please

can return the last timestamp, but I am hesitant to have the parameter be the timestamp as this impl

Similar Threads