y'all got time for reviewing this today? https://github.com/ublue-os/website/pull/424

GitHub

feat: startingpoint rewrite blog 1 by xynydev · Pull Request #424 ·...

This gives a "heads-up" for ublue-os/startingpoint#135 which is basically finished and will be merged soon.
Can y'all do a ping of this on discord #announcements so it doesn't go ...

Xxyny y'all got time for reviewing this today? https://github.com/ublue-os/website/pul...

j0rge•9/3/23, 12:17 PM

is it merged in startingpoint?

akdev•9/3/23, 12:30 PM

I approved it but not sure if we want to merge it right away? Idk it lgtm but I don’t make decisions about publishing stuff

j0rge•9/3/23, 12:30 PM

yeah shouldn't the feature be merged before publishing?

beekabop•9/3/23, 12:54 PM

I'm trying to build an iso with ./util/mkociso -i ghcr.io/ublue-os/silverblue-main:38./util/mkociso -i ghcr.io/ublue-os/silverblue-main:38 from the lorax-compose repo. But it errors out with losetup: cannot find an unused loop devicelosetup: cannot find an unused loop device anybody else encountered this error?

akdev•9/3/23, 12:57 PM

you need

sudo

sudo

beekabop•9/3/23, 12:58 PM

ah alright, thanks

akdev•9/3/23, 12:58 PM

you're the first person to try this other than me afaik so let me know if any issues

Jj0rge yeah shouldn't the feature be merged before publishing?

Gerblesh•9/3/23, 2:36 PM

it's supposed to be a heads up before the merge so people can prepare to port/know what's going on

j0rge•9/3/23, 2:39 PM

ok ok

j0rge•9/3/23, 2:39 PM

so this is good to go? anyone else want to take a look?

Gerblesh•9/3/23, 4:04 PM

I'm adding a PR with a couple more modules, and we still need docs for them

Gerblesh•9/3/23, 4:04 PM

herm is a bit more knowledgable on this stuff

Gerblesh•9/3/23, 4:16 PM

@hermmm https://github.com/ublue-os/startingpoint/pull/142 made the PR that updates the Containerfile and modules (added a systemd module as well)

GitHub

New modules by gerblesh · Pull Request #142 · ublue-os/startingpoint

What's currently done:

added a systemd module
added a files module
Containerfile adjustments

What needs to be done:

Documentation
Debugging/testing

Jj0rge yeah shouldn't the feature be merged before publishing?

xynyOP•9/3/23, 4:31 PM

the article is a heads up, there'll probably be another one post-release. did you read the post before saying this?

GGerblesh @hermmm https://github.com/ublue-os/startingpoint/pull/142 made the PR that upda...

xynyOP•9/3/23, 4:31 PM

cool, i wasn't home today but will have time tomorrow to review

Xxyny cool, i wasn't home today but will have time tomorrow to review

Gerblesh•9/3/23, 4:32 PM

basically all that needs to be done is documentation, I really suck at explaining things so i'll probably need some help

Aakdev I approved it but not sure if we want to merge it right away? Idk it lgtm but I ...

xynyOP•9/3/23, 4:36 PM

i had already added it to the merge queue, it was ready to merge and i merged it now.

xynyOP•9/3/23, 4:37 PM

if there's typos or confusing stuff we can always edit it

Xxyny the article is a heads up, there'll probably be another one post-release. did yo...

j0rge•9/3/23, 4:41 PM

looks like you got it

Jj0rge looks like you got it

xynyOP•9/3/23, 4:44 PM

ok, there's some errors (which i couldn't know about because of mkdocs and mkdocs-insiders)

xynyOP•9/3/23, 4:44 PM

the list formatting (which mkdocs somehow parses in a nonstandard way) is entirely broken

j0rge•9/3/23, 4:45 PM

yeah I think you need to tab in another 4 spaces

xynyOP•9/3/23, 4:45 PM

~~and the index.md article page doesn't show the article at all, only the archive page~~ fixed apparently

Jj0rge yeah I think you need to tab in another 4 spaces

xynyOP•9/3/23, 4:45 PM

should i quickly PR that in blind rn?

j0rge•9/3/23, 4:46 PM

I guess?

j0rge•9/3/23, 4:46 PM

wouldn't hurt

j0rge•9/3/23, 4:46 PM

I'd look at a previous article

j0rge•9/3/23, 4:46 PM

sec I need to drop my son off rq

xynyOP•9/3/23, 4:46 PM

i just used tabs, no spaces

xynyOP•9/3/23, 5:00 PM

created PR https://github.com/ublue-os/website/pull/429

GitHub

fix: misc startingpoint heads-up blog fixes by xynydev · Pull Reque...

List indentation
Better PR review call to action

Remaining minor bug that is another mkdocs peculiarity:

The # symbols at the top level of the included yml block are doubled