`success` can only be `true` in the TypeScript typings

C

CretezyOP•10/6/23, 3:44 PM

node_modules/@cloudflare/workers-types/index.d.ts

node_modules/@cloudflare/workers-types/index.d.ts

node_modules/@cloudflare/workers-types/index.d.ts

node_modules/@cloudflare/workers-types/index.d.ts

CCretezy `success` can only be `true` in the TypeScript typings

M

Max (@rozenmd)•10/6/23, 3:51 PM

success

success

can only be

true

true

in the D1Result type, see D1UpstreamFailure:

interface D1UpstreamFailure {
  results?: never
  error: string
  success: false
  meta: Record<string, unknown>
}

interface D1UpstreamFailure {
  results?: never
  error: string
  success: false
  meta: Record<string, unknown>
}

interface D1UpstreamFailure {
  results?: never
  error: string
  success: false
  meta: Record<string, unknown>
}

interface D1UpstreamFailure {
  results?: never
  error: string
  success: false
  meta: Record<string, unknown>
}

C

CretezyOP•10/6/23, 3:52 PM

I don't see

D1UpstreamFailure

D1UpstreamFailure

D1UpstreamFailure

D1UpstreamFailure is this file. I'm using

"@cloudflare/workers-types": "^4.20230814.0"

"@cloudflare/workers-types": "^4.20230814.0"

"@cloudflare/workers-types": "^4.20230814.0"

"@cloudflare/workers-types": "^4.20230814.0", will update

C

CretezyOP•10/6/23, 3:53 PM

Still nothing in

4.20231002.0

4.20231002.0

4.20231002.0

4.20231002.0. @rozenmd Can you link me to this file?

K

kian•10/6/23, 3:54 PM

D1UpstreamFailure

D1UpstreamFailure

D1UpstreamFailure

D1UpstreamFailure is in the binding rather than the types so the users don't see it

M

Max (@rozenmd)•10/6/23, 3:54 PM

ahhh

M

Max (@rozenmd)•10/6/23, 3:54 PM

Yeah we should probably export it

C

CretezyOP•10/6/23, 3:54 PM

Either way, I think it would be good to mark in the documentation what happens if

success

success

is

false

false

for methods which don't return it

C

CretezyOP•10/6/23, 3:54 PM

E.g., what happens if

success

success

is

false

false

for

first

first

first

first. Does it throw an error, return null, etc

C

CretezyOP•10/6/23, 3:55 PM

Also, should we be checking if

success

success

is

true

true

on every call that returns it? I've been assuming if there's an upstream error it will throw

C

CretezyOP•10/6/23, 3:59 PM

Another note: https://developers.cloudflare.com/workers/wrangler/commands/#execute should likely mention

--local

--local

Commands - Wrangler · Cloudflare Workers docs

Wrangler offers a number of commands to manage your Cloudflare Workers.

M

Matt Silverlock•10/6/23, 4:13 PM

Just landed: every D1 account (on a paid plan) can create up to 50,000 databases, no changes needed: https://developers.cloudflare.com/d1/changelog/#create-up-to-50000-d1-databases

Changelog · Cloudflare D1 docs

Developers using D1 on a Workers Paid plan can now create up to 50,000 databases as part of ongoing increases to D1’s limits.

MMatt Silverlock Just landed: every D1 account (on a paid plan) can create up to 50,000 databases...

C

Cyb3r-Jak3•10/6/23, 4:15 PM

FYI it looks like the reach out link isn’t rendered correctly

MMatt Silverlock Just landed: every D1 account (on a paid plan) can create up to 50,000 databases...

G

GuillaumeLakano•10/6/23, 4:15 PM

There is still the limitation of ~5k per worker to access the D1 databases ?

S

Sam•10/6/23, 4:18 PM

Are jurisdictions still on the roadmap for D1 GA? I found https://discord.com/channels/595317990191398933/1067184198206640188/1124269952237568041 but want to make doubly sure

SSam Are jurisdictions still on the roadmap for D1 GA? I found https://discord.com/ch...

M

Matt Silverlock•10/6/23, 4:19 PM

Yes.

GGuillaumeLakano There is still the limitation of ~5k per worker to access the D1 databases ?

M

Matt Silverlock•10/6/23, 4:19 PM

Yes, per the limits here: https://developers.cloudflare.com/d1/platform/limits/

we'll share an update if anything changes.

MMatt Silverlock Yes, per the limits here: https://developers.cloudflare.com/d1/platform/limits/ ...

G

GuillaumeLakano•10/6/23, 4:21 PM

Do you believe you'll be able to have a kind of dynamic bindings to reach any of theses d1 databases before, or at the release in Q1 2024 ?

GGuillaumeLakano Do you believe you'll be able to have a kind of dynamic bindings to reach any of...

M

Matt Silverlock•10/6/23, 4:22 PM

That is our goal. As I said, we'll share more when we can.

MMatt Silverlock Just landed: every D1 account (on a paid plan) can create up to 50,000 databases...

E

EvanPiro•10/6/23, 4:24 PM

Does CF have any docs out there to help me determine if the database-per-user model is appropriate for my use-case?

EEvanPiro Does CF have any docs out there to help me determine if the database-per-user mo...

M

Matt Silverlock•10/6/23, 4:25 PM

Not at this moment. If you're not sure, I would say: no.

B

bkyerv•10/6/23, 4:32 PM

hello everyone, has anyone had experience setting up drizzle orm with d1? what driver should be used when setting up drizzle config file and what should be used for dbCredentials field?

B

benthecarman•10/6/23, 4:40 PM

Saw you guys made d1 open beta, did you fix the issue where it'll go down for 20+ hours?

E

EvanPiro•10/6/23, 4:53 PM

I'm getting the following error:

$ npx wrangler d1 backup create prod-db

$ npx wrangler d1 backup create prod-db

$ npx wrangler d1 backup create prod-db

$ npx wrangler d1 backup create prod-db

✘ [ERROR] A request to the Cloudflare API (/accounts/some-id/d1/database/some-id/backup) failed.

  The request is malformed: Experimental DBs do not support backups yet:
  some-id (v3) [code: 7400]
  
  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

✘ [ERROR] A request to the Cloudflare API (/accounts/some-id/d1/database/some-id/backup) failed.

  The request is malformed: Experimental DBs do not support backups yet:
  some-id (v3) [code: 7400]
  
  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

✘ [ERROR] A request to the Cloudflare API (/accounts/some-id/d1/database/some-id/backup) failed.

  The request is malformed: Experimental DBs do not support backups yet:
  some-id (v3) [code: 7400]
  
  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

✘ [ERROR] A request to the Cloudflare API (/accounts/some-id/d1/database/some-id/backup) failed.

  The request is malformed: Experimental DBs do not support backups yet:
  some-id (v3) [code: 7400]
  
  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

I'm using

wrangler 3.11.0

wrangler 3.11.0

wrangler 3.11.0

wrangler 3.11.0. Is this error expected? Are backups not yet supported?

J

James•10/6/23, 5:00 PM

This is expected, yes. Time Travel is the new approach here: https://developers.cloudflare.com/d1/learning/time-travel/

Time Travel and backups · Cloudflare D1 docs

Time Travel is D1’s approach to backups and point-in-time-recovery, and allows you to restore a database to any minute within the last 30 days.

Bbenthecarman Saw you guys made d1 open beta, did you fix the issue where it'll go down for 20...

M

Matt Silverlock•10/6/23, 5:08 PM

We haven’t seen any reoccurring instances of this - as we said at the time, this was a very rare (but frustrating) bug.

Bbkyerv hello everyone, has anyone had experience setting up drizzle orm with d1? what d...

M

Matt Silverlock•10/6/23, 5:08 PM

https://github.com/drizzle-team/drizzle-orm/blob/main/examples/cloudflare-d1/README.md

GitHub

drizzle-orm/examples/cloudflare-d1/README.md at main · drizzle-team...

TypeScript ORM that feels like writing SQL. Contribute to drizzle-team/drizzle-orm development by creating an account on GitHub.

JJames This is expected, yes. Time Travel is the new approach here: https://developers....

E

EvanPiro•10/6/23, 5:10 PM

I'm trying to pull a backup from production and load it on local. is this possible with time-travel?

J

James•10/6/23, 5:11 PM

Not to my knowledge. You might want to try a third-party community solution: https://github.com/nora-soderlund/cloudflare-d1-backups

GitHub

GitHub - nora-soderlund/cloudflare-d1-backups: A package to dump a ...

A package to dump a copy of your experimental D1 database through a worker. - GitHub - nora-soderlund/cloudflare-d1-backups: A package to dump a copy of your experimental D1 database through a worker.

JJames Not to my knowledge. You might want to try a third-party community solution: htt...

E

EvanPiro•10/6/23, 5:18 PM

Is there a way to pull backups from the dashboard?

J

James•10/6/23, 5:18 PM

No, Time Travel is the only thing available to new databases at this time in that realm of thought. The community solution I linked above is probably what you're looking for if you need a local copy for now.

B

benthecarman•10/6/23, 5:27 PM

It happened to us once a week lol

W

WillTolmie•10/6/23, 5:50 PM

d1 replication

JJames No, Time Travel is the only thing available to new databases at this time in tha...

E

EvanPiro•10/6/23, 6:11 PM

Thank you, I created a worker that uses the package and am now getting backups to R2 by calling the worker from remote (with auth). Do you know of any commonly used techniques for extending the wrangler CLI so we can add features like this to the runtime and invoke it from the shell/CI?

J

James•10/6/23, 6:13 PM

I do not unfortunately. I'd probably just create a

scripts

scripts

scripts

scripts folder for myself/team to use these kinds of things, personally. You could probably write something that wraps wrangler, but I don't think the effort would be worth it, personally

JJames I do not unfortunately. I'd probably just create a `scripts` folder for myself/t...

E

EvanPiro•10/6/23, 6:19 PM

How do you go about invoking the worker from local and having it run the backup on remote resources? Also is it possible to pull R2 data from remote to local from wrangler?

J

James•10/6/23, 6:20 PM

I don't have this exact use-case, but perhaps you could use

--remote

--remote

? Or put the backup script behind some kind of auth and have a local script hit that?

J

James•10/6/23, 6:21 PM

As for R2 data, I don't think there's an easy way to do that with wrangler or similar, no. You would have to use something to download the contents, perhaps via

rclone

rclone

or similar, and then reconstruct the metadata needed locally. You could try asking in #r2 if anyone has any specific recommendations here.

JJames I don't have this exact use-case, but perhaps you could use `--remote`? Or put t...

E

EvanPiro•10/6/23, 6:34 PM

The use-case is replicating some pretty complex state on prod for development on local.

E

EvanPiro•10/6/23, 6:36 PM

I'm think because I now have a worker that performs the back up, I could also have one that pulls the data and have a script on local which calls both and effectively runs a sync.

Aa3x Why doesn't authjs with the drizzel adapter work with Cloudflare D1? I am gettin...

M

Matt Silverlock•10/6/23, 11:32 PM

I’d open an issue on the Auth.js repo with your code, a reproduction and package versions.

M

malone•10/7/23, 3:20 AM

hey, i'm a bit confused on storage limits - i'm on workers paid

Limits page says 2GB, full stop
https://developers.cloudflare.com/d1/platform/limits/

Pricing says 5GB included, then $0.75/gb/mo
https://developers.cloudflare.com/d1/platform/pricing/

which is it?

Mmalone hey, i'm a bit confused on storage limits - i'm on workers paid Limits page say...

C

Cyb3r-Jak3•10/7/23, 3:26 AM

The 2 GB is per database and the 5 GB is the free quota. So if you have 2x2GB databases then it meets the free plan but you can't have a 3 GB database

CCyb3r-Jak3 The 2 GB is per database and the 5 GB is the free quota. So if you have 2x2GB da...

M

malone•10/7/23, 3:30 AM

aha gotcha! so with one database i can’t go over 2gb even if i pay?

Mmalone aha gotcha! so with one database i can’t go over 2gb even if i pay?

C

Cyb3r-Jak3•10/7/23, 3:37 AM

For now yes. Limit can increase during the beta but can't say for certain as I'm not an employee.

M

malone•10/7/23, 3:38 AM

dang i’m already at like 100mb in testflight so im worried about 2gb limit. i think i might migrate before launching publicly to save having to migrate later

M

malone•10/7/23, 3:38 AM

thanks for clarifying!

A

Adi//•10/7/23, 6:55 AM

I am getting this error while using a complex SQL statement in wrangler D1

"D1_ERROR: A prepared SQL statement must contain only one statement."
Solved: The ;
;
at the end of the SQL statement was breaking it

My statement looks like:

let sql_query = "SELECT *
FROM table_name
WHERE id = ?
  AND timestamp > (
    SELECT MAX(timestamp)
    FROM table_name
  );"

let sql_query = "SELECT *
FROM table_name
WHERE id = ?
  AND timestamp > (
    SELECT MAX(timestamp)
    FROM table_name
  );"

let sql_query = "SELECT *
FROM table_name
WHERE id = ?
  AND timestamp > (
    SELECT MAX(timestamp)
    FROM table_name
  );"

let sql_query = "SELECT *
FROM table_name
WHERE id = ?
  AND timestamp > (
    SELECT MAX(timestamp)
    FROM table_name
  );"

Can I not use combined statements?

`success` can only be `true` in the TypeScript typings

Similar Threads

Similar Threads

Similar Threads